Add check for obsolete CMake end commands

Some commands provide optional arguments:
- else()
- endforeach()
- endfunction()
- endif()
- endmacro()
- endwhile()

These can be also checked and warned about in the output as they are not
recommended to be used neither improve code readability.

Author: petk

bin/check-cmake.php

@@ -380,6 +380,52 @@ function checkCMakeSet(Iterator $files): int
     return $status;
 };
 
+/**
+ * Check for obsolete usages of:
+ *   else(<condition>)
+ *   endif(<condition>)
+ *   endforeach(<loop-var>)
+ *   endwhile(<condition>)
+ *   endfunction(<name>)
+ *   endmacro(<name>)
+ */
+function checkCMakeObsoleteEndCommands(Iterator $files): int
+{
+    $status = 0;
+
+    $commands = [
+        'else',
+        'endif',
+        'endforeach',
+        'endwhile',
+        'endfunction',
+        'endmacro',
+    ];
+
+    foreach ($files as $file) {
+        $content = getCMakeCode($file);
+
+        foreach ($commands as $command) {
+            preg_match_all(
+                '/^[ \t]*(' . $command . ')[ \t]*\((.+)\)/mi',
+                $content,
+                $matches,
+                PREG_SET_ORDER,
+            );
+
+            foreach ($matches as $match) {
+                $foundCommand = $match[1] ?? '';
+                $foundArgument = $match[2] ?? '';
+
+                $status = 1;
+                output("E: Replace $foundCommand($foundArgument) with $command()\n   in $file\n");
+            }
+        }
+    }
+
+    return $status;
+}
+
 /**
  * Find all local Find* modules in the project.
  */
@@ -673,6 +719,9 @@ function checkAll(array $options): int
     $newStatus = checkCMakeSet($allCMakeFiles);
     $status = (0 === $status) ? $newStatus : $status;
 
+    $newStatus = checkCMakeObsoleteEndCommands($allCMakeFiles);
+    $status = (0 === $status) ? $newStatus : $status;
+
     $findModules = getFindModules($options['path'] . '/cmake/cmake/modules');
     $newStatus = checkFindModules($findModules, $allCMakeFiles);
     $status = (0 === $status) ? $newStatus : $status;