Skip to content

Commit b30e3a0

Browse files
committed
Merge branch 'PHP-8.3' into PHP-8.4
2 parents dbd04b0 + e2bd77d commit b30e3a0

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

cmake/cmake/Requirements.cmake

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,12 @@ if(
8989
TYPE REQUIRED
9090
PURPOSE "Necessary to generate PHP parser files."
9191
)
92-
# TODO: Add Bison options based on the build type.
92+
# Add Bison options based on the build type.
93+
set(PHP_DEFAULT_BISON_FLAGS "$<IF:$<CONFIG:Release,MinSizeRel>,-l$<SEMICOLON>-Wall,-Wall>")
94+
# Nicer way would be this, but GNU Bison errors out because it cannot process
95+
# empty double quoted arguments in the command-line.
96+
# See: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9921
9397
#set(PHP_DEFAULT_BISON_FLAGS "-Wall $<$<CONFIG:Release,MinSizeRel>:-l>")
94-
set(PHP_DEFAULT_BISON_FLAGS "-Wall")
9598
endif()
9699

97100
# Check if re2c is required.

0 commit comments

Comments
 (0)