Skip to content

Commit c5462be

Browse files
committed
Refactor PHP/SearchLibraries checks
This adds initial cache entries for Windows target for all php_search_libraries() checks. Variable names synced a bit further.
1 parent 42d2749 commit c5462be

File tree

14 files changed

+438
-430
lines changed

14 files changed

+438
-430
lines changed

cmake/Zend/cmake/MaxExecutionTimers.cmake

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ Check whether to enable Zend max execution timers.
44
Cache variables:
55
66
* ZEND_MAX_EXECUTION_TIMERS
7-
* HAVE_TIMER_CREATE - Whether the system has timer_create().
87
98
Result variables:
109
@@ -50,20 +49,20 @@ if(ZEND_MAX_EXECUTION_TIMERS AND CMAKE_SYSTEM_NAME STREQUAL "Linux")
5049
HEADERS time.h
5150
LIBRARIES
5251
rt # Solaris <= 10, older Linux
53-
VARIABLE HAVE_TIMER_CREATE
54-
LIBRARY_VARIABLE libraryForTimerCreate
52+
VARIABLE PHP_ZEND_HAS_TIMER_CREATE
53+
LIBRARY_VARIABLE PHP_ZEND_HAS_TIMER_CREATE_LIBRARY
5554
)
5655

57-
if(NOT HAVE_TIMER_CREATE)
56+
if(NOT PHP_ZEND_HAS_TIMER_CREATE)
5857
set(ZEND_MAX_EXECUTION_TIMERS OFF)
5958
endif()
6059
else()
6160
set(ZEND_MAX_EXECUTION_TIMERS OFF)
6261
endif()
6362

6463
if(ZEND_MAX_EXECUTION_TIMERS)
65-
if(libraryForTimerCreate)
66-
target_link_libraries(zend PUBLIC ${libraryForTimerCreate})
64+
if(PHP_ZEND_HAS_TIMER_CREATE_LIBRARY)
65+
target_link_libraries(zend PUBLIC ${PHP_ZEND_HAS_TIMER_CREATE_LIBRARY})
6766
endif()
6867

6968
# zend_config.h (or its parent php_config.h) isn't included in some files,

cmake/cmake/ConfigureChecks.cmake

Lines changed: 47 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -414,6 +414,7 @@ include(${CMAKE_CURRENT_LIST_DIR}/checks/CheckFnmatch.cmake)
414414
include(${CMAKE_CURRENT_LIST_DIR}/checks/CheckFopencookie.cmake)
415415
include(${CMAKE_CURRENT_LIST_DIR}/checks/CheckGetaddrinfo.cmake)
416416
include(${CMAKE_CURRENT_LIST_DIR}/checks/CheckGethostbynameR.cmake)
417+
include(${CMAKE_CURRENT_LIST_DIR}/checks/CheckGetifaddrs.cmake)
417418
include(${CMAKE_CURRENT_LIST_DIR}/checks/CheckInline.cmake)
418419
include(${CMAKE_CURRENT_LIST_DIR}/checks/CheckIPv6.cmake)
419420
include(${CMAKE_CURRENT_LIST_DIR}/checks/CheckReentrantFunctions.cmake)
@@ -495,14 +496,16 @@ php_search_libraries(
495496
dlopen
496497
HEADERS dlfcn.h
497498
LIBRARIES ${CMAKE_DL_LIBS}
498-
VARIABLE HAVE_LIBDL
499+
VARIABLE PHP_HAS_DYNAMIC_LOADING
499500
TARGET php_config INTERFACE
500501
)
502+
set(HAVE_LIBDL ${PHP_HAS_DYNAMIC_LOADING})
501503

502504
php_search_libraries(
503505
sin
504506
HEADERS math.h
505507
LIBRARIES m
508+
VARIABLE PHP_HAS_SIN
506509
TARGET php_config INTERFACE
507510
)
508511

@@ -524,6 +527,8 @@ php_search_libraries(
524527
socket # Solaris <= 11.3, illumos
525528
network # Haiku
526529
ws2_32 # Windows
530+
VARIABLE PHP_HAS_SOCKET
531+
LIBRARY_VARIABLE PHP_HAS_SOCKET_LIBRARY
527532
TARGET php_config INTERFACE
528533
)
529534

@@ -534,9 +539,10 @@ php_search_libraries(
534539
LIBRARIES
535540
socket # Solaris <= 11.3, illumos
536541
network # Haiku
537-
VARIABLE HAVE_SOCKETPAIR
542+
VARIABLE PHP_HAS_SOCKETPAIR
538543
TARGET php_config INTERFACE
539544
)
545+
set(HAVE_SOCKETPAIR ${PHP_HAS_SOCKETPAIR})
540546

541547
# The gethostname() is mostly in C library (Solaris/illumos...)
542548
php_search_libraries(
@@ -547,9 +553,11 @@ php_search_libraries(
547553
LIBRARIES
548554
network # Haiku
549555
ws2_32 # Windows
550-
VARIABLE HAVE_GETHOSTNAME
556+
VARIABLE PHP_HAS_GETHOSTNAME
557+
LIBRARY_VARIABLE PHP_HAS_GETHOSTNAME_LIBRARY
551558
TARGET php_config INTERFACE
552559
)
560+
set(HAVE_GETHOSTNAME ${PHP_HAS_GETHOSTNAME})
553561

554562
# The gethostbyaddr() is mostly in C library (Solaris 11.4...)
555563
php_search_libraries(
@@ -562,6 +570,8 @@ php_search_libraries(
562570
nsl # Solaris <= 11.3, illumos
563571
network # Haiku
564572
ws2_32 # Windows
573+
VARIABLE PHP_HAS_GETHOSTBYADDR
574+
LIBRARY_VARIABLE PHP_HAS_GETHOSTBYADDR_LIBRARY
565575
TARGET php_config INTERFACE
566576
)
567577

@@ -577,9 +587,10 @@ php_search_libraries(
577587
LIBRARIES
578588
util # Some BSD-based systems
579589
bsd # Haiku
580-
VARIABLE HAVE_OPENPTY
590+
VARIABLE PHP_HAS_OPENPTY
581591
TARGET php_config INTERFACE
582592
)
593+
set(HAVE_OPENPTY ${PHP_HAS_OPENPTY})
583594

584595
# The inet_ntoa() is mostly in C library (Solaris 11.4, illumos...)
585596
php_search_libraries(
@@ -588,9 +599,10 @@ php_search_libraries(
588599
LIBRARIES
589600
nsl # Solaris <= 11.3
590601
network # Haiku
591-
VARIABLE HAVE_INET_NTOA
602+
VARIABLE PHP_HAS_INET_NTOA
592603
TARGET php_config INTERFACE
593604
)
605+
set(HAVE_INET_NTOA ${PHP_HAS_INET_NTOA})
594606

595607
# The inet_ntop() is mostly in C library (Solaris 11.4, illumos, BSD*, Linux...)
596608
php_search_libraries(
@@ -603,12 +615,14 @@ php_search_libraries(
603615
resolv # Solaris 2.6..7
604616
network # Haiku
605617
ws2_32 # Windows
606-
VARIABLE HAVE_INET_NTOP
618+
VARIABLE PHP_HAS_INET_NTOP
619+
LIBRARY_VARIABLE PHP_HAS_INET_NTOP_LIBRARY
607620
TARGET php_config INTERFACE
608621
)
609-
if(NOT HAVE_INET_NTOP)
622+
if(NOT PHP_HAS_INET_NTOP)
610623
message(FATAL_ERROR "Cannot find 'inet_ntop()' which is required.")
611624
endif()
625+
set(HAVE_INET_NTOP ${PHP_HAS_INET_NTOP})
612626

613627
# The inet_pton() is mostly in C library (Solaris 11.4, illumos...)
614628
php_search_libraries(
@@ -621,9 +635,11 @@ php_search_libraries(
621635
resolv # Solaris 2.6..7
622636
network # Haiku
623637
ws2_32 # Windows
624-
VARIABLE HAVE_INET_PTON
638+
VARIABLE PHP_HAS_INET_PTON
639+
LIBRARY_VARIABLE PHP_HAS_INET_PTON_LIBRARY
625640
TARGET php_config INTERFACE
626641
)
642+
set(HAVE_INET_PTON ${PHP_HAS_INET_PTON})
627643

628644
# The inet_aton() is mostly in C library (Solaris 11.4, illumos...)
629645
php_search_libraries(
@@ -636,9 +652,10 @@ php_search_libraries(
636652
nsl # Solaris <= 11.3
637653
resolv # Solaris 2.6..7
638654
network # Haiku
639-
VARIABLE HAVE_INET_ATON
655+
VARIABLE PHP_HAS_INET_ATON
640656
TARGET php_config INTERFACE
641657
)
658+
set(HAVE_INET_ATON ${PHP_HAS_INET_ATON})
642659

643660
# The nanosleep is mostly in C library (Solaris 11, illumos...)
644661
php_search_libraries(
@@ -647,9 +664,10 @@ php_search_libraries(
647664
time.h
648665
LIBRARIES
649666
rt # Solaris <= 10
650-
VARIABLE HAVE_NANOSLEEP
667+
VARIABLE PHP_HAS_NANOSLEEP
651668
TARGET php_config INTERFACE
652669
)
670+
set(HAVE_NANOSLEEP ${PHP_HAS_NANOSLEEP})
653671

654672
# The setsockopt() is mostly in C library (Solaris 11.4...)
655673
php_search_libraries(
@@ -662,6 +680,8 @@ php_search_libraries(
662680
socket # Solaris <= 11.3, illumos
663681
network # Haiku
664682
ws2_32 # Windows
683+
VARIABLE PHP_HAS_SETSOCKOPT
684+
LIBRARY_VARIABLE PHP_HAS_SETSOCKOPT_LIBRARY
665685
TARGET php_config INTERFACE
666686
)
667687

@@ -674,9 +694,10 @@ php_search_libraries(
674694
LIBRARIES
675695
socket # Solaris <= 11.3, illumos
676696
network # Haiku
677-
VARIABLE HAVE_GAI_STRERROR
697+
VARIABLE PHP_HAS_GAI_STRERROR
678698
TARGET php_config INTERFACE
679699
)
700+
set(HAVE_GAI_STRERROR ${PHP_HAS_GAI_STRERROR})
680701

681702
# The getprotobyname() is mostly in C library (Solaris 11.4...)
682703
php_search_libraries(
@@ -688,9 +709,11 @@ php_search_libraries(
688709
socket # Solaris <= 11.3, illumos
689710
network # Haiku
690711
ws2_32 # Windows
691-
VARIABLE HAVE_GETPROTOBYNAME
712+
VARIABLE PHP_HAS_GETPROTOBYNAME
713+
LIBRARY_VARIABLE PHP_HAS_GETPROTOBYNAME_LIBRARY
692714
TARGET php_config INTERFACE
693715
)
716+
set(HAVE_GETPROTOBYNAME ${PHP_HAS_GETPROTOBYNAME})
694717

695718
# The getprotobynumber() is mostly in C library (Solaris 11.4...)
696719
php_search_libraries(
@@ -702,9 +725,11 @@ php_search_libraries(
702725
socket # Solaris <= 11.3, illumos
703726
network # Haiku
704727
ws2_32 # Windows
705-
VARIABLE HAVE_GETPROTOBYNUMBER
728+
VARIABLE PHP_HAS_GETPROBYNUMBER
729+
LIBRARY_VARIABLE PHP_HAS_GETPROBYNUMBER_LIBRARY
706730
TARGET php_config INTERFACE
707731
)
732+
set(HAVE_GETPROTOBYNUMBER ${PHP_HAS_GETPROBYNUMBER})
708733

709734
# The getservbyname() is mostly in C library (Solaris 11.4...)
710735
php_search_libraries(
@@ -716,9 +741,11 @@ php_search_libraries(
716741
socket # Solaris <= 11.3, illumos
717742
network # Haiku
718743
ws2_32 # Windows
719-
VARIABLE HAVE_GETSERVBYNAME
744+
VARIABLE PHP_HAS_GETSERVBYNAME
745+
LIBRARY_VARIABLE PHP_HAS_GETSERVBYNAME_LIBRARY
720746
TARGET php_config INTERFACE
721747
)
748+
set(HAVE_GETSERVBYNAME ${PHP_HAS_GETSERVBYNAME})
722749

723750
# The getservbyport() is mostly in C library (Solaris 11.4...)
724751
php_search_libraries(
@@ -730,9 +757,11 @@ php_search_libraries(
730757
socket # Solaris <= 11.3, illumos
731758
network # Haiku
732759
ws2_32 # Windows
733-
VARIABLE HAVE_GETSERVBYPORT
760+
VARIABLE PHP_HAS_GETSERVBYPORT
761+
LIBRARY_VARIABLE PHP_HAS_GETSERVBYPORT_LIBRARY
734762
TARGET php_config INTERFACE
735763
)
764+
set(HAVE_GETSERVBYPORT ${PHP_HAS_GETSERVBYPORT})
736765

737766
# The shutdown() is mostly in C library (Solaris 11.4...)
738767
php_search_libraries(
@@ -744,9 +773,11 @@ php_search_libraries(
744773
socket # Solaris <= 11.3, illumos
745774
network # Haiku
746775
ws2_32 # Windows
747-
VARIABLE HAVE_SHUTDOWN
776+
VARIABLE PHP_HAS_SHUTDOWN
777+
LIBRARY_VARIABLE PHP_HAS_SHUTDOWN_LIBRARY
748778
TARGET php_config INTERFACE
749779
)
780+
set(HAVE_SHUTDOWN ${PHP_HAS_SHUTDOWN})
750781

751782
block()
752783
if(PHP_LIBGCC)

0 commit comments

Comments
 (0)