Sync flags for Clang and GNU compiler

In Autotools, the GCC variable is set to "yes" when there is
GNU-compatible compiler detected. Than includes Clang. This refactors
some compile options and definitions a bit further.

Author: petk

cmake/cmake/ConfigureChecks.cmake

@@ -787,8 +787,11 @@ endif()
 
 # Check GCOV.
 if(PHP_GCOV)
-  if(NOT CMAKE_C_COMPILER_ID STREQUAL "GNU")
-    message(FATAL_ERROR "GCC is required for using PHP_GCOV='ON'.")
+  if(NOT CMAKE_C_COMPILER_ID MATCHES "^(.*Clang|GNU)$")
+    message(
+      FATAL_ERROR
+      "GNU-compatible compiler is required for using PHP_GCOV='ON'."
+    )
   endif()
 
   if(CMAKE_C_COMPILER_LAUNCHER MATCHES "ccache")

cmake/cmake/Flags.cmake

@@ -10,6 +10,15 @@ include(PHP/CheckCompilerFlag)
 
 get_property(enabledLanguages GLOBAL PROPERTY ENABLED_LANGUAGES)
 
+# See https://bugs.php.net/28605.
+if(CMAKE_SYSTEM_PROCESSOR MATCHES "^alpha")
+  if(CMAKE_C_COMPILER_ID MATCHES "^(.*Clang|GNU)$")
+    target_compile_options(php_config INTERFACE $<$<COMPILE_LANGUAGE:C>:-mieee>)
+  else()
+    target_compile_options(php_config INTERFACE $<$<COMPILE_LANGUAGE:C>:-ieee>)
+  endif()
+endif()
+
 # Check for broken GCC optimize-strlen.
 include(PHP/CheckBrokenGccStrlenOpt)
 if(PHP_HAVE_BROKEN_OPTIMIZE_STRLEN)

cmake/cmake/Platform.cmake

@@ -24,31 +24,6 @@ include(GNUInstallDirs)
 # Detect C standard library implementation.
 include(PHP/StandardLibrary)
 
-# See https://bugs.php.net/28605.
-if(CMAKE_SYSTEM_PROCESSOR MATCHES "^alpha")
-  if(CMAKE_C_COMPILER_ID STREQUAL "GNU")
-    target_compile_options(
-      php_config
-      INTERFACE
-        $<$<COMPILE_LANGUAGE:ASM,C>:-mieee>
-    )
-  else()
-    target_compile_options(
-      php_config
-      INTERFACE
-        $<$<COMPILE_LANGUAGE:ASM,C>:-ieee>
-    )
-  endif()
-elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "^sparc")
-  if(CMAKE_C_COMPILER_ID STREQUAL "SunPro")
-    target_compile_options(
-      php_config
-      INTERFACE
-        $<$<COMPILE_LANGUAGE:ASM,C>:-xmemalign=8s>
-    )
-  endif()
-endif()
-
 # Platform-specific configuration. When cross-compiling, the host and target can
 # be different values with different configurations.
 if(NOT CMAKE_HOST_SYSTEM_NAME EQUAL CMAKE_SYSTEM_NAME)

cmake/cmake/platforms/HP-UX.cmake

@@ -5,11 +5,17 @@ Specific configuration for HP-UX platform.
 include_guard(GLOBAL)
 
 if(CMAKE_SYSTEM_NAME STREQUAL "HP-UX")
-  target_compile_definitions(
-    php_config
-    INTERFACE
-      $<$<COMPILE_LANG_AND_ID:ASM,GNU>:_XOPEN_SOURCE_EXTENDED>
-      $<$<COMPILE_LANG_AND_ID:C,GNU>:_XOPEN_SOURCE_EXTENDED>
-      $<$<COMPILE_LANG_AND_ID:CXX,GNU>:_XOPEN_SOURCE_EXTENDED>
-  )
+  if(CMAKE_C_COMPILER_ID MATCHES "^(.*Clang|GNU)$")
+    target_compile_definitions(
+      php_config
+      INTERFACE $<$<COMPILE_LANGUAGE:C>:_XOPEN_SOURCE_EXTENDED>
+    )
+  endif()
+
+  if(CMAKE_CXX_COMPILER_ID MATCHES "^(.*Clang|GNU)$")
+    target_compile_definitions(
+      php_config
+      INTERFACE $<$<COMPILE_LANGUAGE:CXX>:_XOPEN_SOURCE_EXTENDED>
+    )
+  endif()
 endif()