Skip to content

Commit f6b1adf

Browse files
committed
Embed PEAR docs into CMakeLists.txt and remove redundant code comments
1 parent 29d9127 commit f6b1adf

File tree

9 files changed

+56
-21
lines changed

9 files changed

+56
-21
lines changed

cmake/ext/com_dotnet/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ project(
2828
LANGUAGES C
2929
)
3030

31-
# Available only for Windows system.
3231
if(NOT CMAKE_SYSTEM_NAME STREQUAL "Windows")
3332
return()
3433
endif()

cmake/ext/pcntl/CMakeLists.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
Configure the `pcntl` extension for process control support (CLI/CGI only).
55
66
> [!NOTE]
7-
> This extension is available only for \*nix systems.
7+
> This extension is available only on \*nix systems.
8+
9+
> [!IMPORTANT]
10+
> This extension should be used only with cgi, cli, embed, or phpdbg SAPI.
811
912
## EXT_PCNTL
1013
@@ -26,7 +29,6 @@ project(
2629
LANGUAGES C
2730
)
2831

29-
# Extension is only for *nix systems.
3032
if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
3133
return()
3234
endif()

cmake/ext/posix/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ project(
2626
LANGUAGES C
2727
)
2828

29-
# Extension is only for *nix systems.
3029
if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
3130
return()
3231
endif()

cmake/ext/sysvmsg/CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Configure the `sysvmsg` extension.
55
66
> [!NOTE]
7-
> This extension is available only for \*nix systems.
7+
> This extension is available only on \*nix systems.
88
99
## EXT_SYSVMSG
1010
@@ -26,7 +26,6 @@ project(
2626
LANGUAGES C
2727
)
2828

29-
# Extension is only for *nix systems.
3029
if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
3130
return()
3231
endif()

cmake/ext/sysvsem/CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Configure the `sysvsem` extension.
55
66
> [!NOTE]
7-
> This extension is available only for \*nix systems.
7+
> This extension is available only on \*nix systems.
88
99
## EXT_SYSVSEM
1010
@@ -26,7 +26,6 @@ project(
2626
LANGUAGES C
2727
)
2828

29-
# Extension is only for *nix systems.
3029
if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
3130
return()
3231
endif()

cmake/pear/CMakeLists.txt

Lines changed: 47 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,48 @@
1+
#[=============================================================================[
2+
# PEAR
3+
4+
Configure PEAR as part of the PHP installation.
5+
6+
> [!WARNING]
7+
> PEAR installation as part of PHP is deprecated as of PHP 7.4 and will be
8+
> removed in future PHP versions. PEAR can also be installed manually from the
9+
> pear.php.net website.
10+
11+
## PHP_PEAR
12+
13+
:orange_circle: *Deprecated as of PHP 7.4.*
14+
15+
* Default: `OFF`
16+
* Values: `ON|OFF`
17+
18+
Install PEAR, PHP Extension and Application Repository package manager.
19+
20+
## PHP_PEAR_DIR
21+
22+
:orange_circle: *Deprecated as of PHP 7.4.*
23+
24+
* Default: `DATADIR/pear`
25+
26+
The path where PEAR will be installed to. `CMAKE_INSTALL_PREFIX` is
27+
automatically prepended when given as a relative path.
28+
29+
## PHP_PEAR_TEMP_DIR
30+
31+
:orange_circle: *Deprecated as of PHP 7.4.*
32+
33+
* Default: `tmp/pear` on \*nix and `temp/pear` on Windows
34+
35+
The PEAR temporary directory where PEAR writes temporary files, such as cache,
36+
downloaded packages artifacts and similar. Pass it as a relative path inside the
37+
top level system directory, which will be automatically prepended. If given as
38+
an absolute path, top level directory is not prepended. Relative path is added
39+
to the top root system directory (`/` on \*nix, or `C:/` on Windows).
40+
41+
For example, default PEAR temporary directory after the top level system
42+
directory is prepended becomes `/tmp/pear` on \*nix and `C:/temp/pear` on
43+
Windows.
44+
#]=============================================================================]
45+
146
include(FeatureSummary)
247
include(PHP/Install)
348
include(PHP/Set)
@@ -15,9 +60,7 @@ php_set(
1560
TYPE PATH
1661
IF PHP_PEAR
1762
VALUE "${CMAKE_INSTALL_DATADIR}/pear"
18-
DOC
19-
"The PEAR installation directory. CMAKE_INSTALL_PREFIX is automatically "
20-
"prepended when given as relative path. Default: DATADIR/pear"
63+
DOC "The PEAR installation directory."
2164
)
2265
mark_as_advanced(PHP_PEAR_DIR)
2366

@@ -31,13 +74,7 @@ php_set(
3174
TYPE PATH
3275
IF PHP_PEAR
3376
VALUE "${tmpDir}"
34-
DOC
35-
"The PEAR temporary directory where PEAR writes temporary files, such as "
36-
"cache, downloaded packages artifacts and similar. Pass it as a relative "
37-
"path inside the top level system directory, which will be automatically "
38-
"prepended. If given as an absolute path, top level directory is not "
39-
"prepended. Relative path is added to the top root system directory (/ on "
40-
"*nix, or c:/ on Windows). Default: ${tmpDir}."
77+
DOC "The PEAR temporary directory. Default: ${tmpDir}."
4178
)
4279
mark_as_advanced(PHP_PEAR_TEMP_DIR)
4380

cmake/sapi/fpm/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ Where to find systemd installation on the system, can be customized with the
8383
> system doesn't have systemd.
8484
#]=============================================================================]
8585

86-
# SAPI is only for *nix systems.
8786
if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
8887
return()
8988
endif()

cmake/sapi/fuzzer/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
44
Configure the `fuzzer` PHP SAPI.
55
6+
> [!NOTE]
7+
> This SAPI is not available when the target system is Windows.
8+
69
## SAPI_FUZZER
710
811
* Default: `OFF`
@@ -21,7 +24,6 @@ library (e.g. libFuzzer). Can be also environment variable. See
2124
https://google.github.io/oss-fuzz
2225
#]=============================================================================]
2326

24-
# SAPI is only for *nix systems.
2527
if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
2628
return()
2729
endif()

cmake/sapi/litespeed/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ Configure the mysqlnd extension.
1414
Enable the LiteSpeed SAPI module.
1515
#]=============================================================================]
1616

17-
# SAPI is only for *nix systems.
1817
if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
1918
return()
2019
endif()

0 commit comments

Comments
 (0)