Skip to content

Conversation

@petk
Copy link
Owner

@petk petk commented Nov 21, 2024

These fixes make using OBJECT libraries simpler and more intuitive according to the CMake recommendations at this state of the build system.

Fixes:

  • A workaround a CMake bug/missing feature where ALIAS targets don't properly propagate when referring to INTERFACE libraries with add_dependencies().
  • All current OBJECT libraries improved and wrapped into interface libraries.
  • Windows OBJECT library improved according to current build system level.
  • FindRE2C improved with VERBATIM and COMMAND_EXPAND_LISTS to hopefully make it behave the same across platforms.

petk added 5 commits November 21, 2024 01:06
These fixes make using OBJECT libraries simpler and more intuitive
according to the CMake recommendations at this state of the build
system.

Fixes:

- A workaround a CMake bug/missing feature where ALIAS targets don't
  properly propagate when referring to INTERFACE libraries with
  `add_dependencies()`.
- All current OBJECT libraries improved and wrapped into interface
  libraries.
- Windows OBJECT library improved according to current build system
  level.
- FindRE2C improved with VERBATIM and COMMAND_EXPAND_LISTS to hopefully
  make it behave the same across platforms.
This links target objects on a single place.
@petk petk merged commit ddc368d into PHP-8.3 Nov 22, 2024
1 of 3 checks passed
@petk petk deleted the patch-object-libraries branch November 22, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants