Improve naming conventions #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CMake there is common issue of naming collisions in extreme cases. There is issue opened upstream about this at: https://gitlab.kitware.com/cmake/cmake/-/issues/22687 Possible target name and cache variable names collisions can happen: - When some project is added with `FetchContent`, as an external project, via `add_subdirectory()` or similar - or the other way around, if PHP would be added via such mechanisms - If some extension would be named `config`, it would collide with global PHP target `php_config` (aliased `PHP::config`). This follows recent PHP SAPI target renames and renames target names for PHP extensions from: `php_<extension>` (aliased `PHP::<extension>`) to: `php_ext_<extension>` (aliased `PHP::ext::<extension>`) This adds abbreviated letters to target names to better organize them in various scenarios, while still not increasing usage complexity too much. Possible further adjustments following up...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CMake there is common issue of naming collisions in extreme cases.
There is issue opened upstream about this at:
https://gitlab.kitware.com/cmake/cmake/-/issues/22687
Possible target name and cache variable names collisions can happen:
FetchContent, as an external project, viaadd_subdirectory()or similarconfig, it would collide with the global PHP targetphp_config(aliasedPHP::config)This follows recent PHP SAPI target renames and syncs target names for PHP extensions from:
php_<extension_name>(aliasedPHP::<extension_name>)to:
php_ext_<extension_name>(aliasedPHP::ext::<extension_name>)This adds abbreviated letters to target names to better organize them in various scenarios, while still not increasing usage complexity too much.
The lower case snake_case style is used for simpler machine processing extension names and their directory names inside the
php-src/extdirectory.For example,
php_ext_pdo_firebird(aliasedPHP::ext::pdo_firebird) might find thephp-src/ext/pdo_firebirdpath a bit easier than CamelCase style names such asPhpExtensionPdoFirebird,PHP::Ext::PdoFirebird, etc.Possible further adjustments following up...