Terraform dependency issue

[sov-msaeed]

Hello @petoju ,

I think we might have a problem here https://registry.terraform.io/providers/petoju/mysql/latest/docs/resources/grant from the example in the docs

resource "mysql_user" "jdoe" {
  user               = "jdoe"
  host               = "example.com"
  plaintext_password = "password"
}

resource "mysql_grant" "jdoe" {
  user       = mysql_user.jdoe.user
  host       = mysql_user.jdoe.host
  database   = "app"
  privileges = ["SELECT", "UPDATE"]
}

if let's say i try to change the user auth_plugin to something different, I get the plan to recreate only the user but not to recreate the grants so we will need to run terraform 2 times in this case which is not optimal. I think the issue is that the grants are relying on the name and the host no the user_id so in the grants, it should be a parameter user_id which can be the output of the previous mysql_user.jdoe.id and then it might work.

[petoju]

@sov-msaeed ah, in resource_user.go, we ForceNew when auth_plugin is changed.

I'd almost bet it can be just removed, but I believe it needs also some testing to verify that change works in edge cases. Have you tried it? Did it help?

If it worked, I'd merge your change.

[sov-msaeed]

@petoju No I haven't tested. So you are saying that this was wrong change and changing auth_plugin shouldn't be forcing recreating the resource ?

[petoju]

@sov-msaeed it's not bad change from your side, it's possibly incorrect ForceNew in code of the provider. But I'm reasonably sure it could work without that.

[sov-msaeed]

@petoju i am not sure which change you refer to :) sorry. but I think you mean https://github.com/petoju/terraform-provider-mysql/blob/master/mysql/resource_user.go#L78 and https://github.com/petoju/terraform-provider-mysql/blob/master/mysql/resource_user.go#L86 that should both be false as alter user would normally work and only user and host change should trigger the user recreation and i assume that will also trigger the user grants recreation. correct ?

[petoju]

@sov-msaeed I meant
https://github.com/petoju/terraform-provider-mysql/blob/master/mysql/resource_user.go#L78

For aad_identity - I'd leave it as it is as it's not explicitly handled in update, only in creation. Or it needs more work.