FeatureGate - MultiDiskSetup

jcpowermac · jcpowermac · commit 03e897d1c94e · 2025-07-02T07:58:29.000-04:00
This PR adds a new featuregate for the installer
to gate setting up multiple disks via machine config.
diff --git a/features.md b/features.md
@@ -49,6 +49,7 @@
 | MaxUnavailableStatefulSet| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | MinimumKubeletVersion| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | MixedCPUsAllocation| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
+| MultiDiskSetup| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | NodeSwap| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | NutanixMultiSubnets| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | OVNObservability| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
diff --git a/features/features.go b/features/features.go
@@ -807,6 +807,14 @@ var (
 							enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
 							mustRegister()
 
+	FeatureGateMultiDiskSetup = newFeatureGate("MultiDiskSetup").
+					reportProblemsToJiraComponent("splat").
+					contactPerson("jcpowermac").
+					productScope(ocpSpecific).
+					enhancementPR("https://github.com/openshift/enhancements/pull/1805").
+					enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
+					mustRegister()
+
 	FeatureGateAWSDedicatedHosts = newFeatureGate("AWSDedicatedHosts").
 					reportProblemsToJiraComponent("Installer").
 					contactPerson("faermanj").
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml b/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
@@ -133,6 +133,9 @@
                     {
                         "name": "MultiArchInstallAzure"
                     },
+                    {
+                        "name": "MultiDiskSetup"
+                    },
                     {
                         "name": "MutatingAdmissionPolicy"
                     },
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml
@@ -218,6 +218,9 @@
                     {
                         "name": "MixedCPUsAllocation"
                     },
+                    {
+                        "name": "MultiDiskSetup"
+                    },
                     {
                         "name": "NetworkDiagnosticsConfig"
                     },
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
@@ -224,6 +224,9 @@
                     {
                         "name": "MixedCPUsAllocation"
                     },
+                    {
+                        "name": "MultiDiskSetup"
+                    },
                     {
                         "name": "NetworkDiagnosticsConfig"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
@@ -136,6 +136,9 @@
                     {
                         "name": "MultiArchInstallAzure"
                     },
+                    {
+                        "name": "MultiDiskSetup"
+                    },
                     {
                         "name": "MutatingAdmissionPolicy"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml
@@ -203,6 +203,9 @@
                     {
                         "name": "MixedCPUsAllocation"
                     },
+                    {
+                        "name": "MultiDiskSetup"
+                    },
                     {
                         "name": "NetworkDiagnosticsConfig"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
@@ -209,6 +209,9 @@
                     {
                         "name": "MixedCPUsAllocation"
                     },
+                    {
+                        "name": "MultiDiskSetup"
+                    },
                     {
                         "name": "NetworkDiagnosticsConfig"
                     },

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,9 @@`
`133`	`133`	`{`
`134`	`134`	`"name": "MultiArchInstallAzure"`
`135`	`135`	`},`
	`136`	`+ {`
	`137`	`+ "name": "MultiDiskSetup"`
	`138`	`+ },`
`136`	`139`	`{`
`137`	`140`	`"name": "MutatingAdmissionPolicy"`
`138`	`141`	`},`
Original file line number	Diff line number	Diff line change
`@@ -218,6 +218,9 @@`
`218`	`218`	`{`
`219`	`219`	`"name": "MixedCPUsAllocation"`
`220`	`220`	`},`
	`221`	`+ {`
	`222`	`+ "name": "MultiDiskSetup"`
	`223`	`+ },`
`221`	`224`	`{`
`222`	`225`	`"name": "NetworkDiagnosticsConfig"`
`223`	`226`	`},`
Original file line number	Diff line number	Diff line change
`@@ -224,6 +224,9 @@`
`224`	`224`	`{`
`225`	`225`	`"name": "MixedCPUsAllocation"`
`226`	`226`	`},`
	`227`	`+ {`
	`228`	`+ "name": "MultiDiskSetup"`
	`229`	`+ },`
`227`	`230`	`{`
`228`	`231`	`"name": "NetworkDiagnosticsConfig"`
`229`	`232`	`},`
Original file line number	Diff line number	Diff line change
`@@ -136,6 +136,9 @@`
`136`	`136`	`{`
`137`	`137`	`"name": "MultiArchInstallAzure"`
`138`	`138`	`},`
	`139`	`+ {`
	`140`	`+ "name": "MultiDiskSetup"`
	`141`	`+ },`
`139`	`142`	`{`
`140`	`143`	`"name": "MutatingAdmissionPolicy"`
`141`	`144`	`},`
Original file line number	Diff line number	Diff line change
`@@ -203,6 +203,9 @@`
`203`	`203`	`{`
`204`	`204`	`"name": "MixedCPUsAllocation"`
`205`	`205`	`},`
	`206`	`+ {`
	`207`	`+ "name": "MultiDiskSetup"`
	`208`	`+ },`
`206`	`209`	`{`
`207`	`210`	`"name": "NetworkDiagnosticsConfig"`
`208`	`211`	`},`
Original file line number	Diff line number	Diff line change
`@@ -209,6 +209,9 @@`
`209`	`209`	`{`
`210`	`210`	`"name": "MixedCPUsAllocation"`
`211`	`211`	`},`
	`212`	`+ {`
	`213`	`+ "name": "MultiDiskSetup"`
	`214`	`+ },`
`212`	`215`	`{`
`213`	`216`	`"name": "NetworkDiagnosticsConfig"`
`214`	`217`	`},`