Move kube-api-linter to a go-plugin integration

Author: JoelSpeed

.golangci.yaml

@@ -6,7 +6,7 @@ linters:
   settings:
     custom:
       kubeapilinter:
-        type: module
+        path: tools/_output/bin/kube-api-linter.so
         description: kubeapilinter is the Kube-API-Linter and lints Kube like APIs based on API conventions and best practices.
         settings:
           linters:

hack/golangci-lint.sh

@@ -4,8 +4,8 @@ source "$(dirname "${BASH_SOURCE}")/lib/init.sh"
 
 # Build codegen-crds when it's not present and not overriden for a specific file.
 if [ -z "${GOLANGCI_LINT:-}" ];then
-  ${TOOLS_MAKE} golangci-kube-api-linter
-  GOLANGCI_LINT="${TOOLS_OUTPUT}/golangci-kube-api-linter"
+  ${TOOLS_MAKE} golangci-lint kube-api-linter
+  GOLANGCI_LINT="${TOOLS_OUTPUT}/golangci-lint"
 fi
 
 # In CI, HOME is set to / and is not writable.

tools/.custom-gcl.yml

@@ -57,8 +57,11 @@ deepcopy-gen: $(OUTPUT_DIR)/deepcopy-gen
 .PHONY:go-to-protobuf
 go-to-protobuf: $(OUTPUT_DIR)/go-to-protobuf
 
-.PHONY:golangci-kube-api-linter
-golangci-kube-api-linter: $(OUTPUT_DIR)/golangci-kube-api-linter
+.PHONY:golangci-lint
+golangci-lint: $(OUTPUT_DIR)/golangci-lint
+
+.PHONY:kube-api-linter
+kube-api-linter: $(OUTPUT_DIR)/kube-api-linter.so
 
 .PHONY:openapi-gen
 openapi-gen: $(OUTPUT_DIR)/openapi-gen
@@ -107,11 +110,9 @@ $(OUTPUT_DIR)/go-to-protobuf: $(OUTPUT_DIR)/vendor-version
 $(OUTPUT_DIR)/golangci-lint: $(OUTPUT_DIR)/vendor-version
 	go build -mod=vendor -o $(OUTPUT_DIR)/golangci-lint ./vendor/github.com/golangci/golangci-lint/v2/cmd/golangci-lint
 
-# The golangci-lint custom command relies on finding a module, this uses a workaround to init the go.mod in the kal directory.
-$(OUTPUT_DIR)/golangci-kube-api-linter: $(OUTPUT_DIR)/vendor-version $(OUTPUT_DIR)/golangci-lint
-	GOFLAGS=-mod=readonly $(OUTPUT_DIR)/golangci-lint custom
-	@ mv bin/golangci-kube-api-linter $(OUTPUT_DIR)/golangci-kube-api-linter
-	@ rmdir bin
+$(OUTPUT_DIR)/kube-api-linter.so: $(OUTPUT_DIR)/vendor-version
+	go build -mod=vendor -buildmode=plugin -o $(OUTPUT_DIR)/kube-api-linter.so ./vendor/sigs.k8s.io/kube-api-linter/pkg/plugin
+	ln -fs $(OUTPUT_DIR)/kube-api-linter.so $(TOOLS_DIR)/_output/bin/kube-api-linter.so
 
 $(OUTPUT_DIR)/openapi-gen: $(OUTPUT_DIR)/vendor-version
 	go build -mod=vendor -o $(OUTPUT_DIR)/openapi-gen ./vendor/k8s.io/code-generator/cmd/openapi-gen

tools/Makefile

@@ -15,5 +15,5 @@ import (
 	_ "k8s.io/code-generator/cmd/go-to-protobuf/protoc-gen-gogo"
 	_ "k8s.io/code-generator/cmd/prerelease-lifecycle-gen"
 	_ "sigs.k8s.io/controller-tools/cmd/controller-gen"
-	_ "sigs.k8s.io/kube-api-linter"
+	_ "sigs.k8s.io/kube-api-linter/pkg/plugin"
 )