lib/resourcemerge: Fix non-constant format string in call to Errorf

DavidHurta · DavidHurta · commit 4ceef7dcd745 · 2025-02-05T12:14:18.000+01:00
As noticed by a golangci-lint run:

```sh
lib/resourcemerge/batch_test.go:417:16: printf: non-constant format string in call to (*testing.common).Errorf (govet)
                                                t.Errorf(test.name + " should have panicked!")
```
diff --git a/lib/resourcemerge/batch_test.go b/lib/resourcemerge/batch_test.go
@@ -414,7 +414,7 @@ func TestEnsureJob_JobSpec_Selector(t *testing.T) {
 				switch r := recover(); r {
 				case nil:
 					if test.expectedPanic {
-						t.Errorf(test.name + " should have panicked!")
+						t.Errorf("%s should have panicked!", test.name)
 					}
 				default:
 					if !test.expectedPanic {

Original file line number	Diff line number	Diff line change
`@@ -414,7 +414,7 @@ func TestEnsureJob_JobSpec_Selector(t *testing.T) {`
`414`	`414`	`switch r := recover(); r {`
`415`	`415`	`case nil:`
`416`	`416`	`if test.expectedPanic {`
`417`		`- t.Errorf(test.name + " should have panicked!")`
	`417`	`+ t.Errorf("%s should have panicked!", test.name)`
`418`	`418`	`}`
`419`	`419`	`default:`
`420`	`420`	`if !test.expectedPanic {`