Petterh/azure devops (#12)

* Diagnostics for Azure DevOps issue
* Update azure-pipelines.yml for Azure Pipelines
* Add build status banner
* Find React Native location and version dynamically
* Remove BUCK stuff
* Remove package-lock.json
* Tweak react versions: expo/expo#3949

Author: petterh

README.md

@@ -1,5 +1,7 @@
 # React Native Activity Demo
 
+[![Build Status](https://dev.azure.com/petter0012/react-native-android-activity/_apis/build/status/petterh.react-native-android-activity?branchName=master)](https://dev.azure.com/petter0012/react-native-android-activity/_build/latest?definitionId=1&branchName=master)
+
 This sample, which grew out of a [question on Stack Overflow](https://stackoverflow.com/questions/42253397/call-android-activity-from-react-native-code/43675819), demonstrates the interface between React Native JavaScript and Java code in host applications.
 
 The original version was Android-only; support for iOS was added March 28 2019.

android/app/build.gradle

@@ -15,8 +15,8 @@ import com.android.build.OutputFile
  * https://github.com/facebook/react-native/pull/21408
  */
 
-def bundleInDebug = hasProperty("bundleInDebug") && Boolean.valueOf(property("bundleInDebug"))
-def useDevSupport = !bundleInDebug
+final bundleInDebug = hasProperty("bundleInDebug") && Boolean.valueOf(property("bundleInDebug"))
+final useDevSupport = !bundleInDebug
 
 project.ext.react = [
     // The name of the generated asset file containing your JS bundle
@@ -83,12 +83,12 @@ apply from: "../../node_modules/react-native/react.gradle"
  * Upload all the APKs to the Play Store and people will download
  * the correct one based on the CPU architecture of their device.
  */
-def enableSeparateBuildPerCPUArchitecture = false
+final enableSeparateBuildPerCPUArchitecture = false
 
 /**
  * Run Proguard to shrink the Java bytecode in release builds.
  */
-def enableProguardInReleaseBuilds = false
+final enableProguardInReleaseBuilds = false
 
 android {
     compileSdkVersion 28
@@ -109,7 +109,7 @@ android {
         abi {
             reset()
             enable enableSeparateBuildPerCPUArchitecture
-            universalApk false  // If true, also generate a universal APK
+            universalApk false // If true, also generate a universal APK
             include 'armeabi-v7a', 'arm64-v8a', 'x86', 'x86_64'
         }
     }
@@ -139,7 +139,7 @@ android {
         }
     }
 
-    // This is necessary to include the JavaScript bundle in the APK:
+    // Ensure that the JavaScript bundle is included in the APK:
     sourceSets {
         main {
             debug {
@@ -157,14 +157,7 @@ android {
 dependencies {
     implementation fileTree(dir: 'libs', include: ['*.jar'])
     implementation 'com.android.support:appcompat-v7:28.0.0'
-    implementation('com.facebook.react:react-native:0.59.9') {
+    implementation("com.facebook.react:react-native:$rootProject.ext.reactNativeVersion") {
         exclude group: 'com.android.support'
     }
 }
-
-// Run this once to be able to run the application with BUCK
-// puts all compile dependencies into folder libs for BUCK to use
-task copyDownloadableDepsToLibs(type: Copy) {
-    from configurations.compile
-    into 'libs'
-}

android/build.gradle

@@ -1,3 +1,5 @@
+import groovy.json.JsonSlurper
+
 // Top-level build file where you can add configuration options common to all sub-projects/modules.
 
 buildscript {
@@ -6,7 +8,7 @@ buildscript {
         google()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.4.1'
+        classpath 'com.android.tools.build:gradle:3.4.2'
 
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files
@@ -17,11 +19,58 @@ allprojects {
     repositories {
         maven {
             // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
-            url "$rootDir/../node_modules/react-native/android"
+            url findReactNative()
         }
 
         mavenLocal()
         jcenter()
         google()
     }
 }
+
+final findReactNative() {
+    final reactNativePath = 'node_modules/react-native/android'
+    final notFoundMessage = 'Unable to find React Native. Have you run yarn from the root?'
+
+    def root = file("$rootDir")
+    if (root == null) {
+        throw new GradleException(notFoundMessage)
+    }
+
+    def reactNativeDir = new File(root, reactNativePath);
+    while (!reactNativeDir.exists()) {
+        root = root.parentFile
+        if (root == null) {
+            throw new GradleException(notFoundMessage)
+        }
+
+        reactNativeDir = new File(root, reactNativePath);
+    }
+
+    return reactNativeDir.toString()
+}
+
+ext {
+    reactNativeVersion = getReactNativeVersion()
+}
+
+/**
+ * Get the React Native version from package.json
+ */
+final getReactNativeVersion() {
+    final json = new JsonSlurper()
+    final packageJsonFile = file('../package.json')
+    if (!packageJsonFile.exists()) {
+        throw new Exception('No package.json found')
+    }
+
+    final packageJson = json.parse packageJsonFile
+    final reactNativeVersion = packageJson.dependencies."react-native"
+    if (!reactNativeVersion) {
+        throw new Exception('No react native version found in package.json dependencies')
+    }
+
+    println "React native version: $reactNativeVersion"
+
+    return reactNativeVersion
+}

android/gradle.properties

@@ -17,7 +17,6 @@ org.gradle.jvmargs=-Xmx2048m -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryErro
 # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
 # org.gradle.parallel=true
 
-android.useDeprecatedNdk=true
 android.debug.obsoleteApi=true
 
 bundleInDebug=true

azure-pipelines.yml

@@ -15,13 +15,11 @@ steps:
     versionSpec: '10.x'
   displayName: 'Install Node.js'
 
-- script: |
-    npm install
-    pwd
-    ls android/*
-    ls node_modules/react-native/*
+- task: Npm@1
+  inputs:
+    command: 'install'
   displayName: 'npm install'
-  
+
 - task: Gradle@2
   inputs:
     gradleWrapperFile: 'android/gradlew'

package.json

@@ -3,19 +3,19 @@
     "repository": {
         "type": "git",
         "url": "https://github.com/petterh/react-native-android-activity.git"
-      },
-    "version": "5.0.0",
+    },
+    "version": "5.0.2",
     "private": true,
     "scripts": {
         "start": "node node_modules/react-native/local-cli/cli.js start"
     },
     "dependencies": {
-        "react": "^16.8.6",
-        "react-native": "^0.59.9"
+        "react": "16.8.3",
+        "react-native": "0.59.9"
     },
     "devDependencies": {
         "babel-loader": "8.0.6",
         "babel-plugin-transform-runtime": "6.23.0",
-        "metro-react-native-babel-preset": "^0.54.1"
+        "metro-react-native-babel-preset": "0.55.0"
     }
 }