Fix clang-tidy warnings

Author: pezcode

.gitignore

@@ -1,7 +1,8 @@
-assets/models/
-build/
-screenshots/
-.vs/
-.vscode/
-CMakeSettings.json
-*.cap
+/assets/models/
+/build/
+/out/
+/screenshots/
+/.vs/
+*/.vscode/
+/CMakeSettings.json
+/*.cap

src/Cluster.cpp

@@ -121,7 +121,7 @@ void Cluster::initialize(int _argc, char* _argv[])
                                   { { 5.0f, 0.3f, 0.0f }, { 100.0f, 100.0f, 100.0f } }
     };
     scene->pointLights.update();
-    config->lights = scene->pointLights.lights.size();
+    config->lights = (int)scene->pointLights.lights.size();
 
     frameNumber = 0;
 }

src/Renderer/Renderer.cpp

@@ -15,6 +15,8 @@
 bgfx::VertexDecl Renderer::PosVertex::decl;
 
 Renderer::Renderer(const Scene* scene) :
+    buffers(nullptr),
+    frameBuffer(BGFX_INVALID_HANDLE),
     tonemappingMode(TonemappingMode::NONE),
     scene(scene),
     width(0),
@@ -23,7 +25,6 @@ Renderer::Renderer(const Scene* scene) :
     time(0.0f),
     viewMat(1.0f),
     projMat(1.0f),
-    frameBuffer(BGFX_INVALID_HANDLE),
     blitTriangleBuffer(BGFX_INVALID_HANDLE),
     blitProgram(BGFX_INVALID_HANDLE),
     blitSampler(BGFX_INVALID_HANDLE),

src/Renderer/Renderer.h

@@ -55,7 +55,7 @@ class Renderer
         const char* name;
     };
 
-    TextureBuffer* buffers = nullptr;
+    TextureBuffer* buffers;
 
     // final output
     // used for tonemapping, screenshots

src/Scene/Scene.cpp

@@ -243,7 +243,6 @@ Mesh Scene::loadMesh(const aiMesh* mesh)
     const bgfx::Memory* iMem = bgfx::alloc(mesh->mNumFaces * 3 * sizeof(uint16_t));
     uint16_t* indices = (uint16_t*)iMem->data;
 
-    const aiFace* faces = mesh->mFaces;
     for(unsigned int i = 0; i < mesh->mNumFaces; i++)
     {
         assert(mesh->mFaces[i].mNumIndices == 3);

src/UI.cpp

@@ -65,7 +65,7 @@ void ClusterUI::initialize()
     iconsConfig.PixelSnapH = true;
     iconsConfig.OversampleH = 1;
     iconsConfig.OversampleV = 1;
-    ImFont* iconFont = io.Fonts->AddFontFromFileTTF(iconFontFile, 13.0f, &iconsConfig);
+    io.Fonts->AddFontFromFileTTF(iconFontFile, 13.0f, &iconsConfig);
 
     // Generate font texture
     unsigned char* tex_data = nullptr;
@@ -79,7 +79,7 @@ void ClusterUI::initialize()
                                         bgfx::TextureFormat::RGBA8,
                                         0,
                                         bgfx::copy(tex_data, tex_w * tex_h * bytes));
-    io.Fonts->SetTexID((ImTextureID)fontTexture.idx);
+    io.Fonts->SetTexID((ImTextureID)(uintptr_t)fontTexture.idx);
 }
 
 void ClusterUI::update(float dt)
@@ -395,7 +395,7 @@ void ClusterUI::update(float dt)
 
         for(size_t i = 0; buffers[i].name != nullptr; i++)
         {
-            ImGui::Text(buffers[i].name);
+            ImGui::Text("%s", buffers[i].name);
             ImTextureID texId = ImTextureID(uintptr_t(buffers[i].handle.idx));
             ImVec2 texSize = io.DisplaySize;
             texSize = { 128.0f, 128.0f };