optimizing for coverage. in any case, i think this is better anyway

Author: pfeatherstone

examples/fuzz/request_parser.cpp

@@ -7,7 +7,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size)
     std::string     buf(reinterpret_cast<const char*>(data), size);
     http::request   req{};
     std::error_code ec{};
-    http::parser<http::request> parser;
+    http::parser_request parser;
     parser.parse(req, buf, ec);
     bool is_keep_alive    = req.keep_alive();
     bool is_websocket_req = req.is_websocket_req();

examples/fuzz/response_parser.cpp

@@ -7,7 +7,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size)
     std::string      buf(reinterpret_cast<const char*>(data), size);
     http::response   resp{};
     std::error_code  ec{};
-    http::parser<http::response> parser;
+    http::parser_response parser;
     parser.parse(resp, buf, ec);
     buf.clear();
     ec = {};

examples/fuzz/websocket_parser.cpp

@@ -8,7 +8,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size)
 
     http::request   req{};
     std::error_code ec{};
-    http::parser<http::request> parser;
+    http::parser_request parser;
     parser.parse(req, buf, ec);
     bool is_websocket_req = req.is_websocket_req();
 

examples/unit_tests/message.cpp

@@ -115,7 +115,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::request req;
             std::error_code ec{};
-            bool finished = http::parser<http::request>{}.parse(req, bad_req, ec);
+            bool finished = http::parser_request{}.parse(req, bad_req, ec);
             REQUIRE(ec == http::http_read_bad_method);
         }
 
@@ -130,7 +130,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::request req;
             std::error_code ec{};
-            bool finished = http::parser<http::request>{}.parse(req, bad_req, ec);
+            bool finished = http::parser_request{}.parse(req, bad_req, ec);
             REQUIRE(ec == http::http_read_unsupported_http_version);
         }
 
@@ -145,7 +145,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::request req;
             std::error_code ec{};
-            bool finished = http::parser<http::request>{}.parse(req, bad_req, ec);
+            bool finished = http::parser_request{}.parse(req, bad_req, ec);
             REQUIRE(ec == http::http_read_unsupported_http_version);
         }
 
@@ -160,7 +160,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::request req;
             std::error_code ec{};
-            bool finished = http::parser<http::request>{}.parse(req, bad_req, ec);
+            bool finished = http::parser_request{}.parse(req, bad_req, ec);
             REQUIRE(ec == http::http_read_unsupported_http_version);
         }
 
@@ -175,7 +175,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::request req;
             std::error_code ec{};
-            bool finished = http::parser<http::request>{}.parse(req, bad_req, ec);
+            bool finished = http::parser_request{}.parse(req, bad_req, ec);
             REQUIRE(ec == http::http_read_header_kv_delimiter_not_found);
         }
 
@@ -191,7 +191,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::request req;
             std::error_code ec{};
-            bool finished = http::parser<http::request>{}.parse(req, bad_req, ec);
+            bool finished = http::parser_request{}.parse(req, bad_req, ec);
             REQUIRE(ec == http::http_read_header_unsupported_field); // (It should be "Host:" not "Host :")
         }
 
@@ -206,7 +206,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::request req;
             std::error_code ec{};
-            bool finished = http::parser<http::request>{}.parse(req, bad_req, ec);
+            bool finished = http::parser_request{}.parse(req, bad_req, ec);
             REQUIRE(!bool(ec));
             REQUIRE(!finished); // Incorrect Content-Length
             REQUIRE(bad_req.empty());
@@ -222,7 +222,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::request req;
             std::error_code ec{};
-            bool finished = http::parser<http::request>{}.parse(req, bad_req, ec);
+            bool finished = http::parser_request{}.parse(req, bad_req, ec);
             REQUIRE(!bool(ec));
             REQUIRE(!finished); // Waiting for \r\n to test header
         }
@@ -239,7 +239,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::request req;
             std::error_code ec{};
-            bool finished = http::parser<http::request>{}.parse(req, bad_req, ec);
+            bool finished = http::parser_request{}.parse(req, bad_req, ec);
             REQUIRE(!bool(ec));
             REQUIRE(finished); // Done
             REQUIRE(bad_req.empty());
@@ -258,7 +258,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::response reply;
             std::error_code ec{};
-            bool finished = http::parser<http::response>{}.parse(reply, bad_reply, ec);
+            bool finished = http::parser_response{}.parse(reply, bad_reply, ec);
             REQUIRE(ec == http::http_read_unsupported_http_version);
         }
 
@@ -272,7 +272,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::response reply;
             std::error_code ec{};
-            bool finished = http::parser<http::response>{}.parse(reply, bad_reply, ec);
+            bool finished = http::parser_response{}.parse(reply, bad_reply, ec);
             REQUIRE(ec == http::http_read_unsupported_http_version);
         }
 
@@ -286,7 +286,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::response reply;
             std::error_code ec{};
-            bool finished = http::parser<http::response>{}.parse(reply, bad_reply, ec);
+            bool finished = http::parser_response{}.parse(reply, bad_reply, ec);
             REQUIRE(ec == http::http_read_unsupported_http_version);
         }
 
@@ -300,7 +300,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::response reply;
             std::error_code ec{};
-            bool finished = http::parser<http::response>{}.parse(reply, bad_reply, ec);
+            bool finished = http::parser_response{}.parse(reply, bad_reply, ec);
             REQUIRE(ec == http::http_read_bad_status);
         }
 
@@ -314,7 +314,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::response reply;
             std::error_code ec{};
-            bool finished = http::parser<http::response>{}.parse(reply, bad_reply, ec);
+            bool finished = http::parser_response{}.parse(reply, bad_reply, ec);
             REQUIRE(ec == http::http_read_header_kv_delimiter_not_found);
         }
 
@@ -328,7 +328,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::response reply;
             std::error_code ec{};
-            bool finished = http::parser<http::response>{}.parse(reply, bad_reply, ec);
+            bool finished = http::parser_response{}.parse(reply, bad_reply, ec);
             REQUIRE(ec == http::http_read_header_unsupported_field);
         }
 
@@ -342,7 +342,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::response reply;
             std::error_code ec{};
-            bool finished = http::parser<http::response>{}.parse(reply, bad_reply, ec);
+            bool finished = http::parser_response{}.parse(reply, bad_reply, ec);
             REQUIRE(ec == http::http_read_header_unsupported_field);
         }
 
@@ -356,7 +356,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::response reply;
             std::error_code ec{};
-            bool finished = http::parser<http::response>{}.parse(reply, bad_reply, ec);
+            bool finished = http::parser_response{}.parse(reply, bad_reply, ec);
             REQUIRE(!bool(ec));
             REQUIRE(!finished); // Wrong content length. Waiting for rest of payload
             REQUIRE(bad_reply.empty());
@@ -372,7 +372,7 @@ TEST_SUITE("[MESSAGE]")
 
             http::response reply;
             std::error_code ec{};
-            bool finished = http::parser<http::response>{}.parse(reply, good_reply, ec);
+            bool finished = http::parser_response{}.parse(reply, good_reply, ec);
             REQUIRE(!bool(ec));
             REQUIRE(finished); // Good
             REQUIRE(good_reply.empty());
@@ -449,14 +449,14 @@ TEST_SUITE("[MESSAGE]")
 
         SUBCASE("parse entire message")
         {
-            const bool finished = http::parser<http::request>{}.parse(req1, buf, ec);
+            const bool finished = http::parser_request{}.parse(req1, buf, ec);
             REQUIRE(!bool(ec));
             REQUIRE(finished);
         }
 
         SUBCASE("parse block by block")
         {
-            http::parser<http::request> parser;
+            http::parser_request parser;
 
             size_t blocksize{};
 
@@ -522,14 +522,14 @@ TEST_SUITE("[MESSAGE]")
 
         SUBCASE("parse entire message")
         {
-            const bool finished = http::parser<http::response>{}.parse(resp1, buf, ec);
+            const bool finished = http::parser_response{}.parse(resp1, buf, ec);
             REQUIRE(!bool(ec));
             REQUIRE(finished);
         }
 
         SUBCASE("parse block by block")
         {
-            http::parser<http::response> parser;
+            http::parser_response parser;
 
             size_t blocksize{};