Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 68a5358

Browse files
author
Matthias Pfefferle
committed
some last small changes
1 parent 4cda2bc commit 68a5358

File tree

6 files changed

+89
-78
lines changed

6 files changed

+89
-78
lines changed

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,9 @@ The Webmention and Pingback logos are made by [Aaron Parecki](http://aaronpareck
6969
Project actively developed on Github at [pfefferle/wordpress-semantic-linkbacks](https://github.com/pfefferle/wordpress-semantic-linkbacks). Please file support issues there.
7070

7171
### 3.7.0 ###
72+
7273
* Add settings to enable each type independently in the Facepile
73-
* Render mentions as normal comments again not facepiles
74-
* Make sure avatars are always visible images
75-
* Add new get_facepile_avatar filter to ensure visible avatars
74+
* Optionally render mentions as normal comments again
7675
* Support Reacji...aka single-emoji reactions
7776
* Bump minimum PHP to 5.4 due emoji detector library dependency issues
7877
* Overlay emoji on individual avatars in reactions facepile
@@ -81,7 +80,7 @@ Project actively developed on Github at [pfefferle/wordpress-semantic-linkbacks]
8180
* Switch semantic_links_cite filter to filtering the format for the citation instead of the prepared citation
8281
* Count correct text length for unicode characters
8382
* Facepile Template improvements
84-
* Allow new comment template to be overridden by filter or theme declaring microformats2 support
83+
* Allow new comment template to be overridden by filter or theme declaring microformats2 support
8584
* Code standards compliance changes
8685
* Improved testing for PHP versions 5.4 and up to ensure compatibility
8786
* Remove direct calls to comment meta in favor of helper functions to ensure future proofing

composer.lock

Lines changed: 16 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

includes/class-linkbacks-handler.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public static function init() {
2525
// To extend or to override the default behavior, just use the `comment_text` filter with a lower
2626
// priority (so that it's called after this one) or remove the filters completely in
2727
// your code: `remove_filter('comment_text', array('Linkbacks_Handler', 'comment_text_add_cite'), 11);`
28-
if ( self::default_comment_render() ) {
28+
if ( ! self::render_comments() ) {
2929
add_filter( 'comment_text', array( 'Linkbacks_Handler', 'comment_text_add_cite' ), 11, 3 );
3030
}
3131
add_filter( 'comment_text', array( 'Linkbacks_Handler', 'comment_text_excerpt' ), 12, 3 );
@@ -58,9 +58,10 @@ public static function filter_comment_args( $args ) {
5858
* Filter whether to override comment presentation.
5959
* To use the default html5_comment set this filter to false
6060
*
61+
* @return boolean
6162
*/
62-
public static function default_comment_render() {
63-
return ! apply_filters( 'semantic_linkbacks_default_comment_render', ! current_theme_supports( 'microformats2' ) );
63+
public static function render_comments() {
64+
return apply_filters( 'semantic_linkbacks_render_comments', ! current_theme_supports( 'microformats2' ) );
6465
}
6566

6667
/**

includes/class-linkbacks-walker-comment.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public function end_el( &$output, $comment, $depth = 0, $args = array() ) {
7777

7878
protected function html5_comment( $comment, $depth, $args ) {
7979
// To use the default html5_comment set this filter to false
80-
if ( Linkbacks_Handler::default_comment_render() ) {
80+
if ( ! Linkbacks_Handler::render_comments() ) {
8181
parent::html5_comment( $comment, $depth, $args );
8282
return;
8383
}

0 commit comments

Comments
 (0)