Switch to looser restrictions if WP_DEBUG is enabled and stricter ones otherwise

dshanske · dshanske · commit c02b44f6990b · 2017-06-02T22:54:50.000-05:00
diff --git a/includes/class-linkbacks-mf2-handler.php b/includes/class-linkbacks-mf2-handler.php
@@ -288,7 +288,12 @@ public static function is_url( $string ) {
 		if ( ! is_string( $string ) ) {
 			return false;
 		}
-		return preg_match( '/^https?:\/\/.+\..+$/', $string );
+		// If debugging is on just validate that URL is validly formatted
+		if ( WP_DEBUG ) {
+			return filter_var( $string, FILTER_VALIDATE_URL ) !== false;
+		}
+		// If debugging is off limit based on WordPress parameters
+		return wp_http_validate_url( $string );
 	}
 
 	// Accepted h types

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,12 @@ public static function is_url( $string ) {`
`288`	`288`	`if ( ! is_string( $string ) ) {`
`289`	`289`	`return false;`
`290`	`290`	`}`
`291`		`- return preg_match( '/^https?:\/\/.+\..+$/', $string );`
	`291`	`+ // If debugging is on just validate that URL is validly formatted`
	`292`	`+ if ( WP_DEBUG ) {`
	`293`	`+ return filter_var( $string, FILTER_VALIDATE_URL ) !== false;`
	`294`	`+ }`
	`295`	`+ // If debugging is off limit based on WordPress parameters`
	`296`	`+ return wp_http_validate_url( $string );`
`292`	`297`	`}`
`293`	`298`
`294`	`299`	`// Accepted h types`