Remove dependence on pings_open for whether a webmention was open.

Author: dshanske

includes/functions.php

@@ -550,18 +550,22 @@ function ifset( &$var, $return = false ) { // phpcs:ignore Universal.NamingConve
  * @return boolean if webmentions are open
  */
 function webmentions_open( $post = null ) {
-	$_post   = get_post( $post );
-	$post_id = $_post ? $_post->ID : 0;
-
-	// If the post type does not support Webmentions do not even check further
-	if ( ! post_type_supports( get_post_type( $post_id ), 'webmentions' ) ) {
-		return false;
+	$post   = get_post( $post );
+	$post_id = $post ? $post->ID : 0;
+	if ( $post ) {
+		// Always consider the home mention link page to be open.
+		if ( get_option( 'webmention_home_mentions' ) === $post->ID ) {
+			$open = true;
+		} elseif ( ! post_type_supports( get_post_type( $post ), 'webmentions' ) ) {
+			// If the post type does not support Webmentions do not even check further.
+			$open = false;
+		} else {
+			// If the webmentions_closed meta ID has a value then consider webmentions to be open.
+			$open = get_post_meta( $post->ID, 'webmentions_closed', true );
+			$open = empty( $open ) ? true : false;
+		}
 	}
 
-	if ( get_option( 'webmention_home_mentions' ) === $post_id ) {
-		return true;
-	}
-	$open = ( $_post && ( pings_open( $post ) ) );
 	/**
 	 * Filters whether the current post is open for webmentions.
 	 *
@@ -572,23 +576,6 @@ function webmentions_open( $post = null ) {
 	return apply_filters( 'webmentions_open', $open, $post_id );
 }
 
-/**
- * Return enabled status of Homepage Webmentions.
- *
- * @since 3.8.9
- *
- * @param bool $open    Whether the current post is open for pings.
- * @param int  $post_id The post ID.
- * @return boolean if pings are open
- */
-function webmention_pings_open( $open, $post_id ) {
-	if ( get_option( 'webmention_home_mentions' ) === $post_id ) {
-		return true;
-	}
-
-	return $open;
-}
-
 /**
  * Retrieve the default comment status for a given post type.
  *
@@ -602,16 +589,7 @@ function webmention_pings_open( $open, $post_id ) {
  * @return string
  */
 function webmention_get_default_comment_status( $status, $post_type, $comment_type ) {
-	if ( 'webmention' === $comment_type ) {
-		return post_type_supports( $post_type, 'webmentions' ) ? 'open' : 'closed';
-	}
-
-	// Since support for the pingback comment type is used to keep pings open...
-	if ( ( 'pingback' === $comment_type ) ) {
-		return ( post_type_supports( $post_type, 'webmentions' ) ? 'open' : $status );
-	}
-
-	return $status;
+	return is_registered_webmention_comment_type( $comment_type ) ? 'open' : $status;
 }
 
 /**

webmention.php

@@ -128,7 +128,6 @@ function init() {
 
 	// Default Comment Status.
 	add_filter( 'get_default_comment_status', 'webmention_get_default_comment_status', 11, 3 );
-	add_filter( 'pings_open', 'webmention_pings_open', 10, 2 );
 
 	// Load language files.
 	load_plugin_textdomain( 'webmention', false, dirname( plugin_basename( __FILE__ ) ) . '/languages' );