refactor(hrq): Update truncate function to use uint.

ryotarai · ryotarai · commit 78a26334d272 · 2025-08-17T23:41:11.000+09:00
diff --git a/internal/hrq/utils/scopedhrq.go b/internal/hrq/utils/scopedhrq.go
@@ -74,7 +74,7 @@ func ScopedRQName(hrqNamespace string, hrqName string) (string, error) {
 
 	namespaceAndName := truncate(
 		fmt.Sprintf("%s-%s", hrqNamespace, hrqName),
-		validation.DNS1123SubdomainMaxLength-len(hashStr)-len(api.ResourceQuotaSingletonName)-2,
+		uint(validation.DNS1123SubdomainMaxLength-len(hashStr)-len(api.ResourceQuotaSingletonName)-2),
 	)
 
 	return fmt.Sprintf("%s-%s-%s", api.ResourceQuotaSingletonName, namespaceAndName, hashStr), nil
@@ -94,8 +94,8 @@ func SetLabelsAnnotationsForScopedRQ(rq *v1.ResourceQuota, hrqNamespace string,
 	metadata.SetLabel(rq, hrqNameLabel, hrqName)
 }
 
-func truncate(s string, n int) string {
-	if len(s) <= n {
+func truncate(s string, n uint) string {
+	if uint(len(s)) <= n {
 		return s
 	}
 	return s[:n]

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ func ScopedRQName(hrqNamespace string, hrqName string) (string, error) {`
`74`	`74`
`75`	`75`	`namespaceAndName := truncate(`
`76`	`76`	`fmt.Sprintf("%s-%s", hrqNamespace, hrqName),`
`77`		`- validation.DNS1123SubdomainMaxLength-len(hashStr)-len(api.ResourceQuotaSingletonName)-2,`
	`77`	`+ uint(validation.DNS1123SubdomainMaxLength-len(hashStr)-len(api.ResourceQuotaSingletonName)-2),`
`78`	`78`	`)`
`79`	`79`
`80`	`80`	`return fmt.Sprintf("%s-%s-%s", api.ResourceQuotaSingletonName, namespaceAndName, hashStr), nil`
`@@ -94,8 +94,8 @@ func SetLabelsAnnotationsForScopedRQ(rq *v1.ResourceQuota, hrqNamespace string,`
`94`	`94`	`metadata.SetLabel(rq, hrqNameLabel, hrqName)`
`95`	`95`	`}`
`96`	`96`
`97`		`-func truncate(s string, n int) string {`
`98`		`- if len(s) <= n {`
	`97`	`+func truncate(s string, n uint) string {`
	`98`	`+ if uint(len(s)) <= n {`
`99`	`99`	`return s`
`100`	`100`	`}`
`101`	`101`	`return s[:n]`