Merge pull request #80 from pfpack/release/v1.5.1-rc.2

release/v1.5.1-rc.2

Author: andreise

src/flatcollections-array/FlatArray.Tests/FlatArray.Tests.csproj

@@ -27,7 +27,7 @@
     </PackageReference>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
     <PackageReference Include="PrimeFuncPack.UnitTest.Data" Version="3.1.1" />
-    <PackageReference Include="xunit" Version="2.9.2" />
+    <PackageReference Include="xunit" Version="2.9.3" />
     <PackageReference Include="xunit.runner.visualstudio" Version="3.0.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

src/flatcollections-array/FlatArray/FlatArray.T.FlatList/FlatArray.FlatList.cs

@@ -13,6 +13,7 @@ private sealed partial class FlatList : IList<T>, IReadOnlyList<T>
 
         internal FlatList(int length, T[] items)
         {
+            Debug.Assert(items is not null);
             Debug.Assert(length >= 0 && length <= items.Length);
 
             this.length = length;

src/flatcollections-array/FlatArray/FlatArray.T.JsonConverter/FlatArray.JsonConverter.cs

@@ -1,5 +1,3 @@
-#pragma warning disable IDE0290 // Use primary constructor
-
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
@@ -11,7 +9,7 @@ internal sealed partial class JsonConverter : JsonConverter<FlatArray<T>>
     {
         private readonly JsonConverter<T> itemConverter;
 
-        public JsonConverter(JsonSerializerOptions options)
+        internal JsonConverter(JsonSerializerOptions options)
             =>
             itemConverter = (JsonConverter<T>)options.GetConverter(InnerItemType.Value);
 

src/flatcollections-array/FlatArray/FlatArray.T/InnerEmptyArray/FlatArray.InnerEmptyArray.cs

@@ -8,8 +8,13 @@ partial struct FlatArray<T>
     private static class InnerEmptyArray
     {
         // Intended for the inner use only, not to pass outside
-        // Designed not to expose the inner state of the empty FlatArray and the Builder
+        // Designed not to expose the inner state of the empty instances
 
-        internal static readonly T[] Value = new T[0];
+        internal static T[] Value => InnerInstance.Value;
+
+        private static class InnerInstance
+        {
+            internal static readonly T[] Value = new T[default];
+        }
     }
 }

src/flatcollections-array/FlatArray/FlatArray.csproj

@@ -19,7 +19,7 @@
     <Description>PrimeFuncPack Core.FlatArray is a core library for .NET consisting of immutable FlatArray targeted for use in functional programming.</Description>
     <RootNamespace>System</RootNamespace>
     <AssemblyName>PrimeFuncPack.Core.FlatArray</AssemblyName>
-    <Version>1.5.1-rc.1</Version>
+    <Version>1.5.1-rc.2</Version>
   </PropertyGroup>
 
   <ItemGroup>

src/flatcollections-array/FlatArray/FlatArrayJsonConverterFactory/Factory.CreateConverter.cs

@@ -10,7 +10,7 @@ partial class FlatArrayJsonConverterFactory
         =>
         (JsonConverter?)Activator.CreateInstance(
             type: typeof(FlatArray<>.JsonConverter).MakeGenericType(typeToConvert.GetGenericArguments()[0]),
-            bindingAttr: BindingFlags.Instance | BindingFlags.Public,
+            bindingAttr: BindingFlags.DeclaredOnly | BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.CreateInstance,
             binder: null,
             args: [options],
             culture: null);

src/flatcollections/FlatCollections/FlatCollections.csproj

@@ -19,7 +19,7 @@
     <Description>PrimeFuncPack Core.FlatCollections is a set of immutable Flat collections for .NET designed for developing business applications based on functional programming.</Description>
     <RootNamespace>System</RootNamespace>
     <AssemblyName>PrimeFuncPack.Core.FlatCollections</AssemblyName>
-    <Version>1.5.1-rc.1</Version>
+    <Version>1.5.1-rc.2</Version>
   </PropertyGroup>
 
   <ItemGroup>
@@ -34,7 +34,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="PrimeFuncPack.Core.FlatArray" Version="1.5.1-rc.1" />
+    <PackageReference Include="PrimeFuncPack.Core.FlatArray" Version="1.5.1-rc.2" />
   </ItemGroup>
 
 </Project>