Allow one letter upper case words

Author: klausi

coder_sniffer/Drupal/Sniffs/NamingConventions/ValidClassNameSniff.php

@@ -73,7 +73,7 @@ public function process(File $phpcsFile, $stackPtr)
         }
 
         // Ensure the name does not contain acronyms.
-        if (preg_match('|[A-Z]{2}|', $name) === 1) {
+        if (preg_match('|[A-Z]{3}|', $name) === 1) {
             $error = '%s name must use UpperCamel naming and not contain multiple upper case letters in a row';
             $phpcsFile->addError($error, $stackPtr, 'NoUpperAcronyms', $errorData);
         }

tests/Drupal/NamingConventions/ValidClassNameUnitTest.inc

@@ -1,24 +1,28 @@
 <?php
 
 class CorrectClassName {}
+class CorrectClassWithAReallyLongName {}
 class IncorrectJSONClassName {}
 class INCORRECT_CLASS_NAME {}
 class INCORRECTCLASSNAME {}
 class incorrectLowercaseClassName {}
 
 interface CorrectInterfaceName {}
+interface CorrectInterfaceWithAReallyLongName {}
 interface IncorrectJSONInterfaceName {}
 interface INCORRECT_INTERFACE_NAME {}
 interface INCORRECTINTERFACENAME {}
 interface incorrectLowercaseInterfaceName {}
 
 trait CorrectTraitName {}
+trait CorrectTraitWithAReallyLongName {}
 trait IncorrectJSONTraitName {}
 trait INCORRECT_TRAIT_NAME {}
 trait INCORRECTTRAITNAME {}
 trait incorrectLowercaseTraitName {}
 
 enum CorrectEnumName {}
+enum CorrectEnumWithAReallyLongName {}
 enum IncorrectJSONEnumName {}
 enum INCORRECT_ENUM_NAME {}
 enum INCORRECTENUMNAME {}

tests/Drupal/NamingConventions/ValidClassNameUnitTest.php

@@ -21,22 +21,22 @@ class ValidClassNameUnitTest extends CoderSniffUnitTest
     protected function getErrorList(string $testFile): array
     {
         return [
-            4  => 1,
-            5  => 2,
-            6  => 1,
+            5  => 1,
+            6  => 2,
             7  => 1,
-            10 => 1,
-            11 => 2,
+            8  => 1,
             12 => 1,
-            13 => 1,
-            16 => 1,
-            17 => 2,
-            18 => 1,
+            13 => 2,
+            14 => 1,
+            15 => 1,
             19 => 1,
+            20 => 2,
+            21 => 1,
             22 => 1,
-            23 => 2,
-            24 => 1,
-            25 => 1,
+            26 => 1,
+            27 => 2,
+            28 => 1,
+            29 => 1,
         ];
 
     }//end getErrorList()

tests/Drupal/NamingConventions/ValidEnumCaseUnitTest.inc

@@ -9,5 +9,5 @@ enum Test: int {
   case THREE = 3;
   // Upper case parts are not allowed.
   case FourJSONCase = 4;
-  case FiveCorrect = 5;
+  case FiveAndAHorseCorrect = 5;
 }