Fixes after review, add test case for "hook_"

Author: Nikolay Shapovalov

coder_sniffer/Drupal/Sniffs/Attributes/ValidHookNameSniff.php

@@ -57,16 +57,17 @@ public function process(File $phpcsFile, $stackPtr)
             && $tokens[$attributeName]['content'] === 'Hook'
         ) {
             $hookName = $phpcsFile->findNext(T_CONSTANT_ENCAPSED_STRING, ($attributeName + 2));
-            if ($hookName !== false
-            ) {
+            if ($hookName !== false) {
                 // Remove outer quotes.
                 $hookNameValue = trim($tokens[$hookName]['content'], '"\'');
 
-                if (strpos($hookNameValue, 'hook_') === 0) {
-                    $fix = $phpcsFile->addFixableWarning("Hook name should not start with 'hook_'. Hook name used: $hookNameValue", $hookName, 'HookPrefix');
-                    if ($fix === true && strlen($hookNameValue) > 5) {
-                        // Remove "hook_" prefix.
-                        $hookNameValueFixed = substr($hookNameValue, 5);
+                if (strpos($hookNameValue, 'hook_') === 0 && $hookNameValue !== 'hook_') {
+                    // Remove "hook_" prefix.
+                    $hookNameValueFixed = substr($hookNameValue, 5);
+                    $message            = sprintf("The hook name should not start with 'hook_', expected '%s' but found '%s", $hookNameValueFixed, $hookNameValue);
+
+                    $fix = $phpcsFile->addFixableWarning($message, $hookName, 'HookPrefix');
+                    if ($fix === true) {
                         // Return outer quotes.
                         $hookNameValueFixed = str_replace($hookNameValue, $hookNameValueFixed, $tokens[$hookName]['content']);
                         $phpcsFile->fixer->replaceToken($hookName, $hookNameValueFixed);

tests/Drupal/Attributes/ValidHookNameUnitTest.inc

@@ -29,6 +29,13 @@ function module_node_load() {
 
 }
 
+/**
+ * Not finished hook name. No warning
+ */
+#[Hook('hook_')]
+function module_system() {
+
+}
 
 /**
  * Attribute named argument.

tests/Drupal/Attributes/ValidHookNameUnitTest.inc.fixed

@@ -29,6 +29,14 @@ function module_node_load() {
 
 }
 
+/**
+ * Not finished hook name. No warning.
+ */
+#[Hook('hook_')]
+function module_system() {
+
+}
+
 /**
  * Attribute named argument.
  */

tests/Drupal/Attributes/ValidHookNameUnitTest.php

@@ -40,12 +40,12 @@ protected function getWarningList(string $testFile): array
         return [
             19  => 1,
             27  => 1,
-            36  => 1,
-            44  => 1,
-            52  => 1,
-            62  => 1,
-            85  => 1,
-            100 => 1,
+            43  => 1,
+            51  => 1,
+            59  => 1,
+            69  => 1,
+            92  => 1,
+            107 => 1,
         ];
 
     }//end getWarningList()