feat(TraitNameSuffix): Enable sniff (#3557537)

Author: klausi

.github/workflows/testing.yml

@@ -100,4 +100,4 @@ jobs:
           sed -i 's/Drupal.Methods.MethodDeclaration/PSR2.Methods.MethodDeclaration/g' phpcs.xml.dist
           sed -i '/<rule ref="Drupal.WhiteSpace.Namespace"\/>/d' phpcs.xml.dist
           sed -i 's/Drupal.Classes.InterfaceName/Generic.NamingConventions.InterfaceNameSuffix/g' phpcs.xml.dist
-          ../../vendor/bin/phpcs -p -s --parallel=$(nproc) --ignore=lib/Drupal/Core/Command/GenerateTheme.php,modules/mysql/tests/src/Kernel/mysql/Console/DbDumpCommandTest.php,modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php,tests/fixtures/plugins/CustomPlugin.php,modules/package_manager/tests/modules/package_manager_test_api/src/ApiController.php
+          ../../vendor/bin/phpcs -p -s --parallel=$(nproc) --ignore=lib/Drupal/Core/Command/GenerateTheme.php,modules/mysql/tests/src/Kernel/mysql/Console/DbDumpCommandTest.php,modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php,tests/fixtures/plugins/CustomPlugin.php,modules/package_manager/tests/modules/package_manager_test_api/src/ApiController.php,modules/views/tests/src/Kernel/Plugin/StyleGridTest.php

coder_sniffer/Drupal/ruleset.xml

@@ -52,6 +52,7 @@
   </rule>
   <rule ref="Generic.NamingConventions.ConstructorName"/>
   <rule ref="Generic.NamingConventions.InterfaceNameSuffix"/>
+  <rule ref="Generic.NamingConventions.TraitNameSuffix"/>
   <rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
   <rule ref="Generic.PHP.DeprecatedFunctions"/>
   <rule ref="Generic.PHP.DisallowShortOpenTag">

tests/Drupal/bad/BadUnitTest.php

@@ -388,6 +388,10 @@ protected function getErrorList(string $testFile): array
                 1 => 1,
                 3 => 1,
             ];
+        case 'TraitNameSuffix.inc':
+            return [
+                6 => 1,
+            ];
         case 'UnusedUseStatementUnitTest.inc':
             return [
                 5  => 1,

tests/Drupal/bad/TraitNameSuffix.inc

@@ -0,0 +1,8 @@
+<?php
+
+/**
+ * Trait name must end with 'Trait'.
+ */
+trait TraitNameSuffix {
+
+}