Skip to content

Commit 970f9a3

Browse files
author
Nikolay Shapovalov
committed
update tests
1 parent 0f46b15 commit 970f9a3

File tree

3 files changed

+68
-40
lines changed

3 files changed

+68
-40
lines changed

tests/Drupal/Attributes/ValidHookNameUnitTest.inc

Lines changed: 31 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,14 @@
66
*/
77

88
/**
9-
* Implements hook_node_view().
10-
*
9+
* Valid hook.
10+
*/
11+
#[Hook('valid')]
12+
function module_valid() {
13+
14+
}
15+
16+
/**
1117
* Single quotes.
1218
*/
1319
#[Hook('hook_node_view')]
@@ -16,8 +22,6 @@ function module_node_view() {
1622
}
1723

1824
/**
19-
* Implements hook_node_load().
20-
*
2125
* Double quotes.
2226
*/
2327
#[Hook("hook_node_load")]
@@ -27,27 +31,25 @@ function module_node_load() {
2731

2832

2933
/**
30-
* Implements hook_node_delete().
34+
* Attribute named argument.
3135
*/
3236
#[Hook(hook: 'hook_node_delete')]
3337
function module_node_delete() {
3438

3539
}
3640

3741
/**
38-
* Implements hook_node_alter().
42+
* Attribute named arguments.
3943
*/
4044
#[Hook(hook: 'hook_node_alter', module: 'custom_module')]
4145
function module_node_alter() {
4246

4347
}
4448

4549
/**
46-
* Implements hook_piratehook_view().
47-
*
48-
* "hook" is a part of hook name. No warning.
50+
* "hook" is a part of hook name.
4951
*/
50-
#[Hook('piratehook_view')]
52+
#[Hook('hook_piratehook_view')]
5153
function module_piratehook_view() {
5254

5355
}
@@ -57,14 +59,12 @@ function module_piratehook_view() {
5759
*
5860
* "hook" is a part of hook name. No warning.
5961
*/
60-
#[Hook('hookpirate_view')]
62+
#[Hook('hook_hookpirate_view')]
6163
function module_hookpirate_view() {
6264

6365
}
6466

6567
/**
66-
* Implements hook_hook_info().
67-
*
6868
* "hook_info" is exception. No warning.
6969
*/
7070
#[Hook('hook_info')]
@@ -73,12 +73,25 @@ function module_hook_info() {
7373
}
7474

7575
/**
76-
* Implements hook_hook_info().
77-
*
78-
* "hook_info" is exception. No warning.
76+
* Named argument. "hook_info" is exception. No warning.
7977
*/
8078
#[Hook(hook: 'hook_info')]
81-
function module_custom_hook_info() {
79+
function mymodule_hook_info() {
80+
81+
}
82+
83+
/**
84+
* Valid hook.
85+
*/
86+
#[Hook('valid', 'validMethod', 'module')]
87+
class ValidHooks {
88+
89+
/**
90+
*
91+
*/
92+
public function validMethod() {
93+
94+
}
8295

8396
}
8497

@@ -98,7 +111,7 @@ class Hooks {
98111
}
99112

100113
/**
101-
*
114+
* Named arguments, double quotes.
102115
*/
103116
#[Hook(hook: "hook_user_login", method: "userLogin", module: "views")]
104117
class MyHooks {

tests/Drupal/Attributes/ValidHookNameUnitTest.inc.fixed

Lines changed: 29 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,14 @@
66
*/
77

88
/**
9-
* Implements hook_node_view().
10-
*
9+
* Valid hook.
10+
*/
11+
#[Hook('valid')]
12+
function module_valid() {
13+
14+
}
15+
16+
/**
1117
* Single quotes.
1218
*/
1319
#[Hook('node_view')]
@@ -16,8 +22,6 @@ function module_node_view() {
1622
}
1723

1824
/**
19-
* Implements hook_node_load().
20-
*
2125
* Double quotes.
2226
*/
2327
#[Hook("node_load")]
@@ -26,25 +30,23 @@ function module_node_load() {
2630
}
2731

2832
/**
29-
* Implements hook_node_delete().
33+
* Attribute named argument.
3034
*/
3135
#[Hook(hook: 'node_delete')]
3236
function module_node_delete() {
3337

3438
}
3539

3640
/**
37-
* Implements hook_node_alter().
41+
* Attribute named arguments.
3842
*/
3943
#[Hook(hook: 'node_alter', module: 'custom_module')]
4044
function module_node_alter() {
4145

4246
}
4347

4448
/**
45-
* Implements hook_piratehook_view().
46-
*
47-
* "hook" is a part of hook name. No warning.
49+
* "hook" is a part of hook name.
4850
*/
4951
#[Hook('piratehook_view')]
5052
function module_piratehook_view() {
@@ -62,8 +64,6 @@ function module_hookpirate_view() {
6264
}
6365

6466
/**
65-
* Implements hook_hook_info().
66-
*
6767
* "hook_info" is exception. No warning.
6868
*/
6969
#[Hook('hook_info')]
@@ -72,12 +72,25 @@ function module_hook_info() {
7272
}
7373

7474
/**
75-
* Implements hook_hook_info().
76-
*
77-
* "hook_info" is exception. No warning.
75+
* Named argument. "hook_info" is exception. No warning.
7876
*/
7977
#[Hook(hook: 'hook_info')]
80-
function module_custom_hook_info() {
78+
function mymodule_hook_info() {
79+
80+
}
81+
82+
/**
83+
* Valid hook.
84+
*/
85+
#[Hook('valid', 'validMethod', 'module')]
86+
class ValidHooks {
87+
88+
/**
89+
*
90+
*/
91+
public function validMethod() {
92+
93+
}
8194

8295
}
8396

@@ -97,7 +110,7 @@ class Hooks {
97110
}
98111

99112
/**
100-
*
113+
* Named arguments, double quotes.
101114
*/
102115
#[Hook(hook: "user_login", method: "userLogin", module: "views")]
103116
class MyHooks {

tests/Drupal/Attributes/ValidHookNameUnitTest.php

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,14 @@ protected function getErrorList(string $testFile): array
3838
protected function getWarningList(string $testFile): array
3939
{
4040
return [
41-
13 => 1,
42-
23 => 1,
43-
32 => 1,
44-
40 => 1,
45-
88 => 1,
46-
103 => 1,
41+
19 => 1,
42+
27 => 1,
43+
36 => 1,
44+
44 => 1,
45+
52 => 1,
46+
62 => 1,
47+
101 => 1,
48+
116 => 1,
4749
];
4850

4951
}//end getWarningList()

0 commit comments

Comments
 (0)