fix

Author: Nikolay Shapovalov

coder_sniffer/Drupal/Sniffs/Classes/TestSniff.php

@@ -13,7 +13,7 @@
 use PHP_CodeSniffer\Sniffs\Sniff;
 
 /**
- * Checks that class references do not use FQN but use statements.
+ * Checks that Hook attribute argument name not starts with "hook_" prefix.
  *
  * @category PHP
  * @package  PHP_CodeSniffer
@@ -52,14 +52,19 @@ public function register()
     public function process(File $phpcsFile, $stackPtr)
     {
         $tokens = $phpcsFile->getTokens();
-        $end = $phpcsFile->findNext([T_ATTRIBUTE_END], ($stackPtr + 2));
-        $shortContent = '';
-        if ()
-        for ($i = ($stackPtr + 1); $i < $end; $i++) {
-          $shortContent .= $tokens[$i]['content'];
-        }
-        if (preg_match('/^hook\(.hook_/i', $shortContent, $matches) === 1) {
-          var_dump($matches);
+//        $shortContent = '';
+//        $end = $phpcsFile->findNext([T_ATTRIBUTE_END], ($stackPtr + 1));
+//        for ($i = ($stackPtr + 1); $i < $end; $i++) {
+//            $shortContent .= $tokens[$i]['content'];
+//        }
+//        $a = 1;
+
+        if ($tokens[$stackPtr + 1]['type'] === 'T_STRING'
+            && $tokens[$stackPtr + 1]['content'] === 'Hook'
+            && $tokens[$stackPtr + 3]['type'] === 'T_CONSTANT_ENCAPSED_STRING'
+            && str_contains($tokens[$stackPtr + 3]['content'], 'hook_')
+        ) {
+            $phpcsFile->addWarning('Hook name should not start with "hook_" prefix. Hook name used:' . $tokens[$stackPtr + 3]['content'], $stackPtr + 3,'HookAttributePrefixName');
         }
 
     }//end process()

tests/Drupal/bad/BadUnitTest.php

@@ -435,6 +435,7 @@ protected function getWarningList(string $testFile): array
                 823 => 1,
                 824 => 1,
                 836 => 1,
+                874 => 1,
             ];
         }//end switch
 

tests/Drupal/bad/bad.php

@@ -868,4 +868,12 @@ function test30(TestType $a = NULL) {
   echo "Hello";
 }
 
+/**
+ * Implements hook_node_view().
+ */
+#[Hook('hook_node_view')]
+function bad_node_view() {
+
+}
+
 ?>

tests/Drupal/bad/bad.php.fixed

@@ -921,3 +921,11 @@ function test29(
 function test30(?TestType $a = NULL) {
   echo "Hello";
 }
+
+/**
+ * Implements hook_node_view().
+ */
+#[Hook('node_view')]
+function bad_node_view() {
+
+}