fix(phpcs): Remove support for CSS and JS files, remove deprecated MySource.Debug.DebugCode sniff, rename deprecated Squiz.WhiteSpace.LanguageConstructSpacing sniff

Author: klausi

coder_sniffer/Drupal/Sniffs/CSS/ClassDefinitionNameSpacingSniff.php

@@ -54,11 +54,6 @@ public function process(File $phpcsFile, $stackPtr)
 
         // We are only interested in function/class/interface doc block comments.
         $ignore = Tokens::$emptyTokens;
-        if ($phpcsFile->tokenizerType === 'JS') {
-            $ignore[] = T_EQUAL;
-            $ignore[] = T_STRING;
-            $ignore[] = T_OBJECT_OPERATOR;
-        }
 
         $nextToken = $phpcsFile->findNext($ignore, ($stackPtr + 1), null, true);
         $ignore    = [

coder_sniffer/Drupal/Sniffs/CSS/ColourDefinitionSniff.php

@@ -83,8 +83,7 @@ public function process(File $phpcsFile, $stackPtr)
         }
 
         // The first line of the comment should just be the /** code.
-        // In JSDoc there are cases with @lends that are on the same line as code.
-        if ($tokens[$short]['line'] === $tokens[$stackPtr]['line'] && $phpcsFile->tokenizerType !== 'JS') {
+        if ($tokens[$short]['line'] === $tokens[$stackPtr]['line']) {
             $error = 'The open comment tag must be the only content on the line';
             $fix   = $phpcsFile->addFixableError($error, $stackPtr, 'ContentAfterOpen');
             if ($fix === true) {
@@ -137,12 +136,6 @@ public function process(File $phpcsFile, $stackPtr)
 
         // Check for a comment description.
         if ($tokens[$short]['code'] !== T_DOC_COMMENT_STRING) {
-            // JSDoc has many cases of @type declaration that don't have a
-            // description.
-            if ($phpcsFile->tokenizerType === 'JS') {
-                return;
-            }
-
             // PHPUnit test methods are allowed to skip the short description and
             // only provide an @covers annotation.
             if ($tokens[$short]['content'] === '@covers') {
@@ -527,9 +520,6 @@ public function process(File $phpcsFile, $stackPtr)
         // of @code, @todo and link tags.
         if ($paramGroupid !== null && $paramGroupid !== 0
             && in_array($tokens[$tokens[$commentStart]['comment_tags'][0]]['content'], ['@code', '@todo', '@link', '@endlink', '@codingStandardsIgnoreStart']) === false
-            // In JSDoc we can have many other valid tags like @function or
-            // tags like @constructor before the param tags.
-            && $phpcsFile->tokenizerType !== 'JS'
         ) {
             $error = 'Parameter tags must be defined first in a doc comment';
             $phpcsFile->addError($error, $tagGroups[$paramGroupid][0], 'ParamNotFirst');

coder_sniffer/Drupal/Sniffs/Commenting/DocCommentAlignmentSniff.php

@@ -99,23 +99,6 @@ public function process(File $phpcsFile, $stackPtr)
                 return;
             }
 
-            if ($phpcsFile->tokenizerType === 'JS') {
-                // We allow block comments if a function or object
-                // is being assigned to a variable.
-                $ignore    = Tokens::$emptyTokens;
-                $ignore[]  = T_EQUAL;
-                $ignore[]  = T_STRING;
-                $ignore[]  = T_OBJECT_OPERATOR;
-                $nextToken = $phpcsFile->findNext($ignore, ($nextToken + 1), null, true);
-                if ($tokens[$nextToken]['code'] === T_FUNCTION
-                    || $tokens[$nextToken]['code'] === T_CLOSURE
-                    || $tokens[$nextToken]['code'] === T_OBJECT
-                    || $tokens[$nextToken]['code'] === T_PROTOTYPE
-                ) {
-                    return;
-                }
-            }
-
             $prevToken = $phpcsFile->findPrevious(
                 Tokens::$emptyTokens,
                 ($stackPtr - 1),
@@ -127,8 +110,7 @@ public function process(File $phpcsFile, $stackPtr)
                 return;
             }
 
-            // Inline doc blocks are allowed in JSDoc.
-            if ($tokens[$stackPtr]['content'] === '/**' && $phpcsFile->tokenizerType !== 'JS') {
+            if ($tokens[$stackPtr]['content'] === '/**') {
                 // The only exception to inline doc blocks is the /** @var */
                 // declaration. Allow that in any form.
                 $varTag = $phpcsFile->findNext([T_DOC_COMMENT_TAG], ($stackPtr + 1), $tokens[$stackPtr]['comment_closer'], false, '@var');
@@ -155,16 +137,6 @@ public function process(File $phpcsFile, $stackPtr)
             if ($tokens[$previousContent]['code'] === T_CLOSE_CURLY_BRACKET) {
                 return;
             }
-
-            // Special case for JS files.
-            if ($tokens[$previousContent]['code'] === T_COMMA
-                || $tokens[$previousContent]['code'] === T_SEMICOLON
-            ) {
-                $lastContent = $phpcsFile->findPrevious(T_WHITESPACE, ($previousContent - 1), null, true);
-                if ($tokens[$lastContent]['code'] === T_CLOSE_CURLY_BRACKET) {
-                    return;
-                }
-            }
         }
 
         // Only want inline comments.

coder_sniffer/Drupal/Sniffs/Commenting/DocCommentSniff.php

@@ -65,16 +65,6 @@ public function process(File $phpcsFile, $stackPtr)
             return;
         }
 
-        // Special case for JS files.
-        if ($tokens[$lastContent]['code'] === T_COMMA
-            || $tokens[$lastContent]['code'] === T_SEMICOLON
-        ) {
-            $lastContent = $phpcsFile->findPrevious(T_WHITESPACE, ($lastContent - 1), null, true);
-            if ($tokens[$lastContent]['code'] === T_CLOSE_CURLY_BRACKET) {
-                return;
-            }
-        }
-
         $error = 'Comments may not appear after statements';
         $fix   = $phpcsFile->addFixableError($error, $stackPtr, 'Found');
         if ($fix === true) {

coder_sniffer/Drupal/Sniffs/Commenting/InlineCommentSniff.php

@@ -209,38 +209,6 @@ public function process(File $phpcsFile, $stackPtr)
             if (isset($tokens[$stackPtr]['scope_closer']) === true) {
                 $closer = $tokens[$stackPtr]['scope_closer'];
             }
-
-            // Do-while loops should have curly braces. This is optional in
-            // Javascript.
-            if ($closer === false && $tokens[$stackPtr]['code'] === T_DO && $phpcsFile->tokenizerType === 'JS') {
-                $error  = 'The code block in a do-while loop should be surrounded by curly braces';
-                $fix    = $phpcsFile->addFixableError($error, $stackPtr, 'DoWhileCurlyBraces');
-                $closer = $phpcsFile->findNext(T_WHILE, $stackPtr);
-                if ($fix === true) {
-                    $phpcsFile->fixer->beginChangeset();
-                    // Append an opening curly brace followed by a newline after
-                    // the DO.
-                    $next = $phpcsFile->findNext(T_WHITESPACE, ($stackPtr + 1), null, true);
-                    if ($next !== ($stackPtr + 1)) {
-                        $phpcsFile->fixer->replaceToken(($stackPtr + 1), '');
-                    }
-
-                    $phpcsFile->fixer->addContent($stackPtr, ' {'.$phpcsFile->eolChar);
-
-                    // Prepend a closing curly brace before the WHILE and ensure
-                    // it is on a new line.
-                    $prepend = $phpcsFile->eolChar;
-                    if ($tokens[($closer - 1)]['code'] === T_WHITESPACE) {
-                        $prepend = '';
-                        if ($tokens[($closer - 1)]['content'] !== $phpcsFile->eolChar) {
-                            $phpcsFile->fixer->replaceToken(($closer - 1), $phpcsFile->eolChar);
-                        }
-                    }
-
-                    $phpcsFile->fixer->addContentBefore($closer, $prepend.'} ');
-                    $phpcsFile->fixer->endChangeset();
-                }//end if
-            }//end if
         } else if ($tokens[$stackPtr]['code'] === T_ELSE
             || $tokens[$stackPtr]['code'] === T_ELSEIF
             || $tokens[$stackPtr]['code'] === T_CATCH