Skip to content

Commit e802331

Browse files
authored
refactor(InterfaceName): Replace Drupal.Classes.InterfaceName with Generic.NamingConventions.InterfaceNameSuffix (#3556859)
1 parent 0b3f216 commit e802331

File tree

4 files changed

+3
-62
lines changed

4 files changed

+3
-62
lines changed

.github/workflows/testing.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,4 +99,5 @@ jobs:
9999
find .. -type f -name "*.php" -exec sed -i 's#// phpcs:ignore DrupalPractice.CodeAnalysis.VariableAnalysis#// phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis#g' {} +
100100
sed -i 's/Drupal.Methods.MethodDeclaration/PSR2.Methods.MethodDeclaration/g' phpcs.xml.dist
101101
sed -i '/<rule ref="Drupal.WhiteSpace.Namespace"\/>/d' phpcs.xml.dist
102+
sed -i 's/Drupal.Classes.InterfaceName/Generic.NamingConventions.InterfaceNameSuffix/g' phpcs.xml.dist
102103
../../vendor/bin/phpcs -p -s --parallel=$(nproc) --ignore=lib/Drupal/Core/Command/GenerateTheme.php,modules/mysql/tests/src/Kernel/mysql/Console/DbDumpCommandTest.php,modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php,tests/fixtures/plugins/CustomPlugin.php,modules/package_manager/tests/modules/package_manager_test_api/src/ApiController.php

coder_sniffer/Drupal/Sniffs/Classes/InterfaceNameSniff.php

Lines changed: 0 additions & 60 deletions
This file was deleted.

coder_sniffer/Drupal/ruleset.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
<severity>0</severity>
5252
</rule>
5353
<rule ref="Generic.NamingConventions.ConstructorName"/>
54+
<rule ref="Generic.NamingConventions.InterfaceNameSuffix"/>
5455
<rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
5556
<rule ref="Generic.PHP.DeprecatedFunctions"/>
5657
<rule ref="Generic.PHP.DisallowShortOpenTag">

tests/Drupal/bad/BadUnitTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ protected function getErrorList(string $testFile): array
353353
805 => 1,
354354
806 => 1,
355355
807 => 1,
356-
809 => 4,
356+
809 => 5,
357357
815 => 1,
358358
820 => 1,
359359
827 => 1,
@@ -464,7 +464,6 @@ protected function getWarningList(string $testFile): array
464464
495 => 1,
465465
787 => 1,
466466
788 => 1,
467-
809 => 1,
468467
823 => 1,
469468
824 => 1,
470469
836 => 1,

0 commit comments

Comments
 (0)