[interface] _remove_all_separators() works when no separator exists (#171)

DanielRaapDev · web-flow · commit 20dba4a10b06 · 2025-03-14T21:40:46.000-06:00
* remove_separators() works when no separators exist
diff --git a/changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml b/changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - "pfsense_interface - fixes removal of an interface with `state: absent`. _remove_all_separators() works when no separator exists for that interface. (https://github.com/pfsensible/core/issues/170)"
diff --git a/plugins/module_utils/interface.py b/plugins/module_utils/interface.py
@@ -383,7 +383,7 @@ def _remove_all_rules(self, interface):
     def _remove_all_separators(self, interface):
         """ delete all interface separators """
         todel = []
-        separators = self.pfsense.rules.find('separator')
+        separators = self.pfsense.rules.find('separator') or []
         for interface_elt in separators:
             if interface_elt.tag != interface:
                 continue

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+bugfixes:`
	`2`	+ - "pfsense_interface - fixes removal of an interface with `state: absent`. _remove_all_separators() works when no separator exists for that interface. (https://github.com/pfsensible/core/issues/170)"