Cumulative changes after review

Author: danolivo

.github/workflows/zodan_sync.yml

@@ -42,14 +42,7 @@ jobs:
 
       - name: Build docker container
         run: |
-          cd ${GITHUB_WORKSPACE}/
-          ls -la
-          ls -la sql
-          ls -la tests/
-          ls -la tests/tap
-          ls -la tests/tap/t
-          cat tests/tap/t/011_zodan_sync_third.pl
-          docker build \
+            docker build \
             --build-arg PGVER=${{ matrix.pgver }} \
             -t spock -f tests/docker/Dockerfile-step-1.el9 .
 

tests/docker/Dockerfile-step-1.el9

@@ -47,18 +47,8 @@ RUN . /home/pgedge/.bashrc && export PG_CONFIG=/home/pgedge/pgedge/pg$PGVER/bin/
 RUN echo "==========Built Spock=========="
 
 #-----------------------------------------
-COPY \
-	tests/docker/entrypoint.sh \
-	tests/docker/run-tests.sh \
-	tests/docker/run-spock-regress.sh \
-	tests/docker/run-spock-tap.sh \
-	/home/pgedge
-
-RUN sudo chmod +x \
-	/home/pgedge/entrypoint.sh \
-	/home/pgedge/run-tests.sh \
-	/home/pgedge/run-spock-regress.sh \
-	/home/pgedge/run-spock-tap.sh
+COPY tests/docker/*.sh /home/pgedge/
+RUN sudo chmod +x /home/pgedge/*.sh
 
 WORKDIR /home/pgedge/
 USER pgedge

tests/docker/run-spock-tap.sh

@@ -7,7 +7,6 @@
 export PG_CONFIG=/home/pgedge/pgedge/pg${PGVER}/bin/pg_config
 export PATH=/home/pgedge/pgedge/pg${PGVER}/bin:$PATH
 export LD_LIBRARY_PATH=/home/pgedge/pgedge/pg${PGVER}/lib/:$LD_LIBRARY_PATH
-export PROVE_TESTS=$proven_tests
 
 # PGVER should be previously set in the environment
 if [ -z "${PGVER}" ]