Added cppcoreguidelines-init-variables check to .clang-tidy (#3009)

Mohit242-bit · web-flow · commit 200101d315dd · 2026-01-03T09:55:36.000-06:00
* clang-tidy: Added cppcoreguidelines-init-variables
* Fix warnings from cppcoreguideline-init-variables
diff --git a/.clang-tidy b/.clang-tidy
@@ -6,7 +6,8 @@ Checks: >
     cppcoreguidelines-avoid-capturing-lambda-coroutines,
     cppcoreguidelines-avoid-goto,
     cppcoreguidelines-avoid-non-const-global-variables,
-    cppcoreguidelines-avoid-reference-coroutine-parameters
+    cppcoreguidelines-avoid-reference-coroutine-parameters,
+    cppcoreguidelines-init-variables
 
 WarningsAsErrors: ''
 HeaderFilterRegex: './include'
diff --git a/include/bdAstar/bdAstar.hpp b/include/bdAstar/bdAstar.hpp
@@ -156,7 +156,7 @@ class Pgr_bdAstar : public Pgr_bidirectional<G> {
 
         double dx = graph[v].x() - graph[u].x();
         double dy = graph[v].y() - graph[u].y();
-        double current;
+        double current = 0;
 
         switch (m_heuristic) {
             case 0:
diff --git a/include/contraction/contractionGraph.hpp b/include/contraction/contractionGraph.hpp
@@ -182,7 +182,7 @@ class Pgr_contractionGraph : public Pgr_base_graph<G, CH_vertex, CH_edge, t_dire
        */
 
       bool add_shortcut(const CH_edge &edge, V u, V v) {
-         bool inserted;
+         bool inserted = false;
          E e;
          if (edge.cost < 0) return false;
 
@@ -395,7 +395,7 @@ class Pgr_contractionGraph : public Pgr_base_graph<G, CH_vertex, CH_edge, t_dire
         V u, V v, V w,
         std::vector<E> &shortcuts,
         std::ostringstream &log) {
-        bool found_e;
+        bool found_e = false;
         E e;
 
         boost::tie(e, found_e) = boost::edge(u, w, this->graph);
@@ -423,7 +423,7 @@ class Pgr_contractionGraph : public Pgr_base_graph<G, CH_vertex, CH_edge, t_dire
             shortcut.add_contracted_edge_vertices(std::get<0>(e2));
 
             // Add shortcut in the current graph (to go on the process)
-            bool inserted;
+            bool inserted = false;
             E s;
             boost::tie(s, inserted) = boost::add_edge(u, w, this->graph);
             this->graph[s]= shortcut;
@@ -434,16 +434,15 @@ class Pgr_contractionGraph : public Pgr_base_graph<G, CH_vertex, CH_edge, t_dire
     /*! @brief computes p_max used in the contraction hierarchies method
     */
     int64_t compute_pmax(V u, V v, Identifiers<V> out_vertices) {
-        int64_t p_max;
+        int64_t p_max = 0;
         E e, f;
-        bool found_e;
-        p_max = 0;
+        bool found_e = false;
         boost::tie(e, found_e) = boost::edge(u, v, this->graph);
 
         if (found_e) {
             p_max = this->graph[e].cost;
             for (V w : out_vertices) {
-                bool found_f;
+                bool found_f = false;
                 boost::tie(f, found_f) = boost::edge(v, w, this->graph);
                 if ((found_f) && (u != w)) {
                     if ((this->graph[e].cost + this->graph[f].cost) > p_max) {
diff --git a/include/contraction/contractionHierarchies.hpp b/include/contraction/contractionHierarchies.hpp
@@ -129,7 +129,7 @@ void compute_shortcuts(
         for (const auto &w : out_vertices) {
             if ( u != w ) {
                 typename G::E e, f, g;
-                bool found_e, found_f, found_g;
+                bool found_e = false, found_f = false, found_g = false;
                 boost::tie(e, found_e) = boost::edge(u, v, graph.graph);
                 boost::tie(f, found_f) = boost::edge(v, w, graph.graph);
                 boost::tie(g, found_g) = boost::edge(u, w, graph.graph);
@@ -170,7 +170,7 @@ int64_t vertex_contraction(
 ) {
     Identifiers<typename G::V> adjacent_in_vertices;
     Identifiers<typename G::V> adjacent_out_vertices;
-    int64_t n_old_edges;
+    int64_t n_old_edges = 0;
     std::vector<typename G::E> shortcut_edges;
 
     if (directed) {
@@ -225,7 +225,7 @@ int64_t vertex_contraction(
         << " shortcuts created, " << n_old_edges
         << " old edges" << std::endl;
 
-    int64_t m;
+    int64_t m = 0;
     m = static_cast<int64_t>(shortcut_edges.size())
       - static_cast<int64_t>(n_old_edges);
     log << "  Metric: edge difference = " << shortcut_edges.size()
diff --git a/include/contraction/linearContraction.hpp b/include/contraction/linearContraction.hpp
@@ -107,10 +107,9 @@ class Pgr_linear {
          pgassert(v != w);
          pgassert(u != w);
 
-         E e, f;
-         bool found_e, found_f;
-
          if (graph.is_directed()) {
+             E e, f;
+             bool found_e = false, found_f = false;
              /*
               *  u --> v --> w
               */
diff --git a/include/cpp_common/base_graph.hpp b/include/cpp_common/base_graph.hpp
@@ -709,7 +709,7 @@ class Pgr_base_graph {
          auto u = get_V(edge.source);
          auto v = get_V(edge.target);
          if (edge.cost >= 0) {
-             bool inserted;
+             bool inserted = false;
              boost::tie(e, inserted) = boost::add_edge(u, v, graph);
              graph[e].cp_members(edge);
          }
@@ -730,7 +730,7 @@ class Pgr_base_graph {
      /**@}*/
 
      template <typename T> void graph_add_edge(const T &edge, bool normal) {
-         bool inserted;
+         bool inserted = false;
          E e;
          if ((edge.cost < 0) && (edge.reverse_cost < 0)) return;
 
@@ -761,7 +761,7 @@ class Pgr_base_graph {
      }
 
      template <typename T> void graph_add_min_edge_no_parallel(const T &edge) {
-         bool inserted;
+         bool inserted = false;
          E e;
          if ((edge.cost < 0) && (edge.reverse_cost < 0)) return;
 
@@ -776,7 +776,7 @@ class Pgr_base_graph {
          pgassert(vertices_map.find(edge.target) != vertices_map.end());
          if (edge.cost >= 0) {
              E e1;
-             bool found;
+             bool found = false;
              boost::tie(e1, found) = boost::edge(vm_s, vm_t, graph);
              if (found) {
                  if (edge.cost < graph[e1].cost) {
@@ -793,7 +793,7 @@ class Pgr_base_graph {
          if (edge.reverse_cost >= 0
                  && (m_is_directed || (!m_is_directed && edge.cost != edge.reverse_cost))) {
              E e1;
-             bool found;
+             bool found = false;
              boost::tie(e1, found) = boost::edge(vm_t, vm_s, graph);
              if (found) {
                  if (edge.reverse_cost < graph[e1].cost) {
@@ -816,7 +816,7 @@ class Pgr_base_graph {
        To Do: Read and apply edges with negative cost in function as it is
        */
      template <typename T> void graph_add_neg_edge(const T &edge, bool normal = true) {
-         bool inserted;
+         bool inserted = false;
          E e;
 
          auto vm_s = get_V(T_V(edge, true));
diff --git a/include/cpp_common/get_data.hpp b/include/cpp_common/get_data.hpp
@@ -61,8 +61,8 @@ void get_data(
         Func func) {
     const int tuple_limit = 1000000;
 
-    size_t total_tuples;
-    size_t valid_pgtuples;
+    size_t total_tuples = 0;
+    size_t valid_pgtuples = 0;
 
     auto SPIplan = pgr_SPI_prepare(sql);
     auto SPIportal = pgr_SPI_cursor_open(SPIplan);
@@ -120,8 +120,8 @@ std::vector<Data_type> get_data(
         Func func) {
     const int tuple_limit = 1000000;
 
-    size_t total_tuples;
-    size_t valid_pgtuples;
+    size_t total_tuples = 0;
+    size_t valid_pgtuples = 0;
 
     auto SPIplan = pgr_SPI_prepare(sql.c_str());
     auto SPIportal = pgr_SPI_cursor_open(SPIplan);
diff --git a/include/lineGraph/lineGraphFull.hpp b/include/lineGraph/lineGraphFull.hpp
@@ -194,7 +194,7 @@ class Pgr_lineGraphFull : public Pgr_base_graph<G, T_V, T_E, t_directed> {
                 const T &target,
                 int64_t source_in_edge,
                 int64_t source_out_edge) {
-            bool inserted;
+            bool inserted = false;
             E e;
 
             pgassert(m_vertex_map.find({source, source_in_edge}) !=
diff --git a/src/chinese/chinesePostman_driver.cpp b/src/chinese/chinesePostman_driver.cpp
@@ -79,7 +79,7 @@ pgr_do_directedChPP(
 
         pgrouting::graph::PgrDirectedChPPGraph digraph(edges);
 
-        double minCost;
+        double minCost = NAN;
         minCost = digraph.DirectedChPP();
 
         std::vector<Path_rt> pathEdges;
diff --git a/src/coloring/edgeColoring.cpp b/src/coloring/edgeColoring.cpp
@@ -84,7 +84,7 @@ Pgr_edgeColoring::Pgr_edgeColoring(const std::vector<Edge_t> &edges) {
     /*
      * Inserting edges
      */
-    bool added;
+    bool added = false;
     for (const auto &edge : edges) {
         auto v1 = get_boost_vertex(edge.source);
         auto v2 = get_boost_vertex(edge.target);
diff --git a/src/common/assert.cpp b/src/common/assert.cpp
@@ -42,7 +42,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 std::string get_backtrace() {
 #ifdef __GLIBC__
         void *trace[16];
-        int i, trace_size = 0;
+        int i = 0, trace_size = 0;
 
         trace_size = backtrace(trace, 16);
         char** funcNames = backtrace_symbols(trace, trace_size);
diff --git a/src/components/components.cpp b/src/components/components.cpp
@@ -49,7 +49,7 @@ pgr_connectedComponents(pgrouting::UndirectedGraph &graph) {
     typedef pgrouting::UndirectedGraph::V V;
     // perform the algorithm
     std::vector<V> components(num_vertices(graph.graph));
-    size_t num_comps;
+    size_t num_comps = 0;
     /* abort in case of an interruption occurs (e.g. the query is being cancelled) */
     CHECK_FOR_INTERRUPTS();
     try {
@@ -74,7 +74,7 @@ strongComponents(
     typedef pgrouting::UndirectedGraph::V V;
     // perform the algorithm
     std::vector<V> components(num_vertices(graph.graph));
-    size_t num_comps;
+    size_t num_comps = 0;
     /* abort in case of an interruption occurs (e.g. the query is being cancelled) */
     CHECK_FOR_INTERRUPTS();
     try {
@@ -108,7 +108,7 @@ biconnectedComponents(
     // perform the algorithm
     Edge_map bicmp_map;
     boost::associative_property_map<Edge_map> bimap(bicmp_map);
-    size_t num_comps;
+    size_t num_comps = 0;
     try {
         // NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDelete)
         num_comps = biconnected_components(graph.graph, bimap);
@@ -169,7 +169,7 @@ bridges(pgrouting::UndirectedGraph &graph) {
     Identifiers<int64_t> bridge_edges;
     Identifiers<int64_t> processed_edges;
     std::vector<V> components(num_vertices(graph.graph));
-    size_t ini_comps;
+    size_t ini_comps = 0;
     /* abort in case of an interruption occurs (e.g. the query is being cancelled) */
     CHECK_FOR_INTERRUPTS();
     try {
@@ -231,7 +231,7 @@ bridges(pgrouting::UndirectedGraph &graph) {
 
             if (parallel_count == 1) {
                 // TODO(vicky) filter graph instead of removing edges
-                size_t now_comps;
+                size_t now_comps = 0;
                 try {
                     boost::remove_edge(edge, graph.graph);
 
diff --git a/src/cpp_common/compPaths.cpp b/src/cpp_common/compPaths.cpp
@@ -55,7 +55,7 @@ bool compPathsLess::operator()(const Path &p1, const Path &p2) const {
     pgassert(p1.size() == p2.size());
 
     // paths weights & lengths are equal now check by node ID
-    unsigned int i;
+    unsigned int i = 0;
     for (i = 0; i < p1.size(); i++) {
         if (p1[i].node >  p2[i].node) return false;
         if (p1[i].node <  p2[i].node) return true;
diff --git a/src/cpp_common/get_check_data.cpp b/src/cpp_common/get_check_data.cpp
@@ -224,8 +224,8 @@ void fetch_column_info(
 char getChar(
         const HeapTuple tuple, const TupleDesc &tupdesc, const pgrouting::Column_info_t &info,
         bool strict, char default_value) {
-    Datum binval;
-    bool isNull;
+    Datum binval = 0;
+    bool isNull = false;
     char value = default_value;
 
     binval = SPI_getbinval(tuple, tupdesc, info.colNumber, &isNull);
@@ -274,9 +274,9 @@ get_pgset(ArrayType *v) {
     auto    nitems = ArrayGetNItems(ndim, dim);
     Datum  *elements = nullptr;
     bool   *nulls = nullptr;
-    int16   typlen;
-    bool    typbyval;
-    char    typalign;
+    int16   typlen = 0;
+    bool    typbyval = false;
+    char    typalign = 0;
 
 
     if (ndim == 0 || nitems <= 0) {
@@ -359,9 +359,9 @@ get_pgarray(ArrayType *v, bool allow_empty) {
     auto    nitems = ArrayGetNItems(ndim, dim);
     Datum  *elements = nullptr;
     bool   *nulls = nullptr;
-    int16   typlen;
-    bool    typbyval;
-    char    typalign;
+    int16   typlen = 0;
+    bool    typbyval = false;
+    char    typalign = 0;
 
 
     if (allow_empty && (ndim == 0 || nitems <= 0)) {
@@ -451,9 +451,9 @@ get_array(ArrayType *v, size_t *arrlen, bool allow_empty) {
     auto    nitems = ArrayGetNItems(ndim, dim);
     Datum  *elements = nullptr;
     bool   *nulls = nullptr;
-    int16   typlen;
-    bool    typbyval;
-    char    typalign;
+    int16   typlen = 0;
+    bool    typbyval = false;
+    char    typalign = 0;
 
 
     if (allow_empty && (ndim == 0 || nitems <= 0)) {
@@ -556,8 +556,8 @@ int64_t* getBigIntArr(
  */
 int64_t getBigInt(
         const HeapTuple tuple, const TupleDesc &tupdesc, const pgrouting::Column_info_t &info) {
-    Datum binval;
-    bool isnull;
+    Datum binval = 0;
+    bool isnull = false;
     int64_t value = 0;
     binval = SPI_getbinval(tuple, tupdesc, info.colNumber, &isnull);
     if (isnull) {
@@ -589,7 +589,7 @@ int64_t getBigInt(
  */
 double getFloat8(
         const HeapTuple tuple, const TupleDesc &tupdesc, const pgrouting::Column_info_t &info) {
-    Datum binval;
+    Datum binval = 0;
     bool isnull = false;
     binval = SPI_getbinval(tuple, tupdesc, info.colNumber, &isnull);
     if (isnull) {
diff --git a/src/cpp_common/undirectedNoCostBG.cpp b/src/cpp_common/undirectedNoCostBG.cpp
@@ -49,9 +49,9 @@ UndirectedNoCostsBG::UndirectedNoCostsBG(const std::vector<Edge_bool_t> &edges)
     for (const auto edge : edges) {
         V v1 = get_boost_vertex(edge.source);
         V v2 = get_boost_vertex(edge.target);
-        E e;
-        bool added;
         if (edge.going) {
+            E e;
+            bool added = false;
             boost::tie(e, added) = boost::add_edge(v1, v2, graph);
             if (added) E_to_id.insert(std::pair<E, int64_t>(e, edge.id));
         }
diff --git a/src/max_flow/max_flow_driver.cpp b/src/max_flow/max_flow_driver.cpp
@@ -114,7 +114,7 @@ pgr_do_max_flow(
                 edges, sources, targets, algorithm);
         // digraph.create_flow_graph(edges, sources, targets, algorithm);
 
-        int64_t max_flow;
+        int64_t max_flow = 0;
         if (algorithm == 1) {
             max_flow = digraph.push_relabel();
         } else if (algorithm == 3) {
diff --git a/src/max_flow/maxflow.cpp b/src/max_flow/maxflow.cpp
diff --git a/src/max_flow/maximumcardinalitymatching.cpp b/src/max_flow/maximumcardinalitymatching.cpp
diff --git a/src/max_flow/minCostMaxFlow.cpp b/src/max_flow/minCostMaxFlow.cpp
diff --git a/src/max_flow/minCostMaxFlow_driver.cpp b/src/max_flow/minCostMaxFlow_driver.cpp
diff --git a/src/trsp/trspHandler.cpp b/src/trsp/trspHandler.cpp
