(CI/update) fixing test Test old version before update

Author: cvvergara

.github/workflows/update.yml

@@ -94,16 +94,16 @@ jobs:
           cmake -DPOSTGRESQL_VERSION=${PGVER} -DCMAKE_BUILD_TYPE=Release -DWITH_DOC=OFF ..
           make -j 4
           sudo make install
-          sudo service postgresql start
-          createdb -p "${PGPORT}"  ___pgr___test___
-          psql -p "${PGPORT}"  -d ___pgr___test___ -c "CREATE EXTENSION pgrouting CASCADE;"
 
       - name: Test old version before update with current tests
         run: |
           sudo service postgresql start
+          createdb -p "${PGPORT}"  ___pgr___test___
+          psql -p "${PGPORT}"  -d ___pgr___test___ -c "CREATE EXTENSION pgrouting CASCADE;"
           psql -p "${PGPORT}"  -d ___pgr___test___ -c "SELECT * FROM pgr_full_version();"
           DIR=$(git rev-parse --show-toplevel)
           bash "${DIR}/tools/testers/setup_db.sh" "${PGPORT}" ___pgr___test___ "${PG_RUNNER_USER}" "${{ matrix.old_pgr }}"
+          psql -p "${PGPORT}"  -d ___pgr___test___ -c "SELECT * FROM pgr_full_version();"
           pg_prove  -Q -f --normalize --directives --recurse -U "${PG_RUNNER_USER}" -d ___pgr___test___ "pgtap"
 
       - name: Build current version
@@ -118,8 +118,11 @@ jobs:
       - name: Test old version with currrent tests after installing current
         run: |
           sudo service postgresql start
-          psql -p "${PGPORT}"  -d ___pgr___test___ -c "SELECT * FROM pgr_full_version();"
+          dropdb -p "${PGPORT}"  ___pgr___test___
+          createdb -p "${PGPORT}"  ___pgr___test___
           DIR=$(git rev-parse --show-toplevel)
+          bash "${DIR}/tools/testers/setup_db.sh" "${PGPORT}" ___pgr___test___ "${PG_RUNNER_USER}" "${{ matrix.old_pgr }}"
+          psql -p "${PGPORT}"  -d ___pgr___test___ -c "SELECT * FROM pgr_full_version();"
           pg_prove  -Q -f --normalize --directives --recurse -U "${PG_RUNNER_USER}" -d ___pgr___test___ "pgtap"
 
       - name: Test old version with current tests after update

src/legacy/legacy.c

@@ -1,26 +1,28 @@
-/**********************************************************************
- *
- * PostGIS - Spatial Types for PostgreSQL
- * http://postgis.net
- *
- * PostGIS is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 2 of the License, or
- * (at your option) any later version.
- *
- * PostGIS is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with PostGIS.  If not, see <http://www.gnu.org/licenses/>.
- *
- **********************************************************************
- *
- * Copyright (C) 2018-2020 Regina Obe <[email protected]>
- *
- **********************************************************************/
+/*PGR-GNU*****************************************************************
+File: legacy.c
+
+Copyright (c) 2017 pgRouting developers
+Mail: [email protected]
+
+Copyright (c) 2018-2020 Regina Obe <[email protected]>
+------
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program; if not, write to the Free Software
+Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+
+ ********************************************************************PGR-GNU*/
+
 /******************************************************************************
  * This file is to hold functions we no longer use,
  * but we need to keep because they were used at one time behind SQL API functions.
@@ -35,20 +37,19 @@
 #include "utils/builtins.h"
 
 #define PGROUTING_DEPRECATE(version, funcname) \
-	Datum funcname(PG_FUNCTION_ARGS); \
-	PG_FUNCTION_INFO_V1(funcname); \
-	Datum funcname([[maybe_unused]] PG_FUNCTION_ARGS) \
-	{ \
-		ereport(ERROR, (\
-			errcode(ERRCODE_FEATURE_NOT_SUPPORTED), \
-			errmsg("A stored procedure tried to use deprecated C internal function '%s'", \
-			       __func__), \
-			errdetail("Library function '%s' was deprecated in pgRouting %s", \
-			          __func__, version), \
-			errhint("Consider upgrade pgRouting") \
-		)); \
-		PG_RETURN_POINTER(NULL); \
-	}
+    Datum funcname(PG_FUNCTION_ARGS); \
+    PG_FUNCTION_INFO_V1(funcname); \
+    Datum funcname([[maybe_unused]] PG_FUNCTION_ARGS) \
+    { \
+        ereport(ERROR, (\
+            errcode(ERRCODE_FEATURE_NOT_SUPPORTED), \
+            errmsg("A stored procedure tried to use deprecated C internal function '%s'", \
+                   __func__), \
+            errdetail("Library function '%s' was deprecated in pgRouting %s", \
+                      __func__, version), \
+            errhint("Consider upgrade pgRouting"))); \
+        PG_RETURN_POINTER(NULL); \
+    }
 
 PGROUTING_DEPRECATE("4.0.0", _pgr_trsp)
 PGROUTING_DEPRECATE("4.0.0", _v4trsp)