Clang-tidy: add cppcoreguidelines-use-default-member-init

Author: Sohamsig

include/chinese/chinesePostman.hpp

@@ -70,8 +70,8 @@ class PgrDirectedChPPGraph {
      void setPathEdges(graph::PgrCostFlowGraph &flowGraph);
 
  private:
-     int64_t totalDeg;
-     double totalCost;
+     int64_t totalDeg{0};
+     double totalCost{0.0};
      int64_t superSource, superTarget;
      int64_t startPoint;
      double m_cost;
@@ -106,7 +106,7 @@ PgrDirectedChPPGraph::~PgrDirectedChPPGraph() {
     edgeToIdx.clear();
 }
 PgrDirectedChPPGraph::PgrDirectedChPPGraph(const std::vector<Edge_t> &dataEdges) :
-    totalDeg(0), totalCost(0), vertices(),
+    vertices(),
     edgeToIdx(), originalEdges(),
     resultGraph(), VToVecid(), edgeVisited(),
     pathStack(), resultPath(),

include/contraction/contractionGraph.hpp

@@ -66,8 +66,7 @@ class Pgr_contractionGraph : public Pgr_base_graph<G, CH_vertex, CH_edge, t_dire
        Prepares the _graph_ to be of type *directed*
        */
      explicit Pgr_contractionGraph()
-         : Pgr_base_graph<G, CH_vertex, CH_edge, t_directed>(),
-        min_edge_id(0) {
+         : Pgr_base_graph<G, CH_vertex, CH_edge, t_directed>() {
          }
 
      /*! @brief get the vertex descriptors of adjacent vertices of *v*
@@ -549,7 +548,7 @@ class Pgr_contractionGraph : public Pgr_base_graph<G, CH_vertex, CH_edge, t_dire
     }
 
  private:
-    int64_t min_edge_id;
+    int64_t min_edge_id = 0;
     Identifiers<V> forbiddenVertices;
 };
 

include/vrp/solution.hpp

@@ -46,7 +46,7 @@ class Solution {
     friend class Optimize;
     friend class PD_problem;
  protected:
-     double EPSILON;
+     double EPSILON = 0.0001;
      std::deque<Vehicle_pickDeliver> fleet;
 
      /* this solution belongs to this problem*/
@@ -66,7 +66,7 @@ class Solution {
 
      /* @brief copy constructor */
      Solution(const Solution &sol) :
-         EPSILON(0.0001),
+         
          fleet(sol.fleet),
          trucks(sol.trucks)
     {};

include/yen/ksp.hpp

@@ -58,11 +58,8 @@ class Pgr_ksp :  public Pgr_messages {
      typedef std::set<Path, compPathsLess> pSet;
 
  public:
-     Pgr_ksp() :
-         m_start(0),
-         m_end(0),
-         m_K(0),
-         m_heap_paths(false) {
+     Pgr_ksp()
+          {
              m_vis = new Visitor;
          }
      ~Pgr_ksp() {
@@ -229,10 +226,10 @@ class Pgr_ksp :  public Pgr_messages {
      ///@{
      V v_source;  //!< source descriptor
      V v_target;  //!< target descriptor
-     int64_t m_start;  //!< source id
-     int64_t m_end;   //!< target id
-     size_t m_K;
-     bool m_heap_paths;
+     int64_t m_start{0};  //!< source id
+     int64_t m_end{0};   //!< target id
+     size_t m_K{0};
+     bool m_heap_paths{false};
 
      Path curr_result_path;  //!< storage for the current result
 

src/pickDeliver/solution.cpp

@@ -230,7 +230,7 @@ Solution::get_kind() const {
 }
 
 Solution::Solution() :
-    EPSILON(0.0001),
+    
     trucks(problem->trucks()) {
     ENTERING(msg());
     for (const auto &t : trucks) {