Skip to content

Commit af61663

Browse files
committed
Address review comments: remove test comments, rewrite test descriptions for clarity
1 parent d6bce3c commit af61663

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

pgtap/trsp/trspVia_withPoints/edge_cases/issue_2966.pg

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ $BODY$
3434
BEGIN
3535

3636
IF NOT min_version('4.1.0') THEN
37-
RETURN QUERY SELECT skip(1, 'pgr_trspVia_withPoints: Issue 2966 test requires 4.1.0+');
37+
RETURN QUERY SELECT skip(1, 'pgr_trspVia_withPoints: Fix implemented on 4.1.0');
3838
RETURN;
3939
END IF;
4040

@@ -45,7 +45,6 @@ BEGIN
4545
(102::BIGINT, 1002::BIGINT, 1003::BIGINT, 100::FLOAT, 100::FLOAT)
4646
) AS t(id, source, target, cost, reverse_cost);
4747

48-
-- Test 1: fraction = 1 should work correctly
4948
RETURN QUERY SELECT set_eq(
5049
$$SELECT agg_cost::TEXT FROM pgr_trspVia_withPoints(
5150
'SELECT * FROM test_edges',
@@ -55,10 +54,9 @@ BEGIN
5554
'b'
5655
) WHERE edge < 0$$,
5756
ARRAY['17']::TEXT[],
58-
'Issue 2966 (TRSPVia): fraction=1 should route correctly (cost 17, not 105)'
57+
'pgr_trspVia_withPoints: expected cost is 17'
5958
);
6059

61-
-- Test 2: Verify the path uses the correct edges
6260
RETURN QUERY SELECT set_eq(
6361
$$SELECT edge::TEXT FROM pgr_trspVia_withPoints(
6462
'SELECT * FROM test_edges',
@@ -68,7 +66,7 @@ BEGIN
6866
'b'
6967
) WHERE edge > 0$$,
7068
ARRAY['100', '101']::TEXT[],
71-
'Issue 2966 (TRSPVia): Path should use edges 100 and 101'
69+
'pgr_trspVia_withPoints: Path should use edges 100 and 101'
7270
);
7371

7472
DROP TABLE test_edges;

pgtap/trsp/trsp_withpoints/edge_cases/issue_2966.pg

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ $BODY$
3434
BEGIN
3535

3636
IF NOT min_version('4.1.0') THEN
37-
RETURN QUERY SELECT skip(1, 'pgr_trsp_withPoints: Issue 2966 test requires 4.1.0+');
37+
RETURN QUERY SELECT skip(1, 'pgr_trsp_withPoints: Fix implemented on 4.1.0');
3838
RETURN;
3939
END IF;
4040

@@ -45,7 +45,6 @@ BEGIN
4545
(102::BIGINT, 1002::BIGINT, 1003::BIGINT, 100::FLOAT, 100::FLOAT)
4646
) AS t(id, source, target, cost, reverse_cost);
4747

48-
-- Test 1: fraction = 1 should work correctly
4948
RETURN QUERY SELECT set_eq(
5049
$$SELECT agg_cost::TEXT FROM pgr_trsp_withPoints(
5150
'SELECT * FROM test_edges',
@@ -56,10 +55,9 @@ BEGIN
5655
true
5756
) WHERE edge < 0$$,
5857
ARRAY['17']::TEXT[],
59-
'Issue 2966 (TRSP): fraction=1 should route correctly (cost 17, not 105)'
58+
'pgr_trsp_withPoints: expected cost is 17'
6059
);
6160

62-
-- Test 2: Verify the path uses the correct edges
6361
RETURN QUERY SELECT set_eq(
6462
$$SELECT edge::TEXT FROM pgr_trsp_withPoints(
6563
'SELECT * FROM test_edges',
@@ -70,7 +68,7 @@ BEGIN
7068
true
7169
) WHERE edge > 0$$,
7270
ARRAY['100', '101']::TEXT[],
73-
'Issue 2966 (TRSP): Path should use edges 100 and 101'
71+
'pgr_trsp_withPoints: Path should use edges 100 and 101'
7472
);
7573

7674
DROP TABLE test_edges;

0 commit comments

Comments
 (0)