(test) fixing for update test

Author: cvvergara

pgtap/traversal/depthFirstSearch/edge_cases/copmare_BFS.pg

@@ -21,13 +21,19 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 BEGIN;
 
 UPDATE edges SET cost = sign(cost), reverse_cost = sign(reverse_cost);
-SELECT CASE WHEN min_version('4.0.0') THEN plan (17) ELSE plan(17) END;
+SELECT CASE WHEN min_version('3.2.0') THEN plan (17) ELSE plan(1) END;
 
 CREATE OR REPLACE FUNCTION edge_cases()
 RETURNS SETOF TEXT AS
 $BODY$
 BEGIN
 
+  IF NOT min_version('3.2.0') THEN
+    RETURN QUERY
+    SELECT skip(1, 'pgr_depthFirstSearch: Function is new on 3.2.0');
+    RETURN;
+  END IF;
+
   PREPARE sample_data AS
   SELECT id, source, target, cost, reverse_cost
   FROM edges;

pgtap/traversal/depthFirstSearch/edge_cases/directed.pg

@@ -90,7 +90,7 @@ SELECT seq,depth,start_vid,node,edge,cost,agg_cost
 FROM pgr_depthFirstSearch('q3', 4, max_depth => -3);
 
 RETURN QUERY
-SELECT 
+SELECT
   CASE WHEN min_version('4.0.0') THEN
     throws_ok('depthFirstSearch5',
       'XX000', 'Negative value found on ''max_depth''',
@@ -260,7 +260,7 @@ SELECT set_eq('depthFirstSearch14',
 PREPARE q15 AS
 SELECT id, source, target, cost, reverse_cost
 FROM edges
-WHERE id IN (8,10,11,12);
+WHERE id IN (8,10,11,12) ORDER BY id;
 
 RETURN QUERY
 SELECT set_eq('q15',

pgtap/traversal/depthFirstSearch/edge_cases/undirected.pg

@@ -264,7 +264,7 @@ SELECT set_eq('depthFirstSearch14',
 PREPARE q15 AS
 SELECT id, source, target, cost, reverse_cost
 FROM edges
-WHERE id IN (8,10,11,12);
+WHERE id IN (8,10,11,12) ORDER BY id;
 
 RETURN QUERY
 SELECT set_eq('q15',
@@ -289,8 +289,6 @@ PREPARE depthFirstSearch18 AS
 SELECT seq,depth,start_vid,node,edge,cost,agg_cost
 FROM pgr_depthFirstSearch( 'q15', ARRAY[7, 8, 11, 12], directed => false, max_depth => 2);
 
-PERFORM todo_start('sometimes this tests fails');
-
 RETURN QUERY
 SELECT set_eq('depthFirstSearch16',
     $$VALUES
@@ -356,7 +354,6 @@ SELECT set_eq('depthFirstSearch18',
     '18: 4 vertices tests'
   );
 
-PERFORM todo_end();
 END;
 $BODY$
 LANGUAGE plpgsql;

sql/scripts/build-extension-update-files.pl

@@ -278,14 +278,17 @@ sub generate_upgrade_script {
                 push @commands, drop_special_case_function("pgr_dagshortestpath(text,text)");
                 push @commands, drop_special_case_function("pgr_sequentialvertexcoloring(text)");
                 push @commands, drop_special_case_function("pgr_bipartite(text)");
+
+                push @commands, drop_special_case_function("_pgr_depthfirstsearch(text,anyarray,boolean,bigint)");
+                push @commands, drop_special_case_function("pgr_depthfirstsearch(text,anyarray,boolean,bigint)");
+                push @commands, drop_special_case_function("pgr_depthfirstsearch(text,bigint,boolean,bigint)");
             }
 
             if ($old_minor >= "3.3") {
                 push @commands, drop_special_case_function("pgr_edgecoloring(text)");
             }
 
             push @commands, drop_special_case_function("_pgr_breadthfirstsearch(text,anyarray,bigint,boolean)");
-            push @commands, drop_special_case_function("_pgr_depthfirstsearch(text,anyarray,boolean,bigint)");
 
             # Row type defined by OUT parameters is different.
             # Out parameters changed names on v4.0.0
@@ -304,9 +307,6 @@ sub generate_upgrade_script {
             push @commands, drop_special_case_function("pgr_dagshortestpath(text,anyarray,bigint)");
             push @commands, drop_special_case_function("pgr_dagshortestpath(text,anyarray,anyarray)");
 
-            push @commands, drop_special_case_function("pgr_depthfirstsearch(text,anyarray,boolean,bigint)");
-            push @commands, drop_special_case_function("pgr_depthfirstsearch(text,bigint,boolean,bigint)");
-
             push @commands, drop_special_case_function("pgr_edwardmoore(text,bigint,bigint,boolean)");
             push @commands, drop_special_case_function("pgr_edwardmoore(text,anyarray,bigint,boolean)");
             push @commands, drop_special_case_function("pgr_edwardmoore(text,bigint,anyarray,boolean)");