From 9dd441a6bc0fb5024c532a96ac359d6a8fd6e2c2 Mon Sep 17 00:00:00 2001 From: bhavishy2801 Date: Fri, 19 Dec 2025 17:02:25 +0530 Subject: [PATCH 1/5] Add cppcoreguidelines-explicit-virtual-functions --- .clang-tidy | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 1c483387e8..ff5248b0a8 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -6,9 +6,10 @@ Checks: > cppcoreguidelines-avoid-capturing-lambda-coroutines, cppcoreguidelines-avoid-goto, cppcoreguidelines-avoid-non-const-global-variables, - cppcoreguidelines-avoid-reference-coroutine-parameters + cppcoreguidelines-avoid-reference-coroutine-parameters, + cppcoreguidelines-explicit-virtual-functions WarningsAsErrors: '' HeaderFilterRegex: './include' FormatStyle: none -InheritParentConfig: true +InheritParentConfig: true \ No newline at end of file From ff405fccd142095843d50f52a3e724bc136b89f6 Mon Sep 17 00:00:00 2001 From: Bhavishy Agrawal Date: Sat, 27 Dec 2025 03:26:01 +0530 Subject: [PATCH 2/5] fix warnings in assert.hpp --- include/cpp_common/assert.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/cpp_common/assert.hpp b/include/cpp_common/assert.hpp index 2afe6d5a25..6d93b35ae2 100644 --- a/include/cpp_common/assert.hpp +++ b/include/cpp_common/assert.hpp @@ -143,9 +143,9 @@ class AssertFailedException : public std::exception { const std::string str; ///< Holds what() we got as message public: - virtual const char *what() const throw(); + const char *what() const throw() override; explicit AssertFailedException(std::string msg); - virtual ~AssertFailedException() throw() {} + ~AssertFailedException() throw() override {} }; #endif // INCLUDE_CPP_COMMON_ASSERT_HPP_ From 9d78e06f132a3da9ab65e836f0d9733c427db934 Mon Sep 17 00:00:00 2001 From: Bhavishy Agrawal Date: Sun, 28 Dec 2025 01:22:51 +0530 Subject: [PATCH 3/5] fix warnings in assert.hpp --- include/cpp_common/assert.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/cpp_common/assert.hpp b/include/cpp_common/assert.hpp index 6d93b35ae2..17f5391f19 100644 --- a/include/cpp_common/assert.hpp +++ b/include/cpp_common/assert.hpp @@ -143,9 +143,9 @@ class AssertFailedException : public std::exception { const std::string str; ///< Holds what() we got as message public: - const char *what() const throw() override; + const char *what() const noexcept override; explicit AssertFailedException(std::string msg); - ~AssertFailedException() throw() override {} + ~AssertFailedException() noexcept override {} }; #endif // INCLUDE_CPP_COMMON_ASSERT_HPP_ From 9e0588c5e45b57505d92e42042fe451b98cb934b Mon Sep 17 00:00:00 2001 From: Bhavishy Agrawal Date: Wed, 31 Dec 2025 14:37:58 +0530 Subject: [PATCH 4/5] restore .clang-tidy to upstream version --- .clang-tidy | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index ff5248b0a8..4fbc1ded6a 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -6,8 +6,7 @@ Checks: > cppcoreguidelines-avoid-capturing-lambda-coroutines, cppcoreguidelines-avoid-goto, cppcoreguidelines-avoid-non-const-global-variables, - cppcoreguidelines-avoid-reference-coroutine-parameters, - cppcoreguidelines-explicit-virtual-functions + cppcoreguidelines-avoid-reference-coroutine-parameters WarningsAsErrors: '' HeaderFilterRegex: './include' From 95ee8ff61e51f9627e10994bac212f14770c6b0c Mon Sep 17 00:00:00 2001 From: Bhavishy Agrawal Date: Fri, 2 Jan 2026 18:36:38 +0530 Subject: [PATCH 5/5] restore .clang-tidy to upstream develop version --- .clang-tidy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.clang-tidy b/.clang-tidy index 4fbc1ded6a..1c483387e8 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -11,4 +11,4 @@ Checks: > WarningsAsErrors: '' HeaderFilterRegex: './include' FormatStyle: none -InheritParentConfig: true \ No newline at end of file +InheritParentConfig: true