Fix Query Tool state restoration for new connections and queries. #8987

Author: RohitBhati8269

web/pgadmin/settings/static/ApplicationStateProvider.jsx

@@ -71,16 +71,16 @@ export function ApplicationStateProvider({children}){
         if(connectionInfo.is_editor_dirty){
           if(connectionInfo.external_file_changes){
             // file has external chages
-            return {loadFile: loadFile, fileName: fileName, data: toolContent, modifiedExternally: true};
+            return {loadFile: loadFile, fileName: fileName, data: toolContent, modifiedExternally: true, connectionInfo: connectionInfo};
           }
         }else if(connectionInfo.file_deleted){
-          return {loadFile: loadFile, fileName: null, data: toolContent};
+          return {loadFile: loadFile, fileName: null, data: toolContent, connectionInfo: connectionInfo};
         }else{
           loadFile = true;
-          return {loadFile: loadFile, fileName: fileName, data: null};
+          return {loadFile: loadFile, fileName: fileName, data: null, connectionInfo: connectionInfo};
         }
       }
-      return {loadFile: loadFile, fileName: fileName, data: toolContent};
+      return {loadFile: loadFile, fileName: fileName, data: toolContent, connectionInfo: connectionInfo};
 
     } catch (error) {
       let errorMsg = gettext(error?.response?.data?.errormsg || error);

web/pgadmin/tools/sqleditor/static/js/components/QueryToolComponent.jsx

@@ -305,6 +305,30 @@ export default function QueryToolComponent({params, pgWindow, pgAdmin, selectedN
   const restoreToolContent = async () =>{
     let toolContent = await getToolContent(qtState.params.trans_id);
     if(toolContent){
+      const connList = toolContent.connectionInfo?.connection_list;
+      if (Array.isArray(connList) && connList.length > 0) {
+        // ensure exactly one is_selected
+        if (!connList.some(c => c.is_selected)) {
+          connList[0].is_selected = true;
+        }
+        // pick selected connection to update params (so UI shows correct selected conn)
+        const sel = connList.find(c => c.is_selected) || connList[0];
+
+        setQtStatePartial(prev => ({
+          ...prev,
+          connection_list: connList,
+          params: {
+            ...prev.params,
+            sid: sel.sid,
+            did: sel.did,
+            user: sel.user,
+            role: sel.role,
+            server_name: sel.server_name,
+            database_name: sel.database_name,
+            title: sel.title,
+          },
+        }));
+      }
       if (toolContent?.modifiedExternally) {
         toolContent = await fmUtilsObj.warnFileReload(toolContent?.fileName, toolContent.data, '');
       }

web/pgadmin/tools/sqleditor/static/js/components/sections/Query.jsx

@@ -68,6 +68,7 @@ export default function Query({onTextSelect, setQtStatePartial}) {
   const preferencesStore = usePreferences();
   const modalId = MODAL_DIALOGS.QT_CONFIRMATIONS;
   const fmUtilsObj = useMemo(()=>new FileManagerUtils(queryToolCtx.api, {}), []);
+  const initialTransIdRef = React.useRef(queryToolCtx.params.trans_id);
 
   const highlightError = (cmObj, {errormsg: result, data}, executeCursor)=>{
     let errorLineNo = 0,
@@ -363,8 +364,9 @@ export default function Query({onTextSelect, setQtStatePartial}) {
 
   const change = useCallback(()=>{
     eventBus.fireEvent(QUERY_TOOL_EVENTS.QUERY_CHANGED, editor.current.isDirty());
-
-    if(isSaveToolDataEnabled('sqleditor') && editor.current.isDirty()){
+    const value = editor.current.getValue() || '';
+    const isDirty = editor.current.isDirty();
+    if(isSaveToolDataEnabled('sqleditor') && (isDirty || value.length === 0)){
       eventBus.fireEvent(QUERY_TOOL_EVENTS.TRIGGER_SAVE_QUERY_TOOL_DATA);
     }
 
@@ -379,10 +381,22 @@ export default function Query({onTextSelect, setQtStatePartial}) {
 
 
   const [saveQtData, setSaveQtData] = useState(false);
-  useDelayDebounce(()=>{
-    let connectionInfo = { ..._.find(queryToolCtx.connection_list, c => c.is_selected),
-      'open_file_name':queryToolCtx.current_file, 'is_editor_dirty': editor.current.isDirty() };
-    saveToolData('sqleditor', connectionInfo, queryToolCtx.params.trans_id, editor.current.getValue());
+  
+  useDelayDebounce(() => {
+    if (!editor.current) {
+      setSaveQtData(false);
+      return;
+    }
+    const currentTransId = initialTransIdRef.current || queryToolCtx.params.trans_id;
+    const currentConnList = queryToolCtx.connection_list;
+    const currentFile = queryToolCtx.current_file;
+
+    let connectionInfo = {
+      connection_list: currentConnList,
+      open_file_name: currentFile,
+      is_editor_dirty: editor.current.isDirty()
+    };
+    saveToolData('sqleditor', connectionInfo, currentTransId, editor.current.getValue());
     setSaveQtData(false);
   }, saveQtData, 500);