Skip to content

Commit 3a79964

Browse files
committed
Fixed coderabbit ai review comments
1 parent e2abd30 commit 3a79964

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

web/pgadmin/tools/debugger/__init__.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -797,6 +797,7 @@ def filter_params_by_default(params_list, default_value_str):
797797
default_values = []
798798
if default_value_str:
799799
# Split at comma, strip spaces, and add a space after index 0
800+
# as the arguments coming from frontend has space
800801
raw_defaults = str(default_value_str).split(',')
801802
default_values = [
802803
v.strip() if i == 0 else ' ' + v.strip()
@@ -813,6 +814,8 @@ def filter_params_by_default(params_list, default_value_str):
813814
gettext("Once a default value is passed, no "
814815
"subsequent arguments should be provided."))
815816
return params_list[:idx], None
817+
818+
# No params matched defaults, return all params
816819
return params_list, None
817820

818821

@@ -902,15 +905,12 @@ def initialize_target(debug_type, trans_id, sid, did,
902905
# be be required
903906
if request.data:
904907
params_list = json.loads(request.data)
905-
try:
906-
params_list, error_msg = filter_params_by_default(
907-
params_list,
908-
de_inst.function_data['default_value']
909-
)
910-
if error_msg:
911-
return internal_server_error(errormsg=error_msg)
912-
except Exception as e:
913-
return internal_server_error(errormsg=str(e))
908+
params_list, error_msg = filter_params_by_default(
909+
params_list,
910+
de_inst.function_data['default_value']
911+
)
912+
if error_msg:
913+
return internal_server_error(errormsg=error_msg)
914914
de_inst.function_data['args_value'] = params_list
915915
# Update the debugger data session variable
916916
# Here frame_id is required when user debug the multilevel function.

0 commit comments

Comments
 (0)