Fixed an issue where pgadmin cannot install into path with non ASCII characters. #5204

Author: akshay-joshi

docs/en_US/release_notes_9_0.rst

@@ -32,6 +32,7 @@ Housekeeping
 Bug fixes
 *********
 
+  | `Issue #5204 <https://github.com/pgadmin-org/pgadmin4/issues/5204>`_ -  Fixed an issue where pgadmin cannot install into path with non ASCII characters.
   | `Issue #6968 <https://github.com/pgadmin-org/pgadmin4/issues/6968>`_ -  Fixed an issue where option key was not registering in PSQL tool.
   | `Issue #8072 <https://github.com/pgadmin-org/pgadmin4/issues/8072>`_ -  Fixed an issue where Schema Diff not produce difference script for Index definition with where condition.
   | `Issue #8142 <https://github.com/pgadmin-org/pgadmin4/issues/8142>`_ -  Correct the documentation for the MFA configuration.

pkg/win32/installer.iss.in

@@ -145,36 +145,6 @@ begin
   Result := 0;
 end;
 
-function IsPathValid(Path: string): Boolean;
-var
-  I: Integer;
-  Ret: Boolean;
-begin
-  Ret := True;
-  Path := Uppercase(Path);
-  Result :=
-    (Length(Path) >= 3) and
-    (Path[1] >= 'A') and (Path[1] <= 'Z') and
-    (Path[2] = ':') and
-    (Path[3] = '\');
-
-  if Result then
-  begin
-    for I := 3 to Length(Path) do
-      begin
-        case Path[I] of
-          '0'..'9', 'A'..'Z', '\', ' ', '.', '-', '_', '(', ')':
-          else
-          begin
-            Ret := False;
-            break;
-          end;
-      end;
-    end;
-  end;
-  Result := Ret;
-end;
-
 function CheckPgAdminAlreadyInstalled: Boolean;
 var
   Version: String;