Skip to content

Commit e6d2334

Browse files
Pin Electron version to 33.3.2 as the versions above it fails to start on RHEL 8/Rocky 8
1 parent 9f4ce1e commit e6d2334

File tree

5 files changed

+9
-6
lines changed

5 files changed

+9
-6
lines changed

Make.bat

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,7 @@ REM Main build sequence Ends
284284

285285
REM WGET
286286
FOR /f "tokens=*" %%i IN ('npm info electron version') DO SET "ELECTRON_VERSION=%%i"
287+
SET ELECTRON_VERSION="33.3.2"
287288
:GET_NW
288289
wget https://github.com/electron/electron/releases/download/v%ELECTRON_VERSION%/electron-v%ELECTRON_VERSION%-win32-x64.zip -O "%TMPDIR%\electron-v%ELECTRON_VERSION%-win32-x64.zip"
289290
IF %ERRORLEVEL% NEQ 0 GOTO GET_NW

pkg/linux/build-functions.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ _build_runtime() {
141141
fi
142142

143143
ELECTRON_VERSION="$(npm info electron version)"
144+
ELECTRON_VERSION="33.3.2"
144145

145146
pushd "${BUILDROOT}" > /dev/null || exit
146147
while true;do

pkg/mac/build-functions.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ _build_runtime() {
3434
fi
3535

3636
ELECTRON_VERSION="$(npm info electron version)"
37+
ELECTRON_VERSION="33.3.2"
3738

3839
pushd "${BUILD_ROOT}" > /dev/null || exit
3940
while true;do

runtime/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
},
1313
"packageManager": "[email protected]",
1414
"devDependencies": {
15-
"electron": "latest",
15+
"electron": "33.3.2",
1616
"eslint": "^9.19.0"
1717
},
1818
"dependencies": {

runtime/yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -626,16 +626,16 @@ __metadata:
626626
languageName: node
627627
linkType: hard
628628

629-
"electron@npm:latest":
630-
version: 34.0.1
631-
resolution: "electron@npm:34.0.1"
629+
"electron@npm:33.3.2":
630+
version: 33.3.2
631+
resolution: "electron@npm:33.3.2"
632632
dependencies:
633633
"@electron/get": ^2.0.0
634634
"@types/node": ^20.9.0
635635
extract-zip: ^2.0.1
636636
bin:
637637
electron: cli.js
638-
checksum: 8bf0d9757e58379f2b60afed86a70b19a2326559d9c582a96d0970a13c68946c6db74759fd9036ab8971fa8009481a0f6d74c3dbbd413dd0bf31f1f280fa27e9
638+
checksum: ba3b8cfa0d4dd39e176bf89ec5466045b2f6c59f011de9aae19d3ab17a5d91f2701b5b9244b5877ef49aa41542cc9e72e117c8ea28079485e9be41eb4fcecddf
639639
languageName: node
640640
linkType: hard
641641

@@ -1438,7 +1438,7 @@ __metadata:
14381438
resolution: "pgadmin4@workspace:."
14391439
dependencies:
14401440
axios: ^1.7.9
1441-
electron: latest
1441+
electron: 33.3.2
14421442
electron-context-menu: ^4.0.4
14431443
electron-store: ^10.0.0
14441444
eslint: ^9.19.0

0 commit comments

Comments
 (0)