Skip to content

Fix pg_restore logs to distinguish UI sync issues from actual failures. #9074 #9535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akshay-joshi merged 1 commit into from
Jan 14, 2026
Merged

Fix pg_restore logs to distinguish UI sync issues from actual failures. #9074 #9535

akshay-joshi merged 1 commit into from
Jan 14, 2026

Conversation

@RohitBhati8269
Copy link
Contributor

@RohitBhati8269 RohitBhati8269 commented Jan 13, 2026 •
edited by coderabbitai bot
Loading

Detail info:- #9074

Summary by CodeRabbit

  • Bug Fixes
    • Fixed potential error in background process status handling to prevent message formatting failures when exit codes are unavailable.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026 •
edited
Loading

Walkthrough

Tighten error handling in BatchProcess.status by adding a None check alongside the non-zero validation for exit codes before processing error messages, preventing null reference issues.

Changes

Cohort / File(s) Summary
Error handling refinement
web/pgadmin/misc/bgprocess/processes.py		 Added is not None check to exit code validation before formatting error message, ensuring error processing only occurs when exit code exists and is non-zero

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title references fixing pg_restore logs to distinguish UI sync issues from failures, but the actual code change only tightens error handling in BatchProcess.status by requiring exit code is not None. There is a mismatch between the described intent and the actual implementation. Update the PR title to accurately reflect the actual change: something like 'Add null check for exit code in BatchProcess.status error handling' or verify that the code change is complete and addresses the pg_restore logging issue as described.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Jan 13, 2026
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
web/pgadmin/misc/bgprocess/processes.py (1)

633-636: Good fix for preventing false error messages when exit code is None.

The change correctly prevents error message generation when self.ecode is None, since None != 0 evaluates to True in Python, which would have caused misleading error messages for processes with unknown or pending status.

For slightly improved readability, consider checking for None first, as it's the more fundamental guard:

-        if err_completed and self.ecode != 0 and self.ecode is not None:
+        if err_completed and self.ecode is not None and self.ecode != 0:

This follows the common pattern of validating existence before comparing values, though functionally both are equivalent.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74c8b2d and d9f020a.

📒 Files selected for processing (1)
  • web/pgadmin/misc/bgprocess/processes.py
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: run-feature-tests-pg (15)
  • GitHub Check: run-python-tests-pg (windows-latest, 18)
  • GitHub Check: run-python-tests-pg (windows-latest, 17)
  • GitHub Check: run-feature-tests-pg (18)
  • GitHub Check: run-python-tests-pg (windows-latest, 14)
  • GitHub Check: run-feature-tests-pg (14)
  • GitHub Check: run-feature-tests-pg (17)
  • GitHub Check: run-feature-tests-pg (13)
  • GitHub Check: run-feature-tests-pg (16)

@akshay-joshi akshay-joshi merged commit 90be555 into pgadmin-org:master Jan 14, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RohitBhati8269 @akshay-joshi