Batch insert failed when upgrading to 0.9

[hantsy]

I have the following method to insert a collection which worked in r2dbc 0.8. The complete codes is here,
https://github.com/hantsy/spring6-sandbox/tree/master/r2dbc

@Override
    public Flux<UUID> saveAll(List<Post> data) {
        var sql = "INSERT INTO  posts (title, content, status) VALUES ($1, $2, $3)";
        return this.databaseClient.inConnectionMany(connection -> {

            var statement = connection.createStatement(sql)
                    .returnGeneratedValues("id");

            data.forEach(p -> {
                statement.bind(0, p.getTitle())
                        .bind(1, p.getContent())
                        .bind(2, p.getStatus())
                        .add();
            });

            return Flux.from(statement.execute()).flatMap(result -> result.map((row, rowMetadata) -> row.get("id", UUID.class)));
        });
    }

When update r2dbc to the latest Borca-RELEASE, it failed.

I got the following exceptions.

java.lang.IllegalStateException: Bound parameter count does not match parameters in SQL statement
	at io.r2dbc.postgresql.client.Binding.validate(Binding.java:176)
	at java.base/java.util.ArrayDeque.forEach(ArrayDeque.java:888)
	at io.r2dbc.postgresql.PostgresqlStatement.execute(PostgresqlStatement.java:206)
	at io.r2dbc.postgresql.PostgresqlStatement.execute(PostgresqlStatement.java:144)
	at io.r2dbc.postgresql.PostgresqlStatement.execute(PostgresqlStatement.java:56)
	at com.example.demo.domain.repository.R2dbcPostRepository.lambda$saveAll$7(R2dbcPostRepository.java:99)
	at org.springframework.r2dbc.core.DefaultDatabaseClient.lambda$inConnectionMany$6(DefaultDatabaseClient.java:141)

[mp911de]

You have a trailing .add() call. As per r2dbc/r2dbc-spi#259, if you provide the last binding to the batch Statement, then you must not call add as final operation but execute.

[hantsy]

This API is too ugly.

[hantsy]

A working version.

 public Flux<UUID> saveAll(List<Post> data) {
        if(data == null || data.isEmpty()) {
            throw new IllegalArgumentException("The parameter is invalid");
        }
        var sql = "INSERT INTO  posts (title, content, status) VALUES ($1, $2, $3)";
        return this.databaseClient.inConnectionMany(connection -> {

            var statement = connection.createStatement(sql)
                    .returnGeneratedValues("id");
            var len = data.size();

            if (len > 1) {
                for (Post p : data.subList(0, len - 1)) {
                    statement.bind(0, p.getTitle())
                            .bind(1, p.getContent())
                            .bind(2, p.getStatus())
                            .add();
                }
            }
            var last = data.get(len - 1);

            statement.bind(0, last.getTitle())
                    .bind(1, last.getContent())
                    .bind(2, last.getStatus());
                   // .add(); // remove add in the last binding.

            return Flux.from(statement.execute()).flatMap(result -> result.map((row, rowMetadata) -> row.get("id", UUID.class)));
        });
    }

[mp911de]

R2DBC SPI isn't intended to be used directly by applications, it's designed to be used by libraries.