v4.5.0 Fix v4.4.1 upgrade. Better compatibility with generated columns. See CHANGELOG for more details.

Author: keithf4

CHANGELOG.txt

@@ -1,3 +1,19 @@
+4.5.0
+NEW FEATURES
+============
+-- Officially supported minimal version is now PostgreSQL 9.6. PostgreSQL 9.6 support will be ending the next pg_partman release after PostgreSQL 14 is released.
+
+-- Removed p_debug from functions changed in this update. Slowly migrating all functions away from parameter to using debug logging level instead.
+
+BUG FIXES
+=========
+-- Fixed issue when upgrading from 4.4.0 to 4.4.1 on PG10 and below. Upgrade path now goes directly from 4.4.0 to 4.5.0 and skips 4.4.1. All changes in 4.4.1 have been included in 4.5.0 where necessary. (Github Issue #342)
+
+-- Added the parameter `p_ignored_columns` to partition_data_time(), partition_data_id(), partition_data_proc(), undo_partition() and undo_partition_proc(). The parameter is an array that can list one or more columns to ignore their values when moving the data. This allows for moving data out of the default/parent table when generated columns are in use. (Github Issue #336)
+
+-- Fixed the p_start_partition parameter working properly with id->timestamp sub-partitioning. (Github Issue #341)
+
+
 4.4.1
 NEW FEATURES
 ============

META.json

@@ -1,7 +1,7 @@
 {
     "name": "pg_partman",
     "abstract": "Extension to manage partitioned tables by time or ID",
-    "version": "4.4.1",
+    "version": "4.5.0",
     "maintainer": [ 
         "Keith Fiske <[email protected]>"
     ],
@@ -11,7 +11,7 @@
     "prereqs": {
         "runtime": {
             "requires": {
-                "PostgreSQL": "9.4.0"
+                "PostgreSQL": "9.6.0"
             },
             "recommends": {
                 "pg_jobmon": "1.3.2"
@@ -20,9 +20,9 @@
     },
     "provides": {
         "pg_partman": {
-            "file": "sql/pg_partman--4.4.1.sql",
+            "file": "sql/pg_partman--4.5.0.sql",
             "docfile": "doc/pg_partman.md",
-            "version": "4.4.1",
+            "version": "4.5.0",
             "abstract": "Extension to manage partitioned tables by time or ID"
         }
     },

README.md

@@ -21,7 +21,7 @@ INSTALLATION
 ------------
 Requirement: 
 
- * PostgreSQL >= 9.5
+ * PostgreSQL >= 9.6
 
 Recommended: 
 

doc/pg_partman.md

@@ -1,3 +1,3 @@
-default_version = '4.4.1'
+default_version = '4.5.0'
 comment = 'Extension to manage partitioned tables by time or ID'
 relocatable = false

pg_partman.control

@@ -1,4 +1,4 @@
-CREATE FUNCTION @[email protected]_constraints(p_parent_table text, p_child_table text DEFAULT NULL, p_analyze boolean DEFAULT FALSE, p_job_id bigint DEFAULT NULL, p_debug boolean DEFAULT FALSE) RETURNS void
+CREATE FUNCTION @[email protected]_constraints(p_parent_table text, p_child_table text DEFAULT NULL, p_analyze boolean DEFAULT FALSE, p_job_id bigint DEFAULT NULL) RETURNS void
     LANGUAGE plpgsql
     AS $$
 DECLARE
@@ -74,9 +74,7 @@ WHERE parent_table = p_parent_table
 AND constraint_cols IS NOT NULL;
 
 IF v_constraint_cols IS NULL THEN
-    IF p_debug THEN
-        RAISE NOTICE 'Given parent table (%) not set up for constraint management (constraint_cols is NULL)', p_parent_table;
-    END IF;
+    RAISE DEBUG 'Given parent table (%) not set up for constraint management (constraint_cols is NULL)', p_parent_table;
     -- Returns silently to allow this function to be simply called by maintenance processes without having to check if config options are set.
     RETURN;
 END IF;
@@ -124,9 +122,7 @@ IF p_child_table IS NULL THEN
 
     v_child_tablename := @[email protected]_name_length(v_parent_tablename, v_partition_suffix, TRUE);
 
-    IF p_debug THEN
-        RAISE NOTICE 'apply_constraint: v_parent_tablename: % , v_partition_suffix: %', v_parent_tablename, v_partition_suffix;
-    END IF;
+    RAISE DEBUG 'apply_constraint: v_parent_tablename: % , v_partition_suffix: %', v_parent_tablename, v_partition_suffix;
 
     IF v_jobmon_schema IS NOT NULL THEN
         PERFORM update_step(v_step_id, 'OK', format('Target child table: %s.%s', v_parent_schema, v_child_tablename));
@@ -147,9 +143,7 @@ IF v_child_exists IS NULL THEN
             PERFORM close_job(v_job_id);
         END IF;
     END IF;
-    IF p_debug THEN
-        RAISE NOTICE 'Target child table (%) does not exist. Skipping constraint creation.', v_child_tablename;
-    END IF;
+    RAISE DEBUG 'Target child table (%) does not exist. Skipping constraint creation.', v_child_tablename;
     EXECUTE format('SELECT set_config(%L, %L, %L)', 'search_path', v_old_search_path, 'false');
     RETURN;
 ELSE
@@ -182,9 +176,7 @@ LOOP
         IF v_jobmon_schema IS NOT NULL THEN
             PERFORM update_step(v_step_id, 'NOTICE', format('Partman managed constraint already exists on this table (%s) and column (%s). Skipping creation.', v_child_tablename, v_col));
         END IF;
-        IF p_debug THEN
-            RAISE NOTICE 'Partman managed constraint already exists on this table (%) and column (%). Skipping creation.', v_child_tablename, v_col ;
-        END IF;
+        RAISE DEBUG 'Partman managed constraint already exists on this table (%) and column (%). Skipping creation.', v_child_tablename, v_col ;
         CONTINUE;
     END IF;
 
@@ -207,18 +199,14 @@ LOOP
             v_sql := format('%s NOT VALID', v_sql);
         END IF;
 
-        IF p_debug THEN
-            RAISE NOTICE 'Constraint creation query: %', v_sql;
-        END IF;
+        RAISE DEBUG 'Constraint creation query: %', v_sql;
         EXECUTE v_sql;
 
         IF v_jobmon_schema IS NOT NULL THEN
             PERFORM update_step(v_step_id, 'OK', format('New constraint created: %s', v_sql));
         END IF;
     ELSE
-        IF p_debug THEN
-            RAISE NOTICE 'Given column (%) contains all NULLs. No constraint created', v_col;
-        END IF;
+        RAISE DEBUG 'Given column (%) contains all NULLs. No constraint created', v_col;
         IF v_jobmon_schema IS NOT NULL THEN
             PERFORM update_step(v_step_id, 'NOTICE', format('Given column (%s) contains all NULLs. No constraint created', v_col));
         END IF;
@@ -230,10 +218,7 @@ IF p_analyze THEN
     IF v_jobmon_schema IS NOT NULL THEN
         v_step_id := add_step(v_job_id, format('Applying additional constraints: Running analyze on partition set: %s', v_parent_table));
     END IF;
-    IF p_debug THEN
-        RAISE NOTICE 'Running analyze on partition set: %', v_parent_table;
-    END IF;
-
+    RAISE DEBUG 'Running analyze on partition set: %', v_parent_table;
     EXECUTE format('ANALYZE %I.%I', v_parent_schema, v_parent_tablename);
 
     IF v_jobmon_schema IS NOT NULL THEN
@@ -270,4 +255,3 @@ HINT: %', ex_message, ex_context, ex_detail, ex_hint;
 END
 $$;
 
-

sql/functions/apply_constraints.sql

@@ -13,8 +13,7 @@ CREATE FUNCTION @[email protected]_parent(
     , p_publications text[] DEFAULT NULL
     , p_trigger_return_null boolean DEFAULT true
     , p_template_table text DEFAULT NULL
-    , p_jobmon boolean DEFAULT true
-    , p_debug boolean DEFAULT false) 
+    , p_jobmon boolean DEFAULT true) 
 RETURNS boolean 
     LANGUAGE plpgsql 
     AS $$

sql/functions/create_parent.sql

@@ -1,4 +1,4 @@
-CREATE FUNCTION @[email protected]_partition_id(p_parent_table text, p_partition_ids bigint[], p_analyze boolean DEFAULT true, p_debug boolean DEFAULT false) RETURNS boolean
+CREATE FUNCTION @[email protected]_partition_id(p_parent_table text, p_partition_ids bigint[], p_analyze boolean DEFAULT true, p_start_partition text DEFAULT NULL) RETURNS boolean
     LANGUAGE plpgsql 
     AS $$
 DECLARE
@@ -175,9 +175,7 @@ FOREACH v_id IN ARRAY p_partition_ids LOOP
         END IF;
     END IF;
 
-    IF p_debug THEN
-        RAISE NOTICE 'create_partition_id v_sql: %', v_sql;
-    END IF;
+    RAISE DEBUG 'create_partition_id v_sql: %', v_sql;
     EXECUTE v_sql;
 
     IF v_partition_type = 'native' THEN
@@ -284,7 +282,8 @@ FOREACH v_id IN ARRAY p_partition_ids LOOP
                 , p_inherit_fk := %L
                 , p_epoch := %L
                 , p_template_table := %L
-                , p_jobmon := %L )'
+                , p_jobmon := %L
+                , p_start_partition := %L )'
             , v_parent_schema||'.'||v_partition_name
             , v_row.sub_control
             , v_row.sub_partition_type
@@ -295,7 +294,9 @@ FOREACH v_id IN ARRAY p_partition_ids LOOP
             , v_row.sub_inherit_fk
             , v_row.sub_epoch
             , v_row.sub_template_table
-            , v_row.sub_jobmon);
+            , v_row.sub_jobmon
+            , p_start_partition);
+        RAISE DEBUG 'create_partition_id (create_parent loop): %', v_sql;
         EXECUTE v_sql;
 
         UPDATE @[email protected]_config SET 
@@ -320,7 +321,7 @@ FOREACH v_id IN ARRAY p_partition_ids LOOP
     END LOOP; -- end sub partitioning LOOP
 
     -- Manage additonal constraints if set
-    PERFORM @[email protected]_constraints(p_parent_table, p_job_id := v_job_id, p_debug := p_debug);
+    PERFORM @[email protected]_constraints(p_parent_table, p_job_id := v_job_id);
 
     IF v_publications IS NOT NULL THEN
         -- NOTE: Publications currently not supported on parent table, but are supported on the table partitions if individually assigned.

sql/functions/create_partition_id.sql

@@ -1,4 +1,4 @@
-CREATE FUNCTION @[email protected]_partition_time(p_parent_table text, p_partition_times timestamptz[], p_analyze boolean DEFAULT true, p_debug boolean DEFAULT false) 
+CREATE FUNCTION @[email protected]_partition_time(p_parent_table text, p_partition_times timestamptz[], p_analyze boolean DEFAULT true, p_start_partition text DEFAULT NULL) 
 RETURNS boolean
     LANGUAGE plpgsql
     AS $$
@@ -123,9 +123,7 @@ v_partition_expression := CASE
     WHEN v_epoch = 'milliseconds' THEN format('to_timestamp((%I/1000)::float)', v_control)
     ELSE format('%I', v_control)
 END;
-IF p_debug THEN
-    RAISE NOTICE 'create_partition_time: v_partition_expression: %', v_partition_expression;
-END IF;
+RAISE DEBUG 'create_partition_time: v_partition_expression: %', v_partition_expression;
 
 FOREACH v_time IN ARRAY p_partition_times LOOP    
     v_partition_timestamp_start := v_time;
@@ -221,9 +219,7 @@ FOREACH v_time IN ARRAY p_partition_times LOOP
         END IF;
     END IF;
 
-    IF p_debug THEN
-        RAISE NOTICE 'create_partition_time v_sql: %', v_sql;
-    END IF;
+    RAISE DEBUG 'create_partition_time v_sql: %', v_sql;
     EXECUTE v_sql;
 
 
@@ -390,7 +386,8 @@ FOREACH v_time IN ARRAY p_partition_times LOOP
                 , p_inherit_fk := %L
                 , p_epoch := %L
                 , p_template_table := %L
-                , p_jobmon := %L )'
+                , p_jobmon := %L
+                , p_start_partition := %L )'
             , v_parent_schema||'.'||v_partition_name
             , v_row.sub_control
             , v_row.sub_partition_type
@@ -401,10 +398,10 @@ FOREACH v_time IN ARRAY p_partition_times LOOP
             , v_row.sub_inherit_fk
             , v_row.sub_epoch
             , v_row.sub_template_table
-            , v_row.sub_jobmon);
-        IF p_debug THEN
-            RAISE NOTICE 'create_partition_time (create_parent loop): %', v_sql;
-        END IF;
+            , v_row.sub_jobmon
+            , p_start_partition);
+        
+        RAISE DEBUG 'create_partition_time (create_parent loop): %', v_sql;
         EXECUTE v_sql;
 
         UPDATE @[email protected]_config SET 
@@ -425,7 +422,7 @@ FOREACH v_time IN ARRAY p_partition_times LOOP
     END LOOP; -- end sub partitioning LOOP
 
     -- Manage additonal constraints if set
-    PERFORM @[email protected]_constraints(p_parent_table, p_job_id := v_job_id, p_debug := p_debug);
+    PERFORM @[email protected]_constraints(p_parent_table, p_job_id := v_job_id);
 
     IF v_publications IS NOT NULL THEN
         -- NOTE: Publications currently not supported on parent table, but are supported on the table partitions if individually assigned.
@@ -489,4 +486,3 @@ HINT: %', ex_message, ex_context, ex_detail, ex_hint;
 END
 $$;
 
-

sql/functions/create_partition_time.sql

@@ -11,8 +11,7 @@ CREATE FUNCTION @[email protected]_sub_parent(
     , p_epoch text DEFAULT 'none' 
     , p_upsert text DEFAULT ''
     , p_trigger_return_null boolean DEFAULT true
-    , p_jobmon boolean DEFAULT true
-    , p_debug boolean DEFAULT false) 
+    , p_jobmon boolean DEFAULT true) 
 RETURNS boolean
     LANGUAGE plpgsql 
     AS $$
@@ -198,10 +197,10 @@ LOOP
 
             IF v_child_start_id IS NOT NULL THEN
                 v_partition_id_array[0] := v_child_start_id;
-                PERFORM @[email protected]_partition_id(p_top_parent, v_partition_id_array, true);
+                PERFORM @[email protected]_partition_id(p_top_parent, v_partition_id_array, true, p_start_partition);
             ELSIF v_child_start_time IS NOT NULL THEN
                 v_partition_time_array[0] := v_child_start_time;
-                PERFORM @[email protected]_partition_time(p_top_parent, v_partition_time_array, true);
+                PERFORM @[email protected]_partition_time(p_top_parent, v_partition_time_array, true, p_start_partition);
             END IF;
         ELSE
             SELECT a.attname
@@ -241,8 +240,7 @@ LOOP
                 , p_upsert := %L
                 , p_trigger_return_null := %L
                 , p_template_table := %L
-                , p_jobmon := %L
-                , p_debug := %L )'
+                , p_jobmon := %L)'
             , v_row.child_schema||'.'||v_row.child_tablename
             , p_control
             , p_type
@@ -256,8 +254,7 @@ LOOP
             , p_upsert
             , p_trigger_return_null
             , v_template_table
-            , p_jobmon
-            , p_debug);
+            , p_jobmon);
         EXECUTE v_sql;
     END IF; -- end recreate check
 
@@ -272,4 +269,3 @@ RETURN v_success;
 END
 $$;
 
-