Skip to content

Commit 52284b5

Browse files
committed
Added todos [skip ci]
1 parent 48769bb commit 52284b5

File tree

3 files changed

+8
-0
lines changed

3 files changed

+8
-0
lines changed

include/pgvector/halfvec.hpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,13 @@ class HalfVector {
2323
HalfVector() = default;
2424

2525
/// Creates a half vector from a `std::vector<float>`.
26+
// TODO add explicit in 0.3.0
2627
HalfVector(const std::vector<float>& value) {
2728
value_ = value;
2829
}
2930

3031
/// Creates a half vector from a `std::vector<float>`.
32+
// TODO add explicit in 0.3.0
3133
HalfVector(std::vector<float>&& value) {
3234
value_ = std::move(value);
3335
}
@@ -39,6 +41,7 @@ class HalfVector {
3941

4042
#if __cplusplus >= 202002L
4143
/// Creates a half vector from a span.
44+
// TODO add explicit in 0.3.0
4245
HalfVector(std::span<const float> value) {
4346
value_ = std::vector<float>(value.begin(), value.end());
4447
}

include/pgvector/sparsevec.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ class SparseVector {
3434
}
3535

3636
/// Creates a sparse vector from a dense vector.
37+
// TODO add explicit in 0.3.0
3738
SparseVector(const std::vector<float>& value) {
3839
dimensions_ = value.size();
3940
for (size_t i = 0; i < value.size(); i++) {
@@ -47,6 +48,7 @@ class SparseVector {
4748

4849
#if __cplusplus >= 202002L
4950
/// Creates a sparse vector from a span.
51+
// TODO add explicit in 0.3.0
5052
SparseVector(std::span<const float> value) {
5153
dimensions_ = value.size();
5254
for (size_t i = 0; i < value.size(); i++) {

include/pgvector/vector.hpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,13 @@ class Vector {
2323
Vector() = default;
2424

2525
/// Creates a vector from a `std::vector<float>`.
26+
// TODO add explicit in 0.3.0
2627
Vector(const std::vector<float>& value) {
2728
value_ = value;
2829
}
2930

3031
/// Creates a vector from a `std::vector<float>`.
32+
// TODO add explicit in 0.3.0
3133
Vector(std::vector<float>&& value) {
3234
value_ = std::move(value);
3335
}
@@ -39,6 +41,7 @@ class Vector {
3941

4042
#if __cplusplus >= 202002L
4143
/// Creates a vector from a span.
44+
// TODO add explicit in 0.3.0
4245
Vector(std::span<const float> value) {
4346
value_ = std::vector<float>(value.begin(), value.end());
4447
}

0 commit comments

Comments
 (0)