Restored backwards compatibility of Bit constructor

Author: ankane

pgvector/bit.py

@@ -1,5 +1,6 @@
 import numpy as np
 from struct import pack, unpack_from
+from warnings import warn
 
 
 class Bit:
@@ -9,15 +10,11 @@ def __init__(self, value):
         elif isinstance(value, bytes):
             self._value = np.unpackbits(np.frombuffer(value, dtype=np.uint8)).astype(bool)
         else:
-            if isinstance(value, np.ndarray):
-                if value.dtype == np.uint8:
-                    value = np.unpackbits(value).astype(bool)
-                elif value.dtype != np.bool:
-                    raise ValueError('expected dtype to be bool or uint8')
-            else:
-                value = np.asarray(value)
-                if value.dtype != np.bool:
-                    raise ValueError('expected all elements to be boolean')
+            value = np.asarray(value)
+
+            if value.dtype != np.bool:
+                warn('expected elements to be boolean', stacklevel=2)
+                value = value.astype(bool)
 
             if value.ndim != 1:
                 raise ValueError('expected ndim to be 1')

tests/test_bit.py

@@ -8,14 +8,12 @@ def test_list(self):
         assert Bit([True, False, True]).to_list() == [True, False, True]
 
     def test_list_none(self):
-        with pytest.raises(ValueError) as error:
-            Bit([True, None, True])
-        assert str(error.value) == 'expected all elements to be boolean'
+        with pytest.warns(UserWarning, match='expected elements to be boolean'):
+            assert Bit([True, None, True]).to_text() == '101'
 
     def test_list_int(self):
-        with pytest.raises(ValueError) as error:
-            Bit([254, 7, 0])
-        assert str(error.value) == 'expected all elements to be boolean'
+        with pytest.warns(UserWarning, match='expected elements to be boolean'):
+            assert Bit([254, 7, 0]).to_text() == '110'
 
     def test_tuple(self):
         assert Bit((True, False, True)).to_list() == [True, False, True]
@@ -29,13 +27,13 @@ def test_bytes(self):
 
     def test_ndarray_uint8(self):
         arr = np.array([254, 7, 0], dtype=np.uint8)
-        assert Bit(arr).to_text() == '111111100000011100000000'
+        with pytest.warns(UserWarning, match='expected elements to be boolean'):
+            assert Bit(arr).to_text() == '110'
 
     def test_ndarray_uint16(self):
         arr = np.array([254, 7, 0], dtype=np.uint16)
-        with pytest.raises(ValueError) as error:
-            Bit(arr)
-        assert str(error.value) == 'expected dtype to be bool or uint8'
+        with pytest.warns(UserWarning, match='expected elements to be boolean'):
+            assert Bit(arr).to_text() == '110'
 
     def test_ndarray_same_object(self):
         arr = np.array([True, False, True])