Changed default values of globally and arrays for register_type with Psycopg 2 [skip ci]

Author: ankane

pgvector/psycopg2/register.py

@@ -5,10 +5,8 @@
 from .vector import register_vector_info
 
 
-# TODO make globally False by default in 0.4.0
 # note: register_adapter is always global
-# TODO make arrays True by defalt in 0.4.0
-def register_vector(conn_or_curs, globally=True, arrays=False):
+def register_vector(conn_or_curs, globally=False, arrays=True):
     conn = conn_or_curs if hasattr(conn_or_curs, 'cursor') else conn_or_curs.connection
     cur = conn.cursor(cursor_factory=cursor)
     scope = None if globally else conn_or_curs

tests/test_psycopg2.py

@@ -12,7 +12,7 @@
 cur.execute('DROP TABLE IF EXISTS psycopg2_items')
 cur.execute('CREATE TABLE psycopg2_items (id bigserial PRIMARY KEY, embedding vector(3), half_embedding halfvec(3), binary_embedding bit(3), sparse_embedding sparsevec(3), embeddings vector[], half_embeddings halfvec[], sparse_embeddings sparsevec[])')
 
-register_vector(cur, globally=False, arrays=True)
+register_vector(cur)
 
 
 class TestPsycopg2:
@@ -87,13 +87,13 @@ def test_cursor_factory(self):
         for cursor_factory in [DictCursor, RealDictCursor, NamedTupleCursor]:
             conn = psycopg2.connect(dbname='pgvector_python_test')
             cur = conn.cursor(cursor_factory=cursor_factory)
-            register_vector(cur, globally=False)
+            register_vector(cur)
             conn.close()
 
     def test_cursor_factory_connection(self):
         for cursor_factory in [DictCursor, RealDictCursor, NamedTupleCursor]:
             conn = psycopg2.connect(dbname='pgvector_python_test', cursor_factory=cursor_factory)
-            register_vector(conn, globally=False)
+            register_vector(conn)
             conn.close()
 
     def test_pool(self):
@@ -102,7 +102,7 @@ def test_pool(self):
         conn = pool.getconn()
         try:
             # use globally=True for apps to ensure registered with all connections
-            register_vector(conn, globally=False)
+            register_vector(conn)
         finally:
             pool.putconn(conn)
 

tests/test_sqlalchemy.py

@@ -24,7 +24,7 @@
 @event.listens_for(psycopg2_type_engine, "connect")
 def psycopg2_connect(dbapi_connection, connection_record):
     from pgvector.psycopg2 import register_vector
-    register_vector(dbapi_connection, globally=False, arrays=True)
+    register_vector(dbapi_connection)
 
 
 pg8000_engine = create_engine(f'postgresql+pg8000://{os.environ["USER"]}@localhost/pgvector_python_test')