Skip to content

Commit d3e9463

Browse files
committed
Merge branch '4.0.x'
* 4.0.x: (116 commits) Regenerating ext again Updated changelog for PECL Updated optimized build files Generating ext folder Updated version for release [#14858] - PHPCS [#14858] - Corrected and added more tests [#14858] - Updated changelog [#14858] - Moved models to check outside the models folder to avoid collisions [#14858] - Fixed test [#14858] - Fixed dirFromFile to remove "." for Windows add backer (github) Update changelog [skip ci] Update tests schemas Add condition to add 'default NULL' with 'ON UPDATE' Fix query Add test case with 'default null on update' Remove Products model Move setDatabase() inside mvcModelCriteriaJoinManyToManyMultipleSchema() method Remove duplicate setDatabase() method ...
2 parents b28b0a2 + 3791b07 commit d3e9463

File tree

472 files changed

+5336
-4351
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

472 files changed

+5336
-4351
lines changed

.github/workflows/build-and-test.yml

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,6 @@ jobs:
141141
- 5432
142142
env:
143143
POSTGRES_PASSWORD: secret
144-
POSTGRES_USER: phalcon
145144
POSTGRES_DB: phalcon
146145
redis:
147146
image: redis:5-alpine
@@ -228,26 +227,34 @@ jobs:
228227
DATA_MEMCACHED_PORT: ${{ job.services.memcached.ports['11211'] }}
229228
run: vendor/bin/codecept run --ext DotReporter integration
230229

230+
- name: Run database tests Common
231+
env:
232+
DATA_REDIS_PORT: ${{ job.services.redis.ports['6379'] }}
233+
DATA_MEMCACHED_PORT: ${{ job.services.memcached.ports['11211'] }}
234+
DATA_MYSQL_USER: root
235+
run: vendor/bin/codecept run --ext DotReporter database -g common
236+
231237
- name: Run database tests MySQL
232238
env:
233239
DATA_MYSQL_PORT: ${{ job.services.mysql.ports['3306'] }}
234240
DATA_REDIS_PORT: ${{ job.services.redis.ports['6379'] }}
235241
DATA_MEMCACHED_PORT: ${{ job.services.memcached.ports['11211'] }}
236-
run: vendor/bin/codecept run --ext DotReporter database --env mysql
242+
DATA_MYSQL_USER: root
243+
run: vendor/bin/codecept run --ext DotReporter database --env mysql -g mysql
237244

238245
- name: Run database tests Sqlite
239246
env:
240247
DATA_REDIS_PORT: ${{ job.services.redis.ports['6379'] }}
241248
DATA_MEMCACHED_PORT: ${{ job.services.memcached.ports['11211'] }}
242-
run: vendor/bin/codecept run --ext DotReporter database --env sqlite
249+
run: vendor/bin/codecept run --ext DotReporter database --env sqlite -g sqlite
243250

244-
# # TODO Enable these one at a time and also for MacOS/Windows
245-
# - name: Run database tests Postgres
246-
# env:
247-
# DATA_POSTGRES_PORT: ${{ job.services.postgres.ports['5432'] }}
248-
# DATA_REDIS_PORT: ${{ job.services.redis.ports['6379'] }}
249-
# DATA_MEMCACHED_PORT: ${{ job.services.memcached.ports['11211'] }}
250-
# run: vendor/bin/codecept run --ext DotReporter database --env pgsql
251+
- name: Run database tests Postgres
252+
env:
253+
DATA_POSTGRES_USER: postgres
254+
DATA_POSTGRES_PORT: ${{ job.services.postgres.ports['5432'] }}
255+
DATA_REDIS_PORT: ${{ job.services.redis.ports['6379'] }}
256+
DATA_MEMCACHED_PORT: ${{ job.services.memcached.ports['11211'] }}
257+
run: vendor/bin/codecept run --ext DotReporter database --env pgsql -g pgsql
251258
# - name: Run integrations tests SQL Server
252259
# env:
253260
# DATA_REDIS_PORT: ${{ job.services.redis.ports['6379'] }}

.github/workflows/codecoverage.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,12 +166,14 @@ jobs:
166166
DATA_POSTGRES_PORT: ${{ job.services.postgres.ports['5432'] }}
167167
DATA_REDIS_PORT: ${{ job.services.redis.ports['6379'] }}
168168
DATA_MEMCACHED_PORT: ${{ job.services.memcached.ports['11211'] }}
169+
DATA_MYSQL_USER: root
169170
run: |
170171
vendor/bin/codecept run --ext DotReporter cli
171172
vendor/bin/codecept run --ext DotReporter unit
172173
vendor/bin/codecept run --ext DotReporter integration
173-
vendor/bin/codecept run --ext DotReporter database --env mysql
174-
vendor/bin/codecept run --ext DotReporter database --env sqlite
174+
vendor/bin/codecept run --ext DotReporter database -g common
175+
vendor/bin/codecept run --ext DotReporter database -g mysql --env mysql
176+
vendor/bin/codecept run --ext DotReporter database -g sqlite --env sqlite
175177
176178
- name: Upload codecoverage on 7.4
177179
uses: codecov/codecov-action@v1

BACKERS.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,16 +82,19 @@ Thanks for the support
8282

8383
<a href="https://github.com/ninjapanzer"><img src="https://avatars1.githubusercontent.com/u/159591?s=460&v=4" title="Paul Scarrone" width="60" height="60"></a>
8484
<a href="https://github.com/vlad-light"><img src="https://avatars1.githubusercontent.com/u/277235?s=460&v=4" title="Vladimir L" width="60" height="60"></a>
85+
<a href="https://github.com/alrieckert"><img src="https://avatars1.githubusercontent.com/u/452786?s=460&v=4" title="Anton Rieckert" width="60" height="60"></a>
8586
<a href="https://github.com/sinbadxiii"><img src="https://avatars2.githubusercontent.com/u/900273?s=460&v=4" title="Sergey Mukhin" width="60" height="60"></a>
8687
<a href="https://github.com/niden"><img src="https://avatars2.githubusercontent.com/u/1073784?s=460&v=4" title="Nikolaos Dimopoulos" width="60" height="60"></a>
8788
<a href="https://github.com/qmegas"><img src="https://avatars3.githubusercontent.com/u/2444896?s=460&v=4" title="qmegas" width="60" height="60"></a>
8889
<a href="https://github.com/terolblade"><img src="https://avatars3.githubusercontent.com/u/3078649?s=460&v=4" title="Stanislav Sviridenko" width="60" height="60"></a>
8990
<a href="https://github.com/Ruzgfpegk"><img src="https://avatars1.githubusercontent.com/u/3818364?s=460&v=4" title="Ruzgfpegk" width="60" height="60"></a>
9091
<a href="https://github.com/zsilbi"><img src="https://avatars2.githubusercontent.com/u/3886658?s=460&v=4" title="Balázs Németh" width="60" height="60"></a>
92+
<a href="https://github.com/olegatro"><img src="https://avatars3.githubusercontent.com/u/4980366?s=460&v=4" title="Oleg Scherbakov" width="60" height="60"></a>
9193
<a href="https://github.com/ruudboon"><img src="https://avatars3.githubusercontent.com/u/7444246?s=460&v=4" title="Ruud Boon" width="60" height="60"></a>
9294
<a href="https://github.com/sitchi"><img src="https://avatars0.githubusercontent.com/u/11546683?s=460&v=4" title="Nikoloz Sitchinava" width="60" height="60"></a>
9395
<a href="https://github.com/Montana"><img src="https://avatars3.githubusercontent.com/u/20936398?s=460&v=4" title="Montana Mendy" width="60" height="60"></a>
9496
<a href="https://github.com/ak1113"><img src="https://avatars0.githubusercontent.com/u/38716832?s=460&v=4" title="Akira Kato" width="60" height="60"></a>
97+
<a href="https://github.com/mr-ginting"><img src="https://avatars2.githubusercontent.com/u/61111859?s=460&v=4" title="Herbet" width="60" height="60"></a>
9598

9699
[//]: github-sponsors
97100

CHANGELOG-4.0.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
1-
# [4.0.5](https://github.com/phalcon/cphalcon/releases/tag/v4.0.5) (2020-xx-xx)
1+
# [4.0.5](https://github.com/phalcon/cphalcon/releases/tag/v4.0.5) (2020-03-07)
22
## Added
33

44
## Changed
55

66
## Fixed
7-
7+
- Fixed `Phalcon\Db::fetchAll` to correctly return data when `Enum::FETCH_COLUMN` is supplied. [#13321](https://github.com/phalcon/cphalcon/issues/13321)
8+
- Fixed Postgres NULL values to not be required during model update. [#14862](https://github.com/phalcon/cphalcon/issues/14862)
9+
- Fixed MySQL alter column when default value contains not only CURRENT_TIMESTAMP [#14880](https://github.com/phalcon/cphalcon/issues/14880)
10+
- Fixed MySQL default value with ON UPDATE expression [#14887](https://github.com/phalcon/cphalcon/pull/14887)
11+
- Fixed `Str::dirFromFile()` to replace `.` with `-` to avoid issues with Windows environments [#14858](https://github.com/phalcon/cphalcon/issues/14858)
812

913
# [4.0.4](https://github.com/phalcon/cphalcon/releases/tag/v4.0.4) (2020-02-15)
1014
## Added

appveyor.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# For the full copyright and license information, please view
66
# the LICENSE.txt file that was distributed with this source code.
77

8-
version: 4.0.4+{build}
8+
version: 4.0.5+{build}
99

1010
environment:
1111
matrix:
@@ -86,7 +86,7 @@ install:
8686
- ps: >-
8787
InstallPeclExtension `
8888
-Name psr `
89-
-Version 0.7.0 `
89+
-Version 1.0.0 `
9090
-PhpVersion $Env:PHP_VERSION `
9191
-BuildType $Env:BUILD_TYPE `
9292
-VC $Env:VC_VERSION `

0 commit comments

Comments
 (0)