Better property hook fix and add a test

Author: rlerdorf

src/Parser.php

@@ -3199,6 +3199,14 @@ private function parsePostfixExpressionRest($expression, $allowUpdateExpression
 
         if ($tokenKind === TokenKind::OpenBraceToken ||
             $tokenKind === TokenKind::OpenBracketToken) {
+            // Property hooks: don't parse `{` after certain expression types
+            // as those are property hook lists, not subscript expressions
+            if ($tokenKind === TokenKind::OpenBraceToken &&
+                ($expression instanceof StringLiteral ||
+                 $expression instanceof ArrayCreationExpression ||
+                 $expression instanceof ObjectCreationExpression)) {
+                return $expression;
+            }
             $expression = $this->parseSubscriptExpression($expression);
             return $this->parsePostfixExpressionRest($expression);
         }

tests/cases/parser/propertyHook4.php.diag

@@ -1,68 +1 @@
-[
-    {
-        "kind": 0,
-        "message": "'}' expected.",
-        "start": 158,
-        "length": 0
-    },
-    {
-        "kind": 0,
-        "message": "'}' expected.",
-        "start": 158,
-        "length": 0
-    },
-    {
-        "kind": 0,
-        "message": "';' expected.",
-        "start": 158,
-        "length": 0
-    },
-    {
-        "kind": 0,
-        "message": "'}' expected.",
-        "start": 158,
-        "length": 0
-    },
-    {
-        "kind": 0,
-        "message": "Unexpected '}'",
-        "start": 214,
-        "length": 1
-    },
-    {
-        "kind": 0,
-        "message": "')' expected.",
-        "start": 234,
-        "length": 0
-    },
-    {
-        "kind": 0,
-        "message": "';' expected.",
-        "start": 234,
-        "length": 0
-    },
-    {
-        "kind": 0,
-        "message": "';' expected.",
-        "start": 241,
-        "length": 0
-    },
-    {
-        "kind": 0,
-        "message": "Unexpected ')'",
-        "start": 241,
-        "length": 1
-    },
-    {
-        "kind": 0,
-        "message": "Unexpected '}'",
-        "start": 326,
-        "length": 1
-    },
-    {
-        "kind": 0,
-        "message": "Unexpected '}'",
-        "start": 328,
-        "length": 1
-    }
-]
+[]