[ML] Migrate Alibaba Senders to SenderExecutableAction (elastic#134515)

- Remove AlibabaCloudSearch*Action classes in favour of using
  SenderExecutableAction in AlibabaCloudSearchActionCreator
- Consolidate redundant GoogleDiscoveryEngineRateLimitServiceSettings
  and GoogleVertexAiEmbeddingsRateLimitServiceSettings interfaces with
  GoogleVertexAiRateLimitServiceSettings
- Rename fields on CustomRequestManager.RateLimitGrouping and
  AlibabaCloudSearchRequestManager.RateLimitGrouping to better reflect
  what they actually are
- Add tests for AlibabaCloudSearchActionCreator
- Migrate some existing tests to
  AlibabaCloudSearchCompletionRequestManagerTests

Author: DonalEvans

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/action/SenderExecutableAction.java

@@ -18,7 +18,7 @@
 
 import static org.elasticsearch.xpack.inference.external.action.ActionUtils.wrapFailuresInElasticsearchException;
 
-public class SenderExecutableAction implements ExecutableAction {
+public sealed class SenderExecutableAction implements ExecutableAction permits SingleInputSenderExecutableAction {
 
     private final Sender sender;
     private final RequestManager requestManager;

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/action/SingleInputSenderExecutableAction.java

@@ -18,7 +18,7 @@
 
 import java.util.Objects;
 
-public class SingleInputSenderExecutableAction extends SenderExecutableAction {
+public final class SingleInputSenderExecutableAction extends SenderExecutableAction {
     private final String requestTypeForInputValidationError;
 
     public SingleInputSenderExecutableAction(

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/alibabacloudsearch/AlibabaCloudSearchCompletionRequestManager.java

@@ -9,8 +9,10 @@
 
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
+import org.elasticsearch.ElasticsearchStatusException;
 import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.inference.InferenceServiceResults;
+import org.elasticsearch.rest.RestStatus;
 import org.elasticsearch.threadpool.ThreadPool;
 import org.elasticsearch.xpack.inference.external.http.retry.RequestSender;
 import org.elasticsearch.xpack.inference.external.http.retry.ResponseHandler;
@@ -71,6 +73,16 @@ public void execute(
         ActionListener<InferenceServiceResults> listener
     ) {
         List<String> input = inferenceInputs.castTo(ChatCompletionInput.class).getInputs();
+        if (input.size() % 2 == 0) {
+            listener.onFailure(
+                new ElasticsearchStatusException(
+                    "Alibaba Completion's inputs must be an odd number. The last input is the current query, "
+                        + "all preceding inputs are the completion history as pairs of user input and the assistant's response.",
+                    RestStatus.BAD_REQUEST
+                )
+            );
+            return;
+        }
         AlibabaCloudSearchCompletionRequest request = new AlibabaCloudSearchCompletionRequest(account, input, model);
         execute(new ExecutableInferenceRequest(requestSender, logger, request, HANDLER, hasRequestCompletedFunction, listener));
     }

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/alibabacloudsearch/AlibabaCloudSearchRequestManager.java

@@ -18,7 +18,7 @@ protected AlibabaCloudSearchRequestManager(ThreadPool threadPool, AlibabaCloudSe
         super(threadPool, model.getInferenceEntityId(), RateLimitGrouping.of(model), model.rateLimitServiceSettings().rateLimitSettings());
     }
 
-    record RateLimitGrouping(int apiKeyHash) {
+    record RateLimitGrouping(int serviceSettingsHash) {
         public static RateLimitGrouping of(AlibabaCloudSearchModel model) {
             Objects.requireNonNull(model);
 

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/alibabacloudsearch/action/AlibabaCloudSearchActionCreator.java

@@ -8,8 +8,14 @@
 package org.elasticsearch.xpack.inference.services.alibabacloudsearch.action;
 
 import org.elasticsearch.xpack.inference.external.action.ExecutableAction;
+import org.elasticsearch.xpack.inference.external.action.SenderExecutableAction;
 import org.elasticsearch.xpack.inference.external.http.sender.Sender;
 import org.elasticsearch.xpack.inference.services.ServiceComponents;
+import org.elasticsearch.xpack.inference.services.alibabacloudsearch.AlibabaCloudSearchAccount;
+import org.elasticsearch.xpack.inference.services.alibabacloudsearch.AlibabaCloudSearchCompletionRequestManager;
+import org.elasticsearch.xpack.inference.services.alibabacloudsearch.AlibabaCloudSearchEmbeddingsRequestManager;
+import org.elasticsearch.xpack.inference.services.alibabacloudsearch.AlibabaCloudSearchRerankRequestManager;
+import org.elasticsearch.xpack.inference.services.alibabacloudsearch.AlibabaCloudSearchSparseRequestManager;
 import org.elasticsearch.xpack.inference.services.alibabacloudsearch.completion.AlibabaCloudSearchCompletionModel;
 import org.elasticsearch.xpack.inference.services.alibabacloudsearch.embeddings.AlibabaCloudSearchEmbeddingsModel;
 import org.elasticsearch.xpack.inference.services.alibabacloudsearch.rerank.AlibabaCloudSearchRerankModel;
@@ -18,6 +24,8 @@
 import java.util.Map;
 import java.util.Objects;
 
+import static org.elasticsearch.xpack.inference.external.action.ActionUtils.constructFailedToSendRequestMessage;
+
 /**
  * Provides a way to construct an {@link ExecutableAction} using the visitor pattern based on the alibaba cloud search model type.
  */
@@ -33,28 +41,40 @@ public AlibabaCloudSearchActionCreator(Sender sender, ServiceComponents serviceC
     @Override
     public ExecutableAction create(AlibabaCloudSearchEmbeddingsModel model, Map<String, Object> taskSettings) {
         var overriddenModel = AlibabaCloudSearchEmbeddingsModel.of(model, taskSettings);
+        var account = new AlibabaCloudSearchAccount(overriddenModel.getSecretSettings().apiKey());
+        var requestManager = AlibabaCloudSearchEmbeddingsRequestManager.of(account, overriddenModel, serviceComponents.threadPool());
+        var failedToSendRequestErrorMessage = constructFailedToSendRequestMessage("AlibabaCloud Search text embeddings");
 
-        return new AlibabaCloudSearchEmbeddingsAction(sender, overriddenModel, serviceComponents);
+        return new SenderExecutableAction(sender, requestManager, failedToSendRequestErrorMessage);
     }
 
     @Override
     public ExecutableAction create(AlibabaCloudSearchSparseModel model, Map<String, Object> taskSettings) {
         var overriddenModel = AlibabaCloudSearchSparseModel.of(model, taskSettings);
+        var account = new AlibabaCloudSearchAccount(overriddenModel.getSecretSettings().apiKey());
+        var requestManager = AlibabaCloudSearchSparseRequestManager.of(account, overriddenModel, serviceComponents.threadPool());
+        var failedToSendRequestErrorMessage = constructFailedToSendRequestMessage("AlibabaCloud Search sparse embeddings");
 
-        return new AlibabaCloudSearchSparseAction(sender, overriddenModel, serviceComponents);
+        return new SenderExecutableAction(sender, requestManager, failedToSendRequestErrorMessage);
     }
 
     @Override
     public ExecutableAction create(AlibabaCloudSearchRerankModel model, Map<String, Object> taskSettings) {
         var overriddenModel = AlibabaCloudSearchRerankModel.of(model, taskSettings);
+        var account = new AlibabaCloudSearchAccount(overriddenModel.getSecretSettings().apiKey());
+        var requestManager = AlibabaCloudSearchRerankRequestManager.of(account, overriddenModel, serviceComponents.threadPool());
+        var failedToSendRequestErrorMessage = constructFailedToSendRequestMessage("AlibabaCloud Search rerank");
 
-        return new AlibabaCloudSearchRerankAction(sender, overriddenModel, serviceComponents);
+        return new SenderExecutableAction(sender, requestManager, failedToSendRequestErrorMessage);
     }
 
     @Override
     public ExecutableAction create(AlibabaCloudSearchCompletionModel model, Map<String, Object> taskSettings) {
         var overriddenModel = AlibabaCloudSearchCompletionModel.of(model, taskSettings);
+        var account = new AlibabaCloudSearchAccount(overriddenModel.getSecretSettings().apiKey());
+        var requestManager = AlibabaCloudSearchCompletionRequestManager.of(account, overriddenModel, serviceComponents.threadPool());
+        var failedToSendRequestErrorMessage = constructFailedToSendRequestMessage("AlibabaCloud Search completion");
 
-        return new AlibabaCloudSearchCompletionAction(sender, overriddenModel, serviceComponents);
+        return new SenderExecutableAction(sender, requestManager, failedToSendRequestErrorMessage);
     }
 }