Skip to content

Commit bae780e

Browse files
committed
Mirror upstream elastic#134329 as single snapshot commit for AI review
BASE=cf671ff721da8a26d4d3e30346b6bb639968f268 HEAD=8021513035fb4cd706874e9b3301dc43fdef0845 Branch=main
1 parent cf671ff commit bae780e

File tree

2 files changed

+41
-1
lines changed

2 files changed

+41
-1
lines changed

server/src/main/java/org/elasticsearch/TransportVersion.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,10 @@ public static TransportVersion fromBufferedReader(
117117
Integer upperBound
118118
) {
119119
try {
120-
String line = bufferedReader.readLine();
120+
String line;
121+
do {
122+
line = bufferedReader.readLine();
123+
} while (line.replaceAll("\\s+", "").startsWith("#"));
121124
String[] parts = line.replaceAll("\\s+", "").split(",");
122125
String check;
123126
while ((check = bufferedReader.readLine()) != null) {

server/src/test/java/org/elasticsearch/TransportVersionTests.java

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,4 +354,41 @@ public void testSupports() {
354354
assertThat(new TransportVersion(null, 100001000, null).supports(test4), is(true));
355355
assertThat(new TransportVersion(null, 100001001, null).supports(test4), is(true));
356356
}
357+
358+
public void testComment() {
359+
byte[] data1 = ("#comment" + System.lineSeparator() + "1000000").getBytes(StandardCharsets.UTF_8);
360+
TransportVersion test1 = TransportVersion.fromBufferedReader(
361+
"<test>",
362+
"testSupports3",
363+
false,
364+
true,
365+
new BufferedReader(new InputStreamReader(new ByteArrayInputStream(data1), StandardCharsets.UTF_8)),
366+
5000000
367+
);
368+
assertThat(new TransportVersion(null, 1000000, null).supports(test1), is(true));
369+
370+
byte[] data2 = (" # comment" + System.lineSeparator() + "1000000").getBytes(StandardCharsets.UTF_8);
371+
TransportVersion test2 = TransportVersion.fromBufferedReader(
372+
"<test>",
373+
"testSupports3",
374+
false,
375+
true,
376+
new BufferedReader(new InputStreamReader(new ByteArrayInputStream(data2), StandardCharsets.UTF_8)),
377+
5000000
378+
);
379+
assertThat(new TransportVersion(null, 1000000, null).supports(test2), is(true));
380+
381+
byte[] data3 = ("#comment" + System.lineSeparator() + "# comment3" + System.lineSeparator() + "1000000").getBytes(
382+
StandardCharsets.UTF_8
383+
);
384+
TransportVersion test3 = TransportVersion.fromBufferedReader(
385+
"<test>",
386+
"testSupports3",
387+
false,
388+
true,
389+
new BufferedReader(new InputStreamReader(new ByteArrayInputStream(data3), StandardCharsets.UTF_8)),
390+
5000000
391+
);
392+
assertThat(new TransportVersion(null, 1000000, null).supports(test3), is(true));
393+
}
357394
}

0 commit comments

Comments
 (0)