More renaming from stop to end

Author: felixbarny

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/PromqlParser.java

@@ -49,21 +49,21 @@ public LogicalPlan createStatement(String query) {
         return createStatement(query, null, null);
     }
 
-    public LogicalPlan createStatement(String query, Instant start, Instant stop) {
+    public LogicalPlan createStatement(String query, Instant start, Instant end) {
         if (log.isDebugEnabled()) {
             log.debug("Parsing as expression: {}", query);
         }
 
         if (start == null) {
             start = Instant.now(UTC);
         }
-        return invokeParser(query, start, stop, PromqlBaseParser::singleStatement, PromqlAstBuilder::plan);
+        return invokeParser(query, start, end, PromqlBaseParser::singleStatement, PromqlAstBuilder::plan);
     }
 
     private <T> T invokeParser(
         String query,
         Instant start,
-        Instant stop,
+        Instant end,
         Function<PromqlBaseParser, ParserRuleContext> parseFunction,
         BiFunction<PromqlAstBuilder, ParserRuleContext, T> visitor
     ) {
@@ -97,7 +97,7 @@ private <T> T invokeParser(
             if (log.isTraceEnabled()) {
                 log.trace("Parse tree: {}", tree.toStringTree());
             }
-            return visitor.apply(new PromqlAstBuilder(start, stop), tree);
+            return visitor.apply(new PromqlAstBuilder(start, end), tree);
         } catch (StackOverflowError e) {
             throw new ParsingException(
                 "PromQL statement is too large, causing stack overflow when generating the parsing tree: [{}]",

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/promql/ExpressionBuilder.java

@@ -74,20 +74,20 @@
 
 class ExpressionBuilder extends IdentifierBuilder {
 
-    protected final Instant start, stop;
+    protected final Instant start, end;
 
     ExpressionBuilder() {
         this(null, null);
     }
 
-    ExpressionBuilder(Instant start, Instant stop) {
+    ExpressionBuilder(Instant start, Instant end) {
         Instant now = null;
-        if (start == null || stop == null) {
+        if (start == null || end == null) {
             now = DateUtils.nowWithMillisResolution().toInstant();
         }
 
         this.start = start != null ? start : now;
-        this.stop = stop != null ? stop : now;
+        this.end = end != null ? end : now;
     }
 
     protected Expression expression(ParseTree ctx) {
@@ -282,7 +282,7 @@ public Evaluation visitEvaluation(EvaluationContext ctx) {
             if (atCtx.AT_START() != null) {
                 at = start;
             } else if (atCtx.AT_END() != null) {
-                at = stop;
+                at = end;
             } else {
                 TimeValue timeValue = visitTimeValue(atCtx.timeValue());
                 // the value can have a floating point

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/promql/PromqlAstBuilder.java

@@ -23,8 +23,8 @@ public PromqlAstBuilder() {
         this(null, null);
     }
 
-    public PromqlAstBuilder(Instant start, Instant stop) {
-        super(start, stop);
+    public PromqlAstBuilder(Instant start, Instant end) {
+        super(start, end);
     }
 
     public LogicalPlan plan(ParseTree ctx) {

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/promql/PromqlLogicalPlanBuilder.java

@@ -50,8 +50,8 @@ public class PromqlLogicalPlanBuilder extends ExpressionBuilder {
         this(null, null);
     }
 
-    PromqlLogicalPlanBuilder(Instant start, Instant stop) {
-        super(start, stop);
+    PromqlLogicalPlanBuilder(Instant start, Instant end) {
+        super(start, end);
     }
 
     protected LogicalPlan plan(ParseTree ctx) {