You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/CONTRIBUTING.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,6 +1,6 @@
1
1
# Contribution to {admiral}
2
2
3
-
This outlines how to propose a change to the admiral package. For more detailed info about contributing to {admiral}, and other [pharmaverse packages](https://pharmaverse.org/), please see the [Contribution Guide](https://pharmaverse.github.io/admiral/CONTRIBUTING.html) as well as other Developer Guides in the Articles section of the [{admiraldev} website](https://pharmaverse.github.io/admiraldev/).
3
+
This outlines how to propose a change to the admiral package. For more detailed info about contributing to {admiral}, and other [pharmaverse packages](https://pharmaverse.org/), please see the [Contribution Guide](https://pharmaverse.github.io/admiral/cran-release/CONTRIBUTING.html) as well as other Developer Guides in the Articles section of the [{admiraldev} website](https://pharmaverse.github.io/admiraldev/).
4
4
5
5
Please note that we try to align to best practices used in other R packages' development processes - so veteran developers should be familiar with our processes. However, we do deviate slightly from some best practices and we advise all new contributors to review our package documentation accordingly.
6
6
@@ -59,15 +59,15 @@ If you decide to contribute with code and you're ready to make your first code c
59
59
If so, remember to run `devtools::document()` and include the
60
60
updated `NAMESPACE` and `.Rd` files in `man/`.
61
61
e. Does your code update have any impact on the [ADaM
Copy file name to clipboardExpand all lines: .github/pull_request_template.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,4 +1,4 @@
1
-
Thank you for your Pull Request! We have developed this task checklist from the [Development Process Guide](https://pharmaverse.github.io/admiral/CONTRIBUTING.html#detailed-development-process) to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
1
+
Thank you for your Pull Request! We have developed this task checklist from the [Development Process Guide](https://pharmaverse.github.io/admiral/cran-release/CONTRIBUTING.html#detailed-development-process) to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
2
2
3
3
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the `main` branch until you have checked off each task.
4
4
@@ -11,7 +11,7 @@ Please check off each taskbox as an acknowledgment that you completed the task o
11
11
-[ ] Run `devtools::document()` so all `.Rd` files in the `man` folder and the `NAMESPACE` file in the project root are updated appropriately
12
12
-[ ] Address any updates needed for vignettes and/or templates
13
13
-[ ] Update `NEWS.md` under the header `# admiral (development version)` if the changes pertain to a user-facing function (i.e. it has an `@export` tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in `NEWS.md` for tracking developer-facing issues.
14
-
-[ ] Build admiral site `pkgdown::build_site()` and check that all affected examples are displayed correctly and that all new functions occur on the "[Reference](https://pharmaverse.github.io/admiral/reference/index.html)" page.
14
+
-[ ] Build admiral site `pkgdown::build_site()` and check that all affected examples are displayed correctly and that all new functions occur on the "[Reference](https://pharmaverse.github.io/admiral/cran-release/reference/index.html)" page.
15
15
-[ ] Address or fix all lintr warnings and errors - `lintr::lint_package()`
16
16
-[ ] Run `R CMD check` locally and address all errors and warnings - `devtools::check()`
17
17
-[ ] Link the issue in the Development Section on the right hand side.
-`date_imputation`, `time_imputation`, and `preserve` in `date_source()`
@@ -1191,7 +1191,7 @@ empty (#1309)
1191
1191
1192
1192
1193
1193
-`create_query_data()` is provided to create the [queries
1194
-
dataset](https://pharmaverse.github.io/admiral/articles/queries_dataset.html) required as input for `derive_vars_query()` (#606)
1194
+
dataset](https://pharmaverse.github.io/admiral/cran-release/articles/queries_dataset.html) required as input for `derive_vars_query()` (#606)
1195
1195
1196
1196
-`create_single_dose_dataset()` - Derives dataset of single dose from aggregate dose information (#660)
1197
1197
@@ -1224,7 +1224,7 @@ first disease progression. (#1023)
1224
1224
### ADLB
1225
1225
1226
1226
- New ADLB template script available `ad_adlb.R`, specific ADLB functions developed and
1227
-
[BDS Finding vignette](https://pharmaverse.github.io/admiral/articles/bds_finding.html) has examples enhanced with ADLB functions. (#1122)
1227
+
[BDS Finding vignette](https://pharmaverse.github.io/admiral/cran-release/articles/bds_finding.html) has examples enhanced with ADLB functions. (#1122)
1228
1228
1229
1229
-`derive_var_shift()` - Derives a character shift variable containing concatenated shift in values based on user-defined pairing (#944)
1230
1230
-`derive_var_analysis_ratio()` - Derives a ratio variable based on user-supplied variables from a BDS dataset, e.g. ADLB. (#943)
@@ -1306,7 +1306,7 @@ specific for admiral. Derivations like this can be implemented calling
1306
1306
- Updated `derive_var_worst_flag()` and `derive_var_extreme_flag()` vignettes to clarify their purpose (#691)
- Examples have been added for `format_reason_default()`, `format_eoxxstt_default()`, `extend_source_datasets()` and `filter_date_sources()` (#745)
@@ -1392,7 +1392,7 @@ this case the day is imputed as `15` (#592)
1392
1392
1393
1393
- README and site homepage has been updated with important new section around expectations of {admiral}, as well as other useful references such as links to conference talks (#868 & #802)
1394
1394
1395
-
- New vignette [Development Process](https://pharmaverse.github.io/admiral/CONTRIBUTING.html) and improvements made to contribution vignettes (#765 & #758)
1395
+
- New vignette [Development Process](https://pharmaverse.github.io/admiral/cran-release/CONTRIBUTING.html) and improvements made to contribution vignettes (#765 & #758)
1396
1396
1397
1397
- Updated [Pull Request Review Guidance](https://pharmaverse.github.io/admiraldev/articles/pr_review_guidance.html) on using `task-list-completed` workflow (#817)
1398
1398
@@ -1406,7 +1406,7 @@ this case the day is imputed as `15` (#592)
1406
1406
1407
1407
- The first truly open source release licensed under Apache 2.0 (#680)
1408
1408
1409
-
- New vignette [Contributing to admiral](https://pharmaverse.github.io/admiral/CONTRIBUTING.html) (#679)
1409
+
- New vignette [Contributing to admiral](https://pharmaverse.github.io/admiral/cran-release/CONTRIBUTING.html) (#679)
1410
1410
1411
1411
- New vignette [Unit Test Guidance](https://pharmaverse.github.io/admiraldev/articles/unit_test_guidance.html) (#679)
1412
1412
@@ -1428,7 +1428,7 @@ age in different units (#569)
The `{admiral}` family has several downstream and upstream dependencies and so releases are done in two Phases:
40
40
41
-
* Phase 1 release is for [{admiraldev}](https://pharmaverse.github.io/admiraldev/), [{pharmaversesdtm}](https://pharmaverse.github.io/pharmaversesdtm/), and [{admiral}](https://pharmaverse.github.io/admiral/) core
41
+
* Phase 1 release is for [{admiraldev}](https://pharmaverse.github.io/admiraldev/), [{pharmaversesdtm}](https://pharmaverse.github.io/pharmaversesdtm/), and [{admiral}](https://pharmaverse.github.io/admiral/cran-release/) core
42
42
* Phase 2 release is extension packages, e.g. [{admiralonco}](https://pharmaverse.github.io/admiralonco/), [{admiralophtha}](https://pharmaverse.github.io/admiralophtha/), [{admiralvaccine}](https://pharmaverse.github.io/admiralvaccine/) and [{pharmaverseadam}](https://pharmaverse.github.io/pharmaverseadam/).
43
43
44
44
| Release Schedule | Phase 1- Date and Packages | Phase 2- Date and Packages |
@@ -47,12 +47,12 @@ The `{admiral}` family has several downstream and upstream dependencies and so r
* Pharmaceutical communities and companies are encouraged to contribute to `{admiral}` following
80
80
the provided programming strategy and modular approach
81
81
* Functions that are comprehensively documented and tested, including example calls---these are
82
-
all listed in the [Reference section](https://pharmaverse.github.io/admiral/reference/index.html).
82
+
all listed in the [Reference section](https://pharmaverse.github.io/admiral/cran-release/reference/index.html).
83
83
* Vignettes on how to create ADSL, BDS and OCCDS datasets, including example scripts.
84
84
* Vignettes for ADaM dataset specific functionality (i.e. dictionary coding, date imputation, SMQs ...).
85
85
@@ -161,12 +161,12 @@ that all our developers and contributors must follow, so that all our code has a
161
161
162
162
## References and Documentation
163
163
164
-
* Please go to [Get Started](https://pharmaverse.github.io/admiral/articles/admiral.html) section to start using `{admiral}`.
164
+
* Please go to [Get Started](https://pharmaverse.github.io/admiral/cran-release/articles/admiral.html) section to start using `{admiral}`.
165
165
* Please see the [pharmaverse YouTube channel](https://www.youtube.com/channel/UCxQFEv8HNqM01DXzdQLCy6Q) for videos related to `{admiral}`.
166
166
* Please see the [Programming Strategy](https://pharmaverse.github.io/admiraldev/articles/programming_strategy.html) to understand how functions are created.
167
-
* Please see the [FAQ](https://pharmaverse.github.io/admiral/articles/faq.html) for the most frequent questions.
168
-
* Please see the [Contribution Model](https://pharmaverse.github.io/admiral/CONTRIBUTING.html) for how to get involved with making contributions.
169
-
* Please see [FAQ: R and Package Versions](https://pharmaverse.github.io/admiral/articles/faq.html#why-do-we-use-a-certain-r-version-and-package-versions-for-development) for why we develop with certain R and package versions.
167
+
* Please see the [FAQ](https://pharmaverse.github.io/admiral/cran-release/articles/faq.html) for the most frequent questions.
168
+
* Please see the [Contribution Model](https://pharmaverse.github.io/admiral/cran-release/CONTRIBUTING.html) for how to get involved with making contributions.
169
+
* Please see [FAQ: R and Package Versions](https://pharmaverse.github.io/admiral/cran-release/articles/faq.html#why-do-we-use-a-certain-r-version-and-package-versions-for-development) for why we develop with certain R and package versions.
Copy file name to clipboardExpand all lines: _pkgdown.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -24,7 +24,7 @@ development:
24
24
version_label: default
25
25
26
26
authors:
27
-
before: "We define *authors* as those who are actively maintaining the code base, and *contributors* as those who made a significant contribution in the past. For all acknowledgements, see the eponymous section in the [Home Page](https://pharmaverse.github.io/admiral/)."
27
+
before: "We define *authors* as those who are actively maintaining the code base, and *contributors* as those who made a significant contribution in the past. For all acknowledgements, see the eponymous section in the [Home Page](https://pharmaverse.github.io/admiral/cran-release/)."
0 commit comments